From: Kito Cheng <kito.cheng@gmail.com>
To: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
jeffreyalaw <jeffreyalaw@gmail.com>,
"pan2.li" <pan2.li@intel.com>,
"yanzhang.wang" <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Fix one typo for emit_mode_set.
Date: Mon, 3 Jul 2023 21:41:55 +0800 [thread overview]
Message-ID: <CA+yXCZD7+HxW=uApoSfEj0S+srdd9O7Pnyeawd-sUVkgugppBw@mail.gmail.com> (raw)
In-Reply-To: <0FE0DE1B205EE6FE+2023070319112399611415@rivai.ai>
[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]
Lgtm
juzhe.zhong@rivai.ai <juzhe.zhong@rivai.ai>於 2023年7月3日 週一,19:11寫道:
> LGTM
>
>
>
> juzhe.zhong@rivai.ai
>
> From: pan2.li
> Date: 2023-07-03 18:57
> To: gcc-patches
> CC: juzhe.zhong; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng
> Subject: [PATCH v1] RISC-V: Fix one typo for emit_mode_set.
> From: Pan Li <pan2.li@intel.com>
>
> This patch would like to fix one typo for scaler[should be scalar] in
> emit_mode_set, as well as minor change for mov emit.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_emit_mode_set): Fix typo.
> ---
> gcc/config/riscv/riscv.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index e4dc8115e69..7761e946761 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -7672,11 +7672,11 @@ riscv_emit_mode_set (int entity, int mode, int
> prev_mode,
> case RISCV_FRM:
> if (mode != FRM_MODE_NONE && mode != prev_mode)
> {
> - rtx scaler = gen_reg_rtx (SImode);
> + rtx scalar = gen_reg_rtx (SImode);
> rtx imm = gen_int_mode (mode, SImode);
> - emit_insn (gen_movsi (scaler, imm));
> - emit_insn (gen_fsrm (scaler, scaler));
> + emit_move_insn (scalar, imm);
> + emit_insn (gen_fsrm (scalar, scalar));
> }
> break;
> default:
> --
> 2.34.1
>
>
>
next prev parent reply other threads:[~2023-07-03 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 10:57 pan2.li
2023-07-03 11:11 ` juzhe.zhong
2023-07-03 13:41 ` Kito Cheng [this message]
2023-07-24 21:49 ` Maciej W. Rozycki
2023-07-24 23:19 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZD7+HxW=uApoSfEj0S+srdd9O7Pnyeawd-sUVkgugppBw@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=pan2.li@intel.com \
--cc=yanzhang.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).