From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by sourceware.org (Postfix) with ESMTPS id 6C69E3858D20 for ; Mon, 12 Jun 2023 14:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C69E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-55b3b3e2928so2997985eaf.2 for ; Mon, 12 Jun 2023 07:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686578874; x=1689170874; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3mwt18QZx1oq/ozoCnwZ1XvJuTgdLytxSr8jzAqKyTc=; b=nq/T0S0dPIztvSg9SRGaqk0GbtvkYKxtlwXtCF3l1BhXi78w58owh+CQ/FuvwcU4Po qmxmGlPDF/KHBrIJ4tl9RQ1bnUrT7U05ZuvjGZo8bt4TT/X4SHMSHRc1Ny51FA6y0ms0 xvg3WoqKwYS9zE+KjTHm/mRkCMOT5TuzWzXXqxBdMuAdOCfaBlAof941lrYHcHewmlZQ Gta0CBQr9x+q1fCQJBStYaZ9uG5V/BDX5ccnfpQZFJTVTgTd0FyYGN4yvBp/yHxK9QN1 HYjjQbaOTTErlhpM6dhismzB8CE1gR0QCfik/eLVhp7tbOi8eTZIpRExMdXrUzFft9/j Vu1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686578874; x=1689170874; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3mwt18QZx1oq/ozoCnwZ1XvJuTgdLytxSr8jzAqKyTc=; b=Ei/QKSb9lTbEzRxWCrtjOdCWIMr8VChaquJcvjbMRMFwebbEWCPSC3YsilUjqJG66G aMF9smo5LUdi/2q4BnVT0KuO3/f8Xd/bWVbEViKANOyc4vrLg2Yod7L3BYpMTjeVL+9U 5vFPsX8eju9DrNStULmJEDnWw5dnWr2hSGp9Ocy+JxANiAg2DUMRsd/P3aeaPIy5gQ3L ggt/6PQfyKLobYqTZL3JSLijMhC2w10RBbVQ/8x4N/jwg86sQ5YmD8rDfKqsVNDfcttR Iv6mWfS1SuDJtWNFRWeGTiCm7E2f6fR8LExA9OoznJ75oZFfaJjnTQ9vb9HjZcEKo2Wy zV2g== X-Gm-Message-State: AC+VfDxKr7h8mRJTy0BLDJebIkUzlMkJ9K3WtDybd8pUgWfcM5AGJWrf 3cGQSW9qLwiXNkvM3J53K11ep/lPvrAh3SvZ+6A= X-Google-Smtp-Source: ACHHUZ6mTpOwPQoyGtfuudC0Ccb/Y/x08HS+IYOFYeJfHoq4xHAAGa9pwrAGeaINARNh08X42Gx4PWVuAcp39UwSC0M= X-Received: by 2002:a05:6358:9d91:b0:12b:dd43:b0a5 with SMTP id d17-20020a0563589d9100b0012bdd43b0a5mr1585324rwo.24.1686578874110; Mon, 12 Jun 2023 07:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20230426123743.3210243-1-yanzhang.wang@intel.com> <20230612080828.1292728-1-yanzhang.wang@intel.com> In-Reply-To: From: Kito Cheng Date: Mon, 12 Jun 2023 22:07:42 +0800 Message-ID: Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking. To: "Wang, Yanzhang" Cc: Kito Cheng , "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "Li, Pan2" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: How about appending to DEFAULT_CFLAGS? On Mon, Jun 12, 2023 at 9:38=E2=80=AFPM Wang, Yanzhang via Gcc-patches wrote: > > I found that add the -Wno-psabi to CFLAGS will be overrode by > dg-options. It seems we can only add this option to the third > arg of dg-runtest. Attach the dg-runtest comments, > > # dg-runtest -- simple main loop useful to most testsuites > # > # OPTIONS is a set of options to always pass. > # DEFAULT_EXTRA_OPTIONS is a set of options to pass if the testcase > # doesn't specify any (with dg-option). > > > -----Original Message----- > > From: Kito Cheng > > Sent: Monday, June 12, 2023 8:43 PM > > To: Wang, Yanzhang > > Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; Li, Pan2 > > > > Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking. > > > > Hi Yan-Zhang: > > > > OK with one minor, go ahead IF the regression is clean. > > > > Hi Pan: > > > > Could you help to verify this patch and commit if the regression is cle= an? > > > > thanks :) > > > > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > index 5e69235a268..ad79d0e9a8d 100644 > > > --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > @@ -43,7 +43,7 @@ dg-init > > > # Main loop. > > > set CFLAGS "$DEFAULT_CFLAGS -march=3D$gcc_march -mabi=3D$gcc_mabi -O= 3" > > > > Add -Wno-psabi here rather than below, and also add it for > > g++.target/riscv/rvv/rvv.exp > > > > > dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] = \ > > > - "" $CFLAGS > > > + "-Wno-psabi" $CFLAGS > > > gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[c= S\]]] > > \ > > > "" $CFLAGS > > > dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/*.\[cS\]= ]] \