From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id 4F0F13858D20 for ; Fri, 14 Apr 2023 07:15:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F0F13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92b.google.com with SMTP id t20so24926396uaw.5 for ; Fri, 14 Apr 2023 00:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681456518; x=1684048518; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WC8ByVOwAds5Re9ca7K5bxru22gFgNsXzirDZDeNvNY=; b=fqXMExzUoq6nWAdKr1k4Dr5LLthUHpmSiy/SbeemVHirYxlCCiayYdpQ7BJmIJL1Lb wMNbDE7C8tT7QJHm43rsKzg8yScfVhcqYrrv5OxvWDkMVB6qLq7/iioIFqzXx8Y/QCGl 56esozMCia8zcZxggqH9z7XT1Sme9ffYFD4P25a0Spwro5s8hFBmowRTzBEFHCX6vb8R 7fCoTt7dX1lAvfdd9t37jVibdjaY/Qu3V2SYMYh0EmxQd2Pxb9NTD7C8UGteGmckhqdx CH0cbgAghEybESLCkR+dvz8s0jIM7HBJcEHmg3yMQnoPIX3zETdIaX+/wf5LfV8zZXzM VvdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681456518; x=1684048518; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WC8ByVOwAds5Re9ca7K5bxru22gFgNsXzirDZDeNvNY=; b=Kb10wNKXRLE5FgrEtyXgSyNzm/40ANjV1qh+fNtNW5oBZISji/zIUMkDgs/Ein9Na4 6NO4+T+Oc1wn7r5Ts1lYdz7OAnpru6hv7JTHTjHkfiNmu1Ff1r0CPKiCHY3F0+D8x6Vn mVJyzshijQ5LUWO+J6h87X0PzY8tIxqYWp+o0t6p7mzio17Yk6MKB6rVqE5tIDm5T8Nt l21bkCNj5oVe5EFxwOiEz8I/gYrIcamt25T59QMMMRRjrbYciJAHGfq5WkFhm5qXGOkE LB5ZEKX+MDn309OFtjcEqnnilXyFrE4j1QpN6v5MIGfVE6BkNWjYzqOnsmS09hBT/kd1 VdZw== X-Gm-Message-State: AAQBX9fP63m5k4Cj3o6v6+J4MYnLrXtcKEEwaO2Hk3DpjVzK+JWU/B0z PQ7cMlTQkLt3umo4w6gfAcoePi4RWIe9qVI7C9A= X-Google-Smtp-Source: AKy350aTnRONmz6a5nqCC9qJnoGyw6SPQ0nhjzXsnUWNsrTXskUcRu3kRenfFnYsZREdQxvHKDUxaYHa1lL8KG4iykE= X-Received: by 2002:ab0:5b57:0:b0:771:f808:74e0 with SMTP id v23-20020ab05b57000000b00771f80874e0mr3000297uae.0.1681456518374; Fri, 14 Apr 2023 00:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20230413205208.465-1-palmer@rivosinc.com> In-Reply-To: <20230413205208.465-1-palmer@rivosinc.com> From: Kito Cheng Date: Fri, 14 Apr 2023 15:15:07 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Wait, take second round review: > * All extensions were being prefixed with an underscore, which leads to > some odd combinations like "rv32gc_v", this just adds underscores to > the multi-letter extensions. > * The input base ISAs were being canonicalized, which resulted in some > odd multilib default search paths. I'm not sure if anything breaks > due to this, but it seems safer to just leave them alone. >* All extensions were being prefixed with an underscore, which leads to > some odd combinations like "rv32gc_v", this just adds underscores to > the multi-letter extensions. I think that weirdness can be removed arch-canonicalize I think? And currently all -march will be canonicalized before query multi lib > @@ -163,14 +168,13 @@ for cmodel in cmodels: > if cmodel == "compact" and arch.startswith("rv32"): > continue > > - arch = arch_canonicalize (arch, args.misa_spec) > arches[arch] = 1 > abis[abi] = 1 > extra = list(filter(None, extra.split(','))) > ext_combs = expand_combination(ext) > alts = sum([[x] + [x + y for y in ext_combs] for x in [arch] + extra], []) > alts = filter(lambda x: len(x) != 0, alts) > - alts = list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) > + alts = alts + list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) So we don't really need to append non-canonical one to the list?