From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 92EBB3858D32 for ; Wed, 5 Oct 2022 02:24:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92EBB3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x635.google.com with SMTP id v22so4745717ejw.8 for ; Tue, 04 Oct 2022 19:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gv9TVolGrD65xUDxmnF+54Lk1u90u0AGLvG+CRCX2O0=; b=BEnFSt+sbR7tabpUg2yKRgEjbGAXO2T/ST1FX0ty3sBzogdjuGF5eQP9JPcD6danuB j6pK9yYPwmuWcDNsgiXulqL+yN42HFW3dEqf7ESEvx02QmulMknxdzf2bLnPQTLnbeJh syx6ie7SdWJMfGog8JTTpGKYGyTsxfcXmHq+s3q7JP9iOPyrN1NrbCsOSeCj4yTFJiEg wjoG0I08nW3sWly2NLiaZwTAZFLJ9i++hDOZBL1rgQIU9rSI9U5AdB37el/KXcBpT9M4 L9y8uTtWvII0PBhCc/jq9yaDtOsSrDs3H3IpbzJULgPoldpY1D6BBDk+1F4Y0NB8gqDT 9FyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gv9TVolGrD65xUDxmnF+54Lk1u90u0AGLvG+CRCX2O0=; b=M+9AZdro62DU05Dev2/E/wkX4YH5hfm6iDXpEMx08s7gAgvON1L6j5cjF+xfYju18z AuhNtoo24Fqahzg+SjcMm+TJBLMNsWSN1Tha4iRC6H8dbrOHEq/Zaw4dR10PXP/WmrMj wlikm9+D26CQSocAFIEPbvzdVRRNI7wXnyLDlGpttGZDPJwwTIVvqwDaYNapNQMX5rzh uBl/BAYhl9q5nnZKEzfnfQo1f5D6jBOmjjI2pXdB15YisMAHiYy37qWlysOP4T92zjf+ J6R/CalI1uhBssPR+mdxdj+UisEgox3Ev8JGGUCMetLTZOl4HIur/ObJtUo60JfPmMNo lNcg== X-Gm-Message-State: ACrzQf2Onrfk5g/QNBB52mZ73ooS9S6ZwWA59zhC6cuQ7PeYjoqA7ZGA 1w49/aPwM0kQX24li1uYc9r7LFGe+6U7eAMpOtM= X-Google-Smtp-Source: AMsMyM6vcfbP7S2JvOUOImbRWckUk6au7I6mN9wINYmiorge2KpFCA0eS7mP7VY6A+3+b09Unhj0DwmGi8V4cQsmJmI= X-Received: by 2002:a17:906:ee89:b0:73d:70c5:1a4e with SMTP id wt9-20020a170906ee8900b0073d70c51a4emr21121009ejb.683.1664936656114; Tue, 04 Oct 2022 19:24:16 -0700 (PDT) MIME-Version: 1.0 References: <8735d9a3qr.fsf@igel.home> <20220902210533.373663-1-vineetg@rivosinc.com> <1236ab56-3823-124b-1c91-63b1dbc94aa7@rivosinc.com> In-Reply-To: <1236ab56-3823-124b-1c91-63b1dbc94aa7@rivosinc.com> From: Kito Cheng Date: Wed, 5 Oct 2022 10:24:04 +0800 Message-ID: Subject: Re: [PATCH v3] RISC-V: remove deprecate pic code model macro To: Vineet Gupta Cc: gcc-patches@gcc.gnu.org, Philipp Tomsich , gnu-toolchain@rivosinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed, and added ChangeLog, remember to add that next time :) On Sat, Sep 24, 2022 at 2:08 AM Vineet Gupta wrote: > > On 9/2/22 14:05, Vineet Gupta wrote: > > Came across this deprecated symbol when looking around for > > -mexplicit-relocs handling in code > > > > Signed-off-by: Vineet Gupta > > No rush but looks like this got lost in the bigger thread about > LOAD_ADDRESS_MACRO. > > Thx, > -Vineet > > > --- > > gcc/config/riscv/riscv-c.cc | 5 ----- > > gcc/testsuite/gcc.target/riscv/predef-1.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-2.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-3.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-4.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-5.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-6.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-7.c | 3 --- > > gcc/testsuite/gcc.target/riscv/predef-8.c | 3 --- > > 9 files changed, 29 deletions(-) > > > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > > index eb7ef09297e9..8d55ad598a9c 100644 > > --- a/gcc/config/riscv/riscv-c.cc > > +++ b/gcc/config/riscv/riscv-c.cc > > @@ -93,11 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > > break; > > > > case CM_PIC: > > - /* __riscv_cmodel_pic is deprecated, and will removed in next GCC release. > > - see https://github.com/riscv/riscv-c-api-doc/pull/11 */ > > - builtin_define ("__riscv_cmodel_pic"); > > - /* FALLTHROUGH. */ > > - > > case CM_MEDANY: > > builtin_define ("__riscv_cmodel_medany"); > > break; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-1.c b/gcc/testsuite/gcc.target/riscv/predef-1.c > > index 2e57ce6b3954..9dddc1849635 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-1.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-1.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-2.c b/gcc/testsuite/gcc.target/riscv/predef-2.c > > index c85b3c9fd32a..755fe4ef7d8a 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-2.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-2.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if !defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-3.c b/gcc/testsuite/gcc.target/riscv/predef-3.c > > index 82a89d415809..513645351c09 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-3.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-3.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if !defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medany" > > -#endif > > -#if !defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_pic" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-4.c b/gcc/testsuite/gcc.target/riscv/predef-4.c > > index 5868d39eb67a..76b6feec6b6f 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-4.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-4.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-5.c b/gcc/testsuite/gcc.target/riscv/predef-5.c > > index 4b2bd3835061..54a51508afbd 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-5.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-5.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if !defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-6.c b/gcc/testsuite/gcc.target/riscv/predef-6.c > > index 8e5ea366bd5e..f61709f7bf32 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-6.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-6.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if !defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medany" > > -#endif > > -#if !defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medpic" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-7.c b/gcc/testsuite/gcc.target/riscv/predef-7.c > > index 0bde299aef1a..41217554c4db 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-7.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-7.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-8.c b/gcc/testsuite/gcc.target/riscv/predef-8.c > > index 18aa591a6039..982056a53438 100644 > > --- a/gcc/testsuite/gcc.target/riscv/predef-8.c > > +++ b/gcc/testsuite/gcc.target/riscv/predef-8.c > > @@ -57,9 +57,6 @@ int main () { > > #endif > > #if !defined(__riscv_cmodel_medany) > > #error "__riscv_cmodel_medlow" > > -#endif > > -#if defined(__riscv_cmodel_pic) > > -#error "__riscv_cmodel_medlow" > > #endif > > > > return 0; >