From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id A50A43858D20 for ; Wed, 21 Feb 2024 01:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A50A43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A50A43858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708479377; cv=none; b=D0Zk6ySTkj1wiPcb2LH4kYORKFTlppxp9MbvL3Sjdib0b1bhz+dVwuogwtRIjEehs0OO6rf4X4TddQj2vd1RRkHsAO163ukU1FUJsJI6KGGIUe8ZLSoIZI2f6Jg7mt0cCjHBgO2cWCnzUBxTr62wiJOe4nOmH9+L2hjoIiVM8c4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708479377; c=relaxed/simple; bh=ThScdQf0kdQnBgRg2oKGir3A62hoYs7FEbRhOVpgPF4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=G7pgjuY7zRSLhhjwb0nKIFI5KOZzyKI2BmmvBbkSZ68FVgmGlSM6LlcDerj2IXjceFceYtscVbo5dNBVAckjHcAUK3ODbpa/JUG4/PtePWN6N6eeXkwNL4QMNQ6brguKNbifezMLqGBrWzUq7VkH6V3IRCoLencrUGHItf/KNyQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a3f299f828aso52751866b.1 for ; Tue, 20 Feb 2024 17:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708479374; x=1709084174; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Wp5Xn7mQtTcjGUKsKLZffHgVEFz6ddH8NS8sMv0KvGw=; b=EsnxRcpdr9DlWyK6g3Npv0/J7USejWd3gsPrSIADMG9Ty3MXtLJPb8nm0fRenz973S KEnix0tizo4ULIURTsCmQvOEPrAF7kLA/3RE8RbD0c1spSd2bm/r3nVKU3814qTIyodF sMsGKbLtBPiIMVkDrJqS6ZKJ9Ypc+eF2yYrkliYivPLAlwVuvCH7P/TumCbvBtAE6VIg EybVem437XcKEUFXmsmRGom07lMkBQyNaGQHtolE40f6bVRMzesXqMPuax7B4SKYaFTn NDHieLPcdtNeJcqC4uci/FzdiRU3wb4fUjmZPSaWcg7tOD2N8m0PHNPbinMipUxs5cdD LuRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708479374; x=1709084174; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wp5Xn7mQtTcjGUKsKLZffHgVEFz6ddH8NS8sMv0KvGw=; b=VqKzJEcl7PxqPSly/HiTt6zJ6iR72oKy0zJ/MjR/x2+EDCLWru2eAkxvCtLVrp0NrW 8cSmMSG5euqzN6B/3fWHcpCljPT20slqYcQrtHyUejQDXEE+jXNZVFyjcnfg2RvFVa7x VxAKCMKZ+RCTjq+hiMNONGtYQ92BhkByyNOSL6X81Zgbl58hy1jqPuySjBV+Cc3iKixr bi+QJ3vDdgnBZzu3739njnGsN1Su/NQrfEezG7j4mG9UQK29JGwzclETbKrmxEbF2Hsp eCIcsJuDrNRocJ76YDDRTB1o4iPQ0/rysw0v3XL1nm8JxFjAyjgveDT3GfnKX0ikYgTV p2Dg== X-Gm-Message-State: AOJu0YwL4rggsBTe0IPG9ex6eNtAf34EcJzqQhtYR6540fmq1tm1OS+X 1ClR3Bi/KEXCfgeeOqbWg3jsG8bEmF07XwYYTbx99TJ61vfLsWLfSDMze1uQ+lsuEpPxqcptsnX g4CfdT3LvfdBWejBtJwYk1AFvSl4= X-Google-Smtp-Source: AGHT+IGQxpg+G7u6JSOVO499YbPWr+gnci+3O/zhTDM29t1csydx3W8csPIt/TTAsEAdTb9vqKWq8h7WthF2exh7+P8= X-Received: by 2002:a17:906:2785:b0:a3e:b523:6c8 with SMTP id j5-20020a170906278500b00a3eb52306c8mr3452430ejc.67.1708479374009; Tue, 20 Feb 2024 17:36:14 -0800 (PST) MIME-Version: 1.0 References: <20240220220313.1211441-1-ewlu@rivosinc.com> In-Reply-To: <20240220220313.1211441-1-ewlu@rivosinc.com> From: Kito Cheng Date: Wed, 21 Feb 2024 09:36:02 +0800 Message-ID: Subject: Re: [PATCH V2] RISC-V: Specify mtune and march for PR113742 To: Edwin Lu Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com, rdapp.gcc@gmail.com, monk.chiang@sifive.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks for fixing that issue :) On Wed, Feb 21, 2024 at 6:03=E2=80=AFAM Edwin Lu wrote: > > The testcase pr113742.c is failing for 32 bit targets due to the followin= g cc1 > error: > cc1: error: ABI requries '-march=3Drv64' > > Specify '-march=3Drv64gc' with '-mtune=3Dsifive-p600-series' > > V1: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645609.html > > PR target/113742 > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/pr113742.c: change mcpu to mtune and add march > > Signed-off-by: Edwin Lu > --- > V1: use require-effective-target > V2: switch to specifying march and mtune > --- > gcc/testsuite/gcc.target/riscv/pr113742.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/pr113742.c b/gcc/testsuite/gc= c.target/riscv/pr113742.c > index ab8934c2a8a..573afd6f0ad 100644 > --- a/gcc/testsuite/gcc.target/riscv/pr113742.c > +++ b/gcc/testsuite/gcc.target/riscv/pr113742.c > @@ -1,4 +1,4 @@ > -//* { dg-do compile } */ > -/* { dg-options "-O2 -finstrument-functions -mabi=3Dlp64d -mcpu=3Dsifive= -p670" } */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -finstrument-functions -march=3Drv64gc -mabi=3Dlp64= d -mtune=3Dsifive-p600-series" } */ > > void foo(void) {} > -- > 2.34.1 >