From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id 1988C3858D33 for ; Thu, 20 Apr 2023 03:00:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1988C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x934.google.com with SMTP id v18so1247268uak.8 for ; Wed, 19 Apr 2023 20:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681959609; x=1684551609; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YK9fDJdgS92J4290CSg6mtbl2LG5g0RrlmYcnVwcZwQ=; b=E8esxzJhizNCyORTKbIf325sYNxjP4u/nvsiKi89htMiIVwVavIjjJuq9JMxSQWwJD mixjcvtKUvuSTwfL0hjOaI+y5AnyqeSIDBNSP0dHYtkfliBq/004O1hgiNG2n6UEybNK vcSY60Q1ANiouH620wy7a7zzbUUlTVqD5fMlqAbf+OrWw5oSLsN5tdR56B4MbLUustA2 zctfKTEK+LS1JKOzFCrKacmlPAxgDC7vB3on7IOua/8K6swFFumLmuh1rCDodmQFJhmb 3FFrkGOGImZvp4KI+Axg3iiAB0QnUdoLzviyh2NxQ1d6e0K5tklmEgUgCGH/De55kZjN ACcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681959609; x=1684551609; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YK9fDJdgS92J4290CSg6mtbl2LG5g0RrlmYcnVwcZwQ=; b=HwmBW6CszLzUfRuTwE23+qphlPmJg+ELdA8Dymqcixq5gl5lXOCQ6YsMHYuirnEVVl LhNBBatIAP+dxwy5ygZrrFsRKkxezPhMTEflqb6uhvyCmpVK+odILBo+pZwQZwBoat5S rTzpp/fMeV6W6KahiUEPVOBPDzzsjUtPhvw0MgrXLg7RNyW8WjeZhEXzwh6NvHagIwjS WqTip8xnPJDkQles2tSxNnL/pdpZBE2T/fbCZKRHYkA8yYtSwKE9KbsXanHXB/f76akJ LmkUkvvI6ZbYChHsBL7BPZZD0jI6bZHXbvHT0NyjuVMdp1sRmiEjsDDL10aFJWNQXcrG GHOA== X-Gm-Message-State: AAQBX9fKRYBdCX44BkQbLet+blkxUYNsxyOs2TexaPaFGVhY7jbJ2tm1 AepTWFPJuAHoYDpolqtfgjHRXuMp0JRJES/4xX8= X-Google-Smtp-Source: AKy350bTZgSoOlc9RyLRlnXFnzuMPojDu/vp4+bD71ce6RLkq9rb9y044jasM/C7X3fQpnL9C9WOktQEGabFCeoa2bQ= X-Received: by 2002:a1f:e803:0:b0:43f:f4b0:1a75 with SMTP id f3-20020a1fe803000000b0043ff4b01a75mr144254vkh.9.1681959609193; Wed, 19 Apr 2023 20:00:09 -0700 (PDT) MIME-Version: 1.0 References: <20230419164214.1032017-1-juzhe.zhong@rivai.ai> <20230419164214.1032017-3-juzhe.zhong@rivai.ai> In-Reply-To: From: Kito Cheng Date: Thu, 20 Apr 2023 10:59:57 +0800 Message-ID: Subject: Re: Re: [PATCH 2/3 V2] RISC-V: Enable basic auto-vectorization for RVV To: "juzhe.zhong@rivai.ai" Cc: gcc-patches , palmer , jeffreyalaw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 20, 2023 at 10:56=E2=80=AFAM juzhe.zhong@rivai.ai wrote: > > >> The comment above might not sync with your implementation? > Address comment. > > >> Actually, you've allowed TARGET_MIN_VLEN < 128 && riscv_autovec_lmul <= RVV_M2 > Not sure I am on the same page with you. I return word_mode for this situ= ation, the auto-vectorization > will be disabled. I have testcase to test it and I didn't see issue. Woul= d you mind giving me more informations? Oh, I just said something opposite, I mean you allow TARGET_MIN_VLEN < 128 with LMUL >2 for vectorize, which is inconsistent with "We only enable auto-vectorization when TARGET_MIN_VLEN >=3D 128"