From: Kito Cheng <kito.cheng@gmail.com>
To: Jin Ma <jinma@linux.alibaba.com>
Cc: gcc-patches@gcc.gnu.org, jeffreyalaw@gmail.com,
christoph.muellner@vrull.eu, jinma.contrib@gmail.com
Subject: Re: [PATCH] RISC-V: Add the option "-mdisable-multilib-check" to avoid multilib checks breaking the compilation.
Date: Fri, 26 May 2023 00:10:34 +0800 [thread overview]
Message-ID: <CA+yXCZDVRiqNo2-4dVW5pgHmArq6gZi5zDsg_Fd8MkTPEPZWPg@mail.gmail.com> (raw)
In-Reply-To: <20230523044202.1201-1-jinma@linux.alibaba.com>
> When testing a extension, it is often necessary for a certain program not to
> need some kind of extension, such as the bitmanip extension, to evaluate the
> performance or codesize of the extension. However, the current multilib rules
> will report an error when it is not a superset of the MULTILIB_REQUIRED list,
> which will cause the program to be unable to link normally, thus failing to
> achieve the expected purpose.
>
> Therefore, the compilation option is added to avoid riscv_multi_lib_check()
> interruption of compilation.
I think it's dangerous to remove the check, but I can understand there
are some cases where we really do not want the `security lock`,
so I am OK with introducing a new option to disable that.
but plz add documentation to the option into gcc/doc/invoke.texi
and mention it will just use default multilib and MIGHT not be correct
in some cases.
> --- a/gcc/config/riscv/riscv.opt
> +++ b/gcc/config/riscv/riscv.opt
> @@ -295,3 +295,7 @@ Enum(riscv_autovec_lmul) String(m8) Value(RVV_M8)
> -param=riscv-autovec-lmul=
> Target RejectNegative Joined Enum(riscv_autovec_lmul) Var(riscv_autovec_lmul) Init(RVV_M1)
> -param=riscv-autovec-lmul=<string> Set the RVV LMUL of auto-vectorization in the RISC-V port.
> +
> +mdisable-multilib-check
I would like to rename that to mno-multilib-check since that is more
like all other gcc option conventions.
> +Target Bool Var(riscv_disable_multilib_check) Init(0)
You don't need Var(riscv_disable_multilib_check) and Init(0) since no
one check the value
And you need RejectNegative to prevent gcc accept -mno-disable-multilib-check
> +Disable multilib checking by riscv_multi_lib_check().
`riscv_multi_lib_check()` is meanless for users since it's
implementation detail.
`Disable multilib checking; use the default multilib if a compatible
one is not found.`
next prev parent reply other threads:[~2023-05-25 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 4:42 Jin Ma
2023-05-25 16:10 ` Kito Cheng [this message]
2023-05-26 13:19 ` Maciej W. Rozycki
2023-05-29 2:53 ` Jin Ma
2023-05-29 3:14 ` Kito Cheng
2023-05-29 3:46 ` Jin Ma
2023-05-29 13:02 ` Jeff Law
2023-05-30 14:48 ` Maciej W. Rozycki
2023-05-30 23:39 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZDVRiqNo2-4dVW5pgHmArq6gZi5zDsg_Fd8MkTPEPZWPg@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jinma.contrib@gmail.com \
--cc=jinma@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).