From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 34EB73857418 for ; Wed, 11 May 2022 01:31:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34EB73857418 Received: by mail-ej1-x635.google.com with SMTP id i19so1072308eja.11 for ; Tue, 10 May 2022 18:31:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sW5iL0Hb4hIdHJ0d0bgIxv0chTIARcrHdH19MR8iTjs=; b=1noXTRFUe4u+CnUOCkWlGZn9SAFoJ3Aun4tJeUTPqiW9VjtSc7zbw9bC8QZNNJJYkg H2P+sHoy8L2hwhJEu9TTRZaC3H9a2aEx+zDd0Y1QiLCUEFjDYBQJKdo99JPwtBmSH/tV V/SQUa+INTIYaKslOMTeInOXVLMGNdwpVwe3EfDzyQPDQxGKFdQJ0dJC89Kh2bwEJcxu wYIbxRRfoIPB+ic81MnmzRjYqIVrmSUWca0w6TOAA86/SNcnNYMYuVToVDuIOV6VfEOE ZBOk+qB1zEZ+bKY43HKfmU2OpIq54VZoVZXTPQ17W1iLI6zphUnEFgrV0CFNu+VLc2c0 ib8Q== X-Gm-Message-State: AOAM533Swd4Fu3gL2ce0tsv/zSUyl3kHhd7+1MGvwZ+U9KDhIDBVPe+k JzivItwLh2fqhPeserhp3pNdulRauvMxMrIk5xY= X-Google-Smtp-Source: ABdhPJwgIkON0KquVO33N2pyQ8k9NfedS7/mdo1C/Iz6ycg5LscOrNoAvLPDGE2LzfOazssBEjTffM+zV1e+kkPLerg= X-Received: by 2002:a17:906:3fd1:b0:6ef:606f:e5c5 with SMTP id k17-20020a1709063fd100b006ef606fe5c5mr21700313ejj.441.1652232708590; Tue, 10 May 2022 18:31:48 -0700 (PDT) MIME-Version: 1.0 References: <20220504002714.2423-1-palmer@rivosinc.com> In-Reply-To: <20220504002714.2423-1-palmer@rivosinc.com> From: Kito Cheng Date: Wed, 11 May 2022 09:31:37 +0800 Message-ID: Subject: Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V To: Palmer Dabbelt Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 01:31:51 -0000 LGTM, that's only added a new option for RISC-V and won't affect all other targets, so I assume I can approve that. On Wed, May 4, 2022 at 8:27 AM Palmer Dabbelt wrote: > > Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with > -m32"), RISC-V needs to be told not to put symbols in the > sdata/srodata/sbss sections. > > gcc/testsuite/ChangeLog > > * debug/btf/btf-datasec-1.c: Don't use small data on RISC-V. > --- > gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c > index dbb236bbda1..77df88648c5 100644 > --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c > +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c > @@ -12,6 +12,7 @@ > /* { dg-do compile ) */ > /* { dg-options "-O0 -gbtf -dA" } */ > /* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */ > +/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */ > /* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */ > > /* Check for two DATASEC entries with vlen 3, and one with vlen 1. */ > -- > 2.34.1 >