From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by sourceware.org (Postfix) with ESMTPS id 13CB03858D32 for ; Mon, 8 May 2023 02:42:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13CB03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2d.google.com with SMTP id ada2fe7eead31-42dfffbbf32so1189047137.1 for ; Sun, 07 May 2023 19:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683513720; x=1686105720; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Pc0PuRZMgM705wWNsASYK1crddlvPo4Od+48WA7WiPU=; b=auC9N3q3xhr3yMX1OiaHOslWk/EQ/8d9spIzIRaSXP4qbon5Qkdeh4YMDywXWDK2bN bMYRSSEemDOr24gz8tPGwlcn/rQTcG7oJGaXA4lr6Ew+FxKry61emNDCPnYF5BxJj9ix Si1A//PVrjk9HXKGYcWKKwbm9zXIIbX1iWd4kxXtP64Mx3GUGLs0kyflZYn9luZwiIcm m1YL4wsKuP4rFj/I2PDuIdqzPeiUOIoWyfO5frqsvzlMVYXKbfKxShw+h3yJ4ujcFgll +P2btjxVcLBQNDB5tQaHaOcg/zxC03QMmdV+VTqfM3r3mGkYxMehe8128xLIfwlH69rh WB8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683513720; x=1686105720; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pc0PuRZMgM705wWNsASYK1crddlvPo4Od+48WA7WiPU=; b=BBEERDCI9knNZp7kDMog0yEawBN3vm3fxdxkiG1KSPEyrGtbjLjeHfySOcW62gFtX6 +Z5jHoxswOvtuDTe8W2MGW+klOycCIFmjEmY3nna+NG7rGJJhF4C1/O4t5LM9C4M+wVY TA6sTLTUHjwnATRAGA6yBMEvXpCyy9+Yw5OqrkQMGtJVXXYLOvDot4FnV2EZ6vwhubBL s9c4mKZ9gGp75oMwb11vEg+DLiDP5E16wv4cEUdfc/MQKNsBpBMqpCydZ6xCO3uU1j2x b3Oa8t24+/Uj2mRaNu3Bhh0cpmlzsAYbjYZbBLzCif4mLAbBRlD3N4A6ZJ23bUxk7/7H s59w== X-Gm-Message-State: AC+VfDw/5AhFKK9zLVii8RiKZcRhj9alBoMJ07TKbifVWpZ2711EjCik N4yT7SMtakLuWXFOGxJkZvm8+a1Kgq2iSQBMYdg= X-Google-Smtp-Source: ACHHUZ5v8wYHruTdlOYIhZgHVMlnh7VQnRuW6e3WYFLA2JY8TnvqWQlTNT/lm/HEJ0dTlg+hjBtjRtBDYogQjfpyXLI= X-Received: by 2002:a05:6102:9cd:b0:434:7410:42eb with SMTP id g13-20020a05610209cd00b00434741042ebmr2509669vsi.14.1683513720182; Sun, 07 May 2023 19:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20230506083939.22097-1-gaofei@eswincomputing.com> <20230506083939.22097-2-gaofei@eswincomputing.com> In-Reply-To: <20230506083939.22097-2-gaofei@eswincomputing.com> From: Kito Cheng Date: Mon, 8 May 2023 10:41:49 +0800 Message-ID: Subject: Re: [PATCH 1/2] [RISC-V] disable shrink-wrap-separate if zcmp enabled. To: Fei Gao Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, jeffreyalaw@gmail.com, sinan.lin@linux.alibaba.com, jiawei@iscas.ac.cn, liaozhangjin@eswincomputing.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: shrink-wraping already gated by Os so I think we don't need add more gate here, unless we are trying to claim force optimize for size if zcmp is present. On Sat, May 6, 2023 at 4:41=E2=80=AFPM Fei Gao = wrote: > > zcmp aims to reduce code size, while shrink-wrap-separate prefers > speed to code size. So disable shrink-wrap-separate if zcmp > enabled, just like what save-restore has done. > > author: Zhangjin Liao liaozhangjin@eswincomputing.com > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_get_separate_components): > --- > gcc/config/riscv/riscv.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index 45a63cab9c9..629e5e45cac 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -5729,7 +5729,8 @@ riscv_get_separate_components (void) > > if (riscv_use_save_libcall (&cfun->machine->frame) > || cfun->machine->interrupt_handler_p > - || !cfun->machine->frame.gp_sp_offset.is_constant ()) > + || !cfun->machine->frame.gp_sp_offset.is_constant () > + || TARGET_ZCMP) > return components; > > offset =3D cfun->machine->frame.gp_sp_offset.to_constant (); > -- > 2.17.1 >