From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com
 [IPv6:2a00:1450:4864:20::535])
 by sourceware.org (Postfix) with ESMTPS id A0D5F3857B98
 for <gcc-patches@gcc.gnu.org>; Thu, 11 Aug 2022 02:38:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0D5F3857B98
Received: by mail-ed1-x535.google.com with SMTP id a89so21345269edf.5
 for <gcc-patches@gcc.gnu.org>; Wed, 10 Aug 2022 19:38:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=LnadvH9I5Q/afIfg86M6UJFyLdlCg70jOPP33pq16V4=;
 b=zNvNtINVYwWDPMH1UHdKV0tIh6nywUjZWHtT4DecN4+AIBcO5rNLBckeoVySiJewVd
 9j+TsJOTLnFBLEaUQ7zkppphtDMV3i8m2y2w/KgcpBNDNq2TA3QVZEm+Y3cJLjtOxVGh
 UWj4f02bC+Z0J7HC+RLo+uyj8CsAi+T8VYPd0GvVGi0KzqLLMN2g3au/QUl8/jXxQTiE
 g6yU8MJejEYIFsoZIWBULmlPzcK5sZ2AtjkUc/S92glCqp4B3XDl0mSVkMYhD0kWbKrv
 LXXnSRy7r7Y0FANBunfyedFtRyh1z88L7iBcMrQHXpC43+D0jn5P3jHkVerdG6k1nj/+
 gLIA==
X-Gm-Message-State: ACgBeo1vYoBSvbMKDklWzTwOxinaO8CAzVU8c0tOAQrW0reXl70Lc85D
 KIpfc9veO7dgieJbF9n0iqu9g6tNX6c5khMNWrE=
X-Google-Smtp-Source: AA6agR5HIlmy8q5SrW5dYcYKPyiUnSDjNaHAGHGBW5h87I/d0Y48tr9HHjEPF7Y0jp1etZPPykV6H7W+Hd5QZYKDni4=
X-Received: by 2002:a05:6402:28c3:b0:43a:6d78:1b64 with SMTP id
 ef3-20020a05640228c300b0043a6d781b64mr29248683edb.93.1660185532068; Wed, 10
 Aug 2022 19:38:52 -0700 (PDT)
MIME-Version: 1.0
References: <alpine.DEB.2.20.2207282043000.10833@tpp.orcam.me.uk>
In-Reply-To: <alpine.DEB.2.20.2207282043000.10833@tpp.orcam.me.uk>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Thu, 11 Aug 2022 10:38:40 +0800
Message-ID: <CA+yXCZDWto6u7uatPOyugs4VtWwwN54p8RXO_FzRBZfTrPeWdg@mail.gmail.com>
Subject: Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests
 to hard float
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Andrew Waterman <andrew@sifive.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_ASCII_DIVIDERS,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Aug 2022 02:38:55 -0000

LGTM, thanks :)

On Fri, Jul 29, 2022 at 3:52 AM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of
> tests to hard_float") and also restrict the remaining `fmin'/`fmax'
> tests to hard-float test configurations.
>
>         gcc/testsuite/
>         * gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target
>         hard_float'.
>         * gcc.target/riscv/fmaxf-snan.c: Likewise.
>         * gcc.target/riscv/fmin-snan.c: Likewise.
>         * gcc.target/riscv/fminf-snan.c: Likewise.
> ---
>  gcc/testsuite/gcc.target/riscv/fmax-snan.c  |    1 +
>  gcc/testsuite/gcc.target/riscv/fmaxf-snan.c |    1 +
>  gcc/testsuite/gcc.target/riscv/fmin-snan.c  |    1 +
>  gcc/testsuite/gcc.target/riscv/fminf-snan.c |    1 +
>  4 files changed, 4 insertions(+)
>
> gcc-riscv-fmin-fmax-test-hard-float.diff
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
>  double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
>  float
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
>  double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
>  float