From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id DEE2D3861802 for ; Tue, 23 Feb 2021 02:38:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DEE2D3861802 Received: by mail-wr1-x429.google.com with SMTP id h98so16240964wrh.11 for ; Mon, 22 Feb 2021 18:38:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SsxsaSGOEWch0dx3kwZN2qQvaCTlDyaJtc1bYtVSPLE=; b=XWuR/6zt5vk9PxT/xGaIhrumLwanHUUuU3agfYNPs7R8zhBavESeWSgfsbFsc4h+EG NfBF7AgA00URgc3jkSJ6i7Gxbpx9T45Tj7QbiPcBnB7hkyretIzowJCfMCenFexWlyc1 7IMcxk8f+2hB4z9wQBjnnqapGYLuzfJAR0g6vcS2KL+84FznpDng3pOS2JZKfhn7u2Sl KB9k0aoEtHZxXuCilwW7oqr0mtnEXrA6Gx5yWqTWG5YAjFhyZvCKvvNtjKTHVwZjrpSY aiGeyomk+FsJDH9OEhGlrVWCmO0C1NGCyvwqzX9o1jY77fzEwfa3Sgvi9z32BIn7xyzB lPPw== X-Gm-Message-State: AOAM531lM4FcZm7tUu2Y+xYji9U7gFjiflKQVEM02L9pu6wfK2IvPiN+ z7zhRYxMjGIYo4Fu/+D1IfjpkcxEH7c7oTk0FOw= X-Google-Smtp-Source: ABdhPJxW+Pbn+MXwjSbfF/fPftHvfxlVn2Q9wi64QISJ552wxMEcA4zupT7JIKcputNdXBX75e++AnowcVwaVUqLdoM= X-Received: by 2002:adf:9564:: with SMTP id 91mr23077729wrs.207.1614047917855; Mon, 22 Feb 2021 18:38:37 -0800 (PST) MIME-Version: 1.0 References: <20210221000903.32039-1-marcus@mc.pp.se> In-Reply-To: <20210221000903.32039-1-marcus@mc.pp.se> From: Kito Cheng Date: Tue, 23 Feb 2021 10:38:26 +0800 Message-ID: Subject: Re: [PATCH v2 0/5] RISC-V big endian support To: Marcus Comstedt Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 02:38:41 -0000 Hi Marcus: Thanks for the quick update, I am testing your V2 patch now, the result seems really great now, some of fail case seems like not cause by big-endian patch, I am reviewing and comparing the fail case with the little-endian build. > Should I make a PR against riscv-newlib on GitHub, or would you prefer > some other process for dealing with newlib fixes related to these > patches? Could you send to newlib mailing list directly, ideally riscv-newlib just a buffer we don't want to hold any patch there as possible. https://sourceware.org/mailman/listinfo/newlib/ On Sun, Feb 21, 2021 at 8:17 AM Marcus Comstedt wrote: > > This is an update to the patch series for big endian RISC-V support. > > Changes since last version: > > * Added documentation of -mbig-endian and -mlittle-endian > > * New patch: Fix soft-fp endianness setting > > * New patch: Fix trampoline generation on big endian > > * New patch: Update the shift-shift-5.c testcase to work correctly > on big endian > > With these changes, and two fixes to newlib (setting correct floating > point byteorder, and an update to the handcoded assembler for strcmp), > I'm now down to > > ========= Summary of gcc testsuite ========= > | # of unexpected case / # of unique unexpected case > | gcc | g++ | gfortran | > rv64gc/ lp64/ medlow | 14 / 8 | 39 / 10 | - | > > and of these only two failures do not also occur for little endian: > > FAIL: gcc.target/riscv/shift-and-1.c scan-assembler-not andi > FAIL: gcc.target/riscv/shift-and-2.c scan-assembler-not andi > > I'm quite puzzled why these two testcases give different results with > -mbig-endian compared to with -mlittle-endian though, since they only > deal with register-to-register operations so the memory model should be > completely irrelevant... > > > // Marcus > > >