From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id A9C6F3858D1E for ; Wed, 19 Apr 2023 01:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9C6F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb32.google.com with SMTP id n203so18947597ybg.6 for ; Tue, 18 Apr 2023 18:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681867590; x=1684459590; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=60KniWVE8ZJpHVeF1h0SbcDgS0vZ9Yu3Gx3Wo4DMC4E=; b=G10TR1fsGWOo45+5wra7Nx8zp6S06hwgFZL/1A2iBpcIyPQi87g/H0c9o+LmTJxBW5 WX5JxdtOdwGcp2e77njEjFcF5ynehKriBHpzFq9q/R0cwyNg0ZK0kWftDhDniaQoZrHu 0OrLHFwLkPcJRMFpKg2QIFJIRQFnteaaoN/t0nzJ6k7rlkoRg1G8e2LGJTbCJuSOvSFA 7QpFzMEozBU6uP3YoXMifP4eqoAmSSQTZVjoPVzCi7fJULUDlau5wMhObPd1gZWFdq6p /+ZZi28BYkeR8VFcU5IOBjCH3jaQaiFSiIc6VcP4K8WAqS1vmPCgrpEkT1zRYaMDjZG0 8iOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681867590; x=1684459590; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=60KniWVE8ZJpHVeF1h0SbcDgS0vZ9Yu3Gx3Wo4DMC4E=; b=XOuqdKf17u4ECidEE1ZbQxJc20wzcdDNsf835AdFd53LwLOeYkKLmuAWRxpIVuGYq3 9e64Oo0VIEUNzRgXXyg8opHXzLt7KxdsBSL1PVTPu/qjjfNqVWObylViA2UqZLZANuqK r7tlylaoQKCMJ5ORIZbTxTq/+OQ43j8Z4FooOHHlT0cB833mAy52+COeNCqK9zQnEpGi BaZau8cyw+2lz66RTJYbhbBNT6v1NL+EXY0v2NVKKuA9MF4GU/VrSoB7/NwfAiWf5Qig 1r8ZlLr2+n5HDa+Ftg1ETazbmJE26x2uV3cSZbKP/6hDnLnwF/5Unlr2jX15kQ3IHMQh E4sw== X-Gm-Message-State: AAQBX9dxQfFRoH8Tqxpph5p5RpQaC9tBPu59fmyoCn1rnPGPisTHjWQn XI+8tz/MDGLAtjkZoq/AmhZF85rCGXpYk2IoMe4= X-Google-Smtp-Source: AKy350alWk7vK9/FejgOGtKM44FzcusYfvUvNwhOGOYLIUFW3uSU9PIHCBvPrj6dhjf/lgjWRemPZyHxD0jopMjwFfI= X-Received: by 2002:a25:230d:0:b0:b3d:5a52:5c6b with SMTP id j13-20020a25230d000000b00b3d5a525c6bmr874996ybj.21.1681867589656; Tue, 18 Apr 2023 18:26:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Wed, 19 Apr 2023 09:26:18 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: And which -march -mabi you used will got issue? On Wed, Apr 19, 2023 at 8:51=E2=80=AFAM Palmer Dabbelt wrote: > > On Tue, 18 Apr 2023 17:47:31 PDT (-0700), Kito Cheng wrote: > > Do you mind shared gcc configure and the option you tried? > > Just riscv-gnu-toolchain with "--enbale-multilib --enable-linux". > > > On Wed, Apr 19, 2023 at 4:01=E2=80=AFAM Palmer Dabbelt wrote: > >> > >> On Tue, 18 Apr 2023 08:44:24 PDT (-0700), gcc-patches@gcc.gnu.org wrot= e: > >> >> Yep, if I drop the non-canonicial strings via > >> >> > >> >> diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/r= iscv/multilib-generator > >> >> index 58b7198b243..a63a4d69c18 100755 > >> >> --- a/gcc/config/riscv/multilib-generator > >> >> +++ b/gcc/config/riscv/multilib-generator > >> >> @@ -174,7 +174,7 @@ for cmodel in cmodels: > >> >> ext_combs =3D expand_combination(ext) > >> >> alts =3D sum([[x] + [x + y for y in ext_combs] for x in [a= rch] + extra], []) > >> >> alts =3D filter(lambda x: len(x) !=3D 0, alts) > >> >> - alts =3D alts + list(map(lambda a : arch_canonicalize(a, a= rgs.misa_spec), alts)) > >> >> + alts =3D list(map(lambda a : arch_canonicalize(a, args.mis= a_spec), alts)) > >> >> > >> >> # Drop duplicated entry. > >> >> alts =3D unique(alts) > >> >> > >> >> then I can't link `-march=3Drv32imafdcv`, I need > >> >> `-march=3Drv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zvl64= b`. That's > >> >> kind of a headache for users to type in. > >> > > >> > Yes, that's a headache for users, but arch string canonicalization i= s > >> > hiddened at the process, > >> > so the user could still just use rv32imafdcv at compile time and > >> > multi-lib config. > >> > > >> > And the driver and multilib-generator (with arch_canonicalize) scrip= t > >> > will handle those headache in the background. > >> > >> Sorry, I'm not exactly sure what you're trying to say. I just rebuilt > >> GCC with this patch (and t-linux-multilib regenerated from it), it's n= ot > >> resolving multlibs for the short names.