From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 4ECDA3864821 for ; Sun, 19 Nov 2023 05:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ECDA3864821 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4ECDA3864821 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700373261; cv=none; b=GGikDlT8h/tJlfcl6my8+BertRHo4MK5AgBcOiAGzuv5sPxEHanr/AiM5alsqj41+RY8WJx83XAqxM6ZTIbzlQa/qQKWPOqnI9cXkSB2GD0qzH6NVPE9n5NLZsczKBn9SA2JHUwSLX44UXzlNlmustkYK7LXvMXK8CIcuQiZbAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700373261; c=relaxed/simple; bh=wyudHlOdRfSIFeBXsUi+AE4N0hdDeokC1LCLt20qkEU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KaLb5kQpV04LIq2TRaDsBa2lbybPifB3KM62RkgLdNHu/qzvime5OR/pQfqVuahVx//FK6pueHxwh4MHam7348p9Z6aKWGckEnEv/KyxivflLYJzYTFQXKAur72W3FnHq718N6s7c0nZWoRXxatS/3w+IOQ/JWJEe9bJKKjVtak= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53f9af41444so4717870a12.1 for ; Sat, 18 Nov 2023 21:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700373259; x=1700978059; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z507oExu8RHRsjC/J+w9q8z4szhJb9QG+yh836H+tek=; b=lutEeOTLzPkILo1LcizCsl/Qz9JBl9na7+hP7CWeEtnUuurpToGv3O1DOpls/63F9k +IuC1WNQ+xaSWEB01G4Bb/f+tsDKzILUxMMBX3ji+KR2k3WNTwInlGJLMhQsW+SHF80/ VYitvdFFCAYQh0ZE1D6Z5sl/EGM7b1EPcL1yDiza249ifiEgmrbrnQI9QMcV0MTF6Msg a78t00XKWd63Yqww7TZ9knEPJkYwppBFUdWsDmWsEshXOkxj+L/KxEqmK/ExHoyBXD/w whYSkRM4bT3yETXAFGFwanGoPtwpv+24CfrCbyiRIvL9NSwF43o9WCAwq6cWMyrNNf42 Jrrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700373259; x=1700978059; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z507oExu8RHRsjC/J+w9q8z4szhJb9QG+yh836H+tek=; b=Gr1cJ3gQ81wiOeAIP1F9s7aiM8qFL39NR5COkWB6g1C8cKqFZrMr+NrY1jVZOD0uIl A/vMAsco5QQkmz137k1VJbyIQ+PD/XaOFRR7fI9FaTQfVF/s7tDn7IcEoKBmIzBR5DT9 0nXfnrpEiu7oKPrsZvzLfox5DfY96zmM7MzWSFRMPi6hk015WQBO8FcvOAjvqtwjAZBe t0xG4UVgWiEXG8gBcAJEor7DIpRBrb2vOXrZPR9IEtW/2lhtp6TEOgypNMUWzFf47dQ5 0gTi4Noj1YQXN2WVv1+ZN1fa7KWXlII6qLkaSRmljS/P3Db+paRoCMeq/LqpkBWoUhvH cZug== X-Gm-Message-State: AOJu0YxiCuxcYRLl1lIP3eLRzbNVp0JWE+ov3p040HpTXzWmHwreYSMZ Q2QEnw6l8PHSeHIIvMK22P6Vh5KFs4nmy5JZTB8= X-Google-Smtp-Source: AGHT+IEJnry/gY5C5V8bwT3N2iSlKI5aatHIG37bVI5BHUcBdNvhY2uyHgcNP8RMaX3wIO/c4oWHbwMvH1UapMLh1gA= X-Received: by 2002:a17:906:6a1f:b0:9be:cdca:dae9 with SMTP id qw31-20020a1709066a1f00b009becdcadae9mr3564733ejc.36.1700373259028; Sat, 18 Nov 2023 21:54:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Sun, 19 Nov 2023 13:54:07 +0800 Message-ID: Subject: Re: [PATCH 05/44] RISC-V: Fix `mode' usage in `riscv_expand_conditional_move' To: "Maciej W. Rozycki" Cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM On Sun, Nov 19, 2023 at 1:36=E2=80=AFPM Maciej W. Rozycki wrote: > > In `riscv_expand_conditional_move' `mode' is initialized right away from > `GET_MODE (dest)', so remove needless references that refrain from using > the local variable. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Use > `mode' for `GET_MODE (dest)' throughout. > --- > gcc/config/riscv/riscv.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > gcc-riscv-expand-conditional-move-mode-dest.diff > Index: gcc/gcc/config/riscv/riscv.cc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- gcc.orig/gcc/config/riscv/riscv.cc > +++ gcc/gcc/config/riscv/riscv.cc > @@ -3999,8 +3999,8 @@ riscv_expand_conditional_move (rtx dest, > arm of the conditional move. That allows us to support more > cases for extensions which are more general than SFB. But > does mean we need to force CONS into a register at this point. = */ > - cons =3D force_reg (GET_MODE (dest), cons); > - emit_insn (gen_rtx_SET (dest, gen_rtx_IF_THEN_ELSE (GET_MODE (dest= ), > + cons =3D force_reg (mode, cons); > + emit_insn (gen_rtx_SET (dest, gen_rtx_IF_THEN_ELSE (mode, > cond, cons, alt= ))); > return true; > }