From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 7D7993858D32 for ; Mon, 22 Aug 2022 09:14:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D7993858D32 Received: by mail-ed1-x536.google.com with SMTP id t5so12990024edc.11 for ; Mon, 22 Aug 2022 02:14:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=16GI08pQEGJIXVgtUf26dH5TSzbqN5bUgHVCDJGm8lY=; b=7CSL6IKj8Pq/VsJqiweLwkIX8WrVIy+qLe6McDS8H3pil+DJVyt7Zq8cXYmdQA3wYV hAIShr+WQ6wwHsYsldd+ZSdSRZKuVjl2Aa7U94Njj8fv410v68xx9Iorvuhu0LaTWKYk rGAaBGBHQ9u86nddOrNIjsGdOOLVsU1iI0GRyrWYP2MhFiCzrcVqKfnDQM2qd9qTk1AS XNtNx0BRmZDdCnpUzilu9cCzHvcVwRg8BMmvv5bHmEL8upjdSqc1KiPWFqeKWwBu0s4W 1SQCX1FeBO7u+npnad0oXBPqG+lGc+7X5qoSn4UCLp0By6y9ClZxPu5QKHiZ/ZMUtAIW SpFg== X-Gm-Message-State: ACgBeo1xFL0Q1iF0SinuNl5lsvfTwPW3MS6ZNrwb1ltSAJz10BkZOEol Zoa2fU+ppBu4S9Ob1JL1s6GvUBAtbnXrgzic26M= X-Google-Smtp-Source: AA6agR5VDjn5waFP5ntj+VRQ9nsbNo/ElGeYZIWrTVmBWAU9Lsq/fZXCXhlcs7YD14M9uK/7stXdh9kZiub1rfdF5xk= X-Received: by 2002:a05:6402:28c3:b0:43a:6d78:1b64 with SMTP id ef3-20020a05640228c300b0043a6d781b64mr15800436edb.93.1661159672801; Mon, 22 Aug 2022 02:14:32 -0700 (PDT) MIME-Version: 1.0 References: <1661015666-14659-1-git-send-email-apinski@marvell.com> In-Reply-To: <1661015666-14659-1-git-send-email-apinski@marvell.com> From: Kito Cheng Date: Mon, 22 Aug 2022 17:14:20 +0800 Message-ID: Subject: Re: [PATCH 0/3] [RISCV] Improve bswap for ZBB To: apinski@marvell.com Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 09:14:36 -0000 Hi Andrew: LGTM, Just checked what's clang gen, and saw LLVM already did the same optimization, thanks for improving the code gen! On Sun, Aug 21, 2022 at 1:15 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > Just some improvements for bswap and ZBB including a testsuite change that will > allow more testing to happen. > > Thanks, > Andrew Pinski > > > Andrew Pinski (3): > Fix PR 106600: __builtin_bswap32 is not hooked up for ZBB for 32bit > Fix PR 106601: __builtin_bswap16 code gen could be improved with ZBB > enabled > Fix PR 106690: enable effective_target_bswap for RISCV targets with > ZBB enabled by default > > gcc/config/riscv/bitmanip.md | 26 ++++++++++++++++++- > .../gcc.target/riscv/zbb_32_bswap-1.c | 11 ++++++++ > .../gcc.target/riscv/zbb_32_bswap-2.c | 12 +++++++++ > gcc/testsuite/gcc.target/riscv/zbb_bswap-1.c | 11 ++++++++ > gcc/testsuite/gcc.target/riscv/zbb_bswap-2.c | 12 +++++++++ > gcc/testsuite/lib/target-supports.exp | 7 +++++ > 6 files changed, 78 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/riscv/zbb_32_bswap-1.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbb_32_bswap-2.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbb_bswap-1.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbb_bswap-2.c > > -- > 2.17.1 >