From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id B02803858409 for ; Wed, 16 Aug 2023 08:33:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B02803858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92e.google.com with SMTP id a1e0cc1a2514c-79ae250266cso2230263241.2 for ; Wed, 16 Aug 2023 01:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692174806; x=1692779606; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r1lEDNmKFmQCtfzXhUF1vlNG8mDU0XYou0V828cSMkI=; b=KcRpideojSPyO19UwY41KDW/bzJGs11g+MJXU92Str7WAF44lAZJRFABlUbcBNMWY0 +F3y92bQ7d4kXaJMxpzjG82lb9dyET6GbuW5hsGvoLq/wfUL7c2ishtVhrAkqU+/6I7W XiRVNpF53gWkPlHr+N9HeEzK6LJ4fRTmvabxujV4psiyDttooq4Kw4UVd/hq2+Pf51x2 PaWEeUm8yMjKDs3hSDd/x97GYGnSE3KLMXANegzSn198DSwWjeKNIIeQiSXZ9aA1/yqN ignIigMqGHbpLW+Hh6C8aAzGM3jDIm1OEd/rLRDX2IeOMt+FM8kg5AaXnZt6nVcwvbge 2iZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692174806; x=1692779606; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r1lEDNmKFmQCtfzXhUF1vlNG8mDU0XYou0V828cSMkI=; b=Qihusq7do/2V2m7tSbp4DeYpcmyuLmHFo5JAGyM95LTqF/Ez6v4klwN6A81Xzfa90i +Ca+xtJa4IixJgI/IgnwNMDuFddMj5EwhxtsMuttG631Q/bQCGgEVZ2XOfbrLcJKI04a YSbtujIH+dGM68fiEgrgzB99bM5obHVHy1XoH01jrxESEEvgbMNQ59pXHXqJA530q1fT QrHrUgXBefQMP2nfAnZ6/dsfUDQG7Z3lMMjuVTuZIhI2KBmz/UstjEf9HQj2bnNz5uk3 avJh+XweiE1/C0lufwgNMPQ5J0njQT3d6d4daeBxv+J/eUCIE5/Z8qCxQl5dRejC2rfO Jjog== X-Gm-Message-State: AOJu0YxvlekkXKbXeWi8vUhpc/dfZ6NDC/vSl3Q7oftrVaONRNYif4Gt ZHDdR9BMNPOYHLYtJyororxHHa01kM8RDykPy2A= X-Google-Smtp-Source: AGHT+IHDVv3uuipQSpK+dvykpCnUbK+Q0aWgm4O1jVmCPQ335SYuenv3HUW1qgL0KcjbmBroORKFJgxyt/NKLP3QGds= X-Received: by 2002:a05:6102:11e2:b0:443:6cb3:ea61 with SMTP id e2-20020a05610211e200b004436cb3ea61mr1014467vsg.18.1692174806020; Wed, 16 Aug 2023 01:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20230607055215.29332-1-gaofei@eswincomputing.com> <20230607055215.29332-2-gaofei@eswincomputing.com> In-Reply-To: <20230607055215.29332-2-gaofei@eswincomputing.com> From: Kito Cheng Date: Wed, 16 Aug 2023 16:33:14 +0800 Message-ID: Subject: Re: [PATCH 1/4][V4][RISC-V] support cm.push cm.pop cm.popret in zcmp To: Fei Gao Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, jeffreyalaw@gmail.com, sinan.lin@linux.alibaba.com, jiawei@iscas.ac.cn Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Fei: Tried to use Jiawei's patch to test this patch and found some issue: > @@ -5430,13 +5632,15 @@ riscv_expand_prologue (void) > /* Save the registers. */ > if ((frame->mask | frame->fmask) != 0) > { > - HOST_WIDE_INT step1 = riscv_first_stack_step (frame, remaining_size); > - > - insn = gen_add3_insn (stack_pointer_rtx, > - stack_pointer_rtx, > - GEN_INT (-step1)); > - RTX_FRAME_RELATED_P (emit_insn (insn)) = 1; > - remaining_size -= step1; > + if (known_gt (remaining_size, frame->frame_pointer_offset)) > + { > + HOST_WIDE_INT step1 = riscv_first_stack_step (frame, remaining_size); > + remaining_size -= step1; > + insn = gen_add3_insn (stack_pointer_rtx, > + stack_pointer_rtx, > + GEN_INT (-step1)); > + RTX_FRAME_RELATED_P (emit_insn (insn)) = 1; > + } > riscv_for_each_saved_reg (remaining_size, riscv_save_reg, false, false); > } > I hit some issue here during building libgcc, I use riscv-gnu-toolchain with --with-arch=rv64gzca_zcmp And the error message is: In file included from ../../../../../riscv-gnu-toolchain-trunk/gcc/libgcc/unwind-dw2.c:1471: ../../../../../riscv-gnu-toolchain-trunk/gcc/libgcc/unwind.inc: In function '_Unwind_Backtrace': ../../../../../riscv-gnu-toolchain-trunk/gcc/libgcc/unwind.inc:330:1: internal compiler error: in gen_reg_rtx, at emit-rtl.cc:1176 330 | } | ^ 0x83753a gen_reg_rtx(machine_mode) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/emit-rtl.cc:1176 0xf5566f maybe_legitimize_operand ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:8047 0xf5566f maybe_legitimize_operands(insn_code, unsigned int, unsigned int, expand_operand*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:8191 0xf511d9 maybe_gen_insn(insn_code, unsigned int, expand_operand*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:8210 0xf58539 expand_binop_directly ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:1452 0xf56666 expand_binop(machine_mode, optab_tag, rtx_def*, rtx_def*, rtx_def*, int, optab_methods) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:1539 0xcbfdd0 force_operand(rtx_def*, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/expr.cc:8231 0xc8fca1 force_reg(machine_mode, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/explow.cc:687 0x144b8cd riscv_force_temporary ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:1531 0x144b8cd riscv_force_address ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:1528 0x144b8cd riscv_legitimize_move(machine_mode, rtx_def*, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:2387 0x1af063e gen_movdf(rtx_def*, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.md:2107 0xcba503 rtx_insn* insn_gen_fn::operator()(rtx_def*, rtx_def*) const ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/recog.h:411 0xcba503 emit_move_insn_1(rtx_def*, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/expr.cc:4164 0x143d6c4 riscv_emit_move(rtx_def*, rtx_def*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:1486 0x143d6c4 riscv_save_reg ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:5715 0x143e2b9 riscv_for_each_saved_reg ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:5904 0x14480d0 riscv_expand_prologue() ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.cc:6156 0x1af57fb gen_prologue() ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.md:2816 0x143c746 target_gen_prologue ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/config/riscv/riscv.md:3302 Reduced case: $ riscv64-unknown-elf-gcc -march=rv64imafd_zicsr_zifencei_zca_zcmp -mabi=lp64d unwind-dw2.i -Os typedef struct { struct { struct { struct { long a } } a[129] } } b; struct c { void *a[129] } d() { struct c a; __builtin_unwind_init(); b e; f(a, &e); }