public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Fei Gao <gaofei@eswincomputing.com>
Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, jeffreyalaw@gmail.com
Subject: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715]
Date: Wed, 5 Jun 2024 14:36:36 +0800	[thread overview]
Message-ID: <CA+yXCZDzew+ZRi0CjH_OREY1EF8hevgQghq7Mx6NLYVCge6LsA@mail.gmail.com> (raw)
In-Reply-To: <20240605015024.7845-1-gaofei@eswincomputing.com>

Thanks for fixing this issue, and I am wondering doest it possible to
fix that without introduce target hook? I ask that because...GCC 14
also has this bug, but I am not sure it's OK to introduce new target
hook for release branch? or would you suggest we just revert patch to
fix that on GCC 14?

On Wed, Jun 5, 2024 at 9:50 AM Fei Gao <gaofei@eswincomputing.com> wrote:
>
> The 1st patch adds a hook to allow post processing after epilogue inserted.
> The 2nd one implement the RISC-V hook to solve PR113715.
>
> Fei Gao (2):
>   target hooks: allow post processing after epilogue inserted.
>   [RISC-V]: fix zcmp popretz [PR113715].
>
>  gcc/config/riscv/riscv.cc                   | 191 ++++++++++++++------
>  gcc/doc/tm.texi                             |   5 +
>  gcc/doc/tm.texi.in                          |   2 +
>  gcc/function.cc                             |   2 +
>  gcc/hooks.cc                                |   7 +
>  gcc/hooks.h                                 |   1 +
>  gcc/target.def                              |   8 +
>  gcc/testsuite/gcc.target/riscv/rv32i_zcmp.c |  56 ++++++
>  8 files changed, 219 insertions(+), 53 deletions(-)
>
> --
> 2.17.1
>

  parent reply	other threads:[~2024-06-05  6:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  1:50 Fei Gao
2024-06-05  1:50 ` [PATCH 1/2] target hooks: allow post processing after epilogue inserted Fei Gao
2024-06-05  1:50 ` [PATCH 2/2] [RISC-V]: fix zcmp popretz [PR113715] Fei Gao
2024-06-05  6:36 ` Kito Cheng [this message]
2024-06-05  7:47   ` Re: [PATCH 0/2] fix RISC-V " Fei Gao
2024-06-05 13:58     ` Jeff Law
2024-06-06  2:42       ` Fei Gao
2024-06-08 20:36         ` Jeff Law
2024-06-28 10:46           ` Fei Gao
2024-06-05 13:51   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZDzew+ZRi0CjH_OREY1EF8hevgQghq7Mx6NLYVCge6LsA@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=gaofei@eswincomputing.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).