From: Lehua Ding <lehua.ding@rivai.ai>
To: Jeff Law <jeffreyalaw@gmail.com>, Edwin Lu <ewlu@rivosinc.com>,
gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert
Date: Tue, 12 Sep 2023 11:17:23 +0800 [thread overview]
Message-ID: <CA2C484004E9DF59+78c12fb0-59d6-44b9-b22b-6aaa5eeb611c@rivai.ai> (raw)
In-Reply-To: <fde21d00-e2ae-4a55-82c3-f06e17b6a485@gmail.com>
Hi Jeff,
On 2023/9/12 11:00, Jeff Law wrote:
> I'd rather be consistent and make it policy that every insn has a type.
Since the type set here will not be used by sched pass (these insn
pattern will not exit at shced pass since use define_insn_and_split with
condition `TARGET_VECTOR && can_create_pseudo_p ()`), I think it is easy
to cause misunderstanding and some problems are not easy to find (e.g.
accidentally went through the sched pass should be assert error). In my
opinion, assert in sched function can ensure that all insn pattern that
reach sched pass have a type attribute. If not, it is a problem and
needs to be located and checked. All insn patterns add type to allow
assert to pass, but at the same time hide or ignore some problems. I
don't know if there is a problem with my understanding, thank you.
--
Best,
Lehua
next prev parent reply other threads:[~2023-09-12 3:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 22:52 Edwin Lu
2023-09-12 0:49 ` Jeff Law
2023-09-15 22:51 ` [Committed] " Edwin Lu
2023-09-15 22:51 ` Edwin Lu
2023-09-12 2:33 ` [PATCH] " Lehua Ding
2023-09-12 3:00 ` Jeff Law
2023-09-12 3:17 ` Lehua Ding [this message]
2023-09-12 3:47 ` Jeff Law
2023-09-12 6:18 ` Lehua Ding
2023-09-17 13:46 ` Jeff Law
2023-09-18 7:29 ` Lehua Ding
2023-09-19 17:23 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA2C484004E9DF59+78c12fb0-59d6-44b9-b22b-6aaa5eeb611c@rivai.ai \
--to=lehua.ding@rivai.ai \
--cc=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).