From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by sourceware.org (Postfix) with ESMTPS id 30B613858D38 for ; Tue, 12 Sep 2023 03:17:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30B613858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp91t1694488647t2qr160d Received: from [10.101.11.9] ( [61.144.172.134]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 12 Sep 2023 11:17:24 +0800 (CST) X-QQ-SSF: 01400000000000C0F000000A0000000 X-QQ-FEAT: ILHsT53NKPgqH4ruX4tRZGWVfpL+ei8W9sFJWIaDe3pSLgi1OP4kh9JZOyUYO IerDCud/st+aE0AKwDLZKUsTYJcO99NJtEyRtfsvawow0uuKbxe3nJM/FyCY/bCzcV0F1U+ 085JF+Ne34hcHx0FzciTCtN7NMCFLU9kjuxxTbNmi6FlAd+Bao6grKnjrP2Bg2psLo3AvIU WoP2BUt41NuSMnhPuyI4e1eea86YxLufuAdNZo1QjnWnJ1XjPF6N894JegBbGLIvkKOR5f5 DeQREYBHO+05ADqEiZM503UbRIevhmih1sqo4+rlzAdxXPKpeCqMe7Az22avopIvX8MifH/ N0KMSqNAedALPm/xhQPDoFfSIBj+bKNaE4ZP1egk7uWvGDN+9o= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 14707954359784839037 Message-ID: Date: Tue, 12 Sep 2023 11:17:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert Content-Language: en-US To: Jeff Law , Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20230911225308.2275313-1-ewlu@rivosinc.com> <9F63A23D4D863426+7ccedfd0-d4fe-4e8f-b06b-fe08817eabce@rivai.ai> From: Lehua Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz6a-0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, On 2023/9/12 11:00, Jeff Law wrote: > I'd rather be consistent and make it policy that every insn has a type. Since the type set here will not be used by sched pass (these insn pattern will not exit at shced pass since use define_insn_and_split with condition `TARGET_VECTOR && can_create_pseudo_p ()`), I think it is easy to cause misunderstanding and some problems are not easy to find (e.g. accidentally went through the sched pass should be assert error). In my opinion, assert in sched function can ensure that all insn pattern that reach sched pass have a type attribute. If not, it is a problem and needs to be located and checked. All insn patterns add type to allow assert to pass, but at the same time hide or ignore some problems. I don't know if there is a problem with my understanding, thank you. -- Best, Lehua