From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Richard Biener <rguenther@suse.de>,
Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>,
gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] tree-optimization/109237 - last_stmt is possibly slow
Date: Wed, 22 Mar 2023 17:50:24 +0100 [thread overview]
Message-ID: <CA6C91E7-F193-4767-9E89-940203D394B6@gmail.com> (raw)
In-Reply-To: <20230322123020.B9718385B533@sourceware.org>
On 22 March 2023 13:29:52 CET, Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>The alternative would be to change last_stmt, explicitely introducing
>last_nondebug_stmt. I remember we chickened out and made last_stmt
>conservative here but not anticipating the compile-time issues this
>creates. I count 227 last_stmt and 12 last_and_only_stmt uses.
In https://inbox.sourceware.org/gcc-help/20211121010713.1452267f@nbbrfq/ i asked if maybe
---8<---
1) last_stmt
wouldn't it be more efficient if tree-cfg.c:: last_stmt() would
gimple_seq_last_nondebug_stmt (bb_seq (bb)) ? That would set stmt=NULL
only after the loop it seems..
next parent reply other threads:[~2023-03-22 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230322123020.B9718385B533@sourceware.org>
2023-03-22 16:50 ` Bernhard Reutner-Fischer [this message]
[not found] <20230322123006.A480C3858296@sourceware.org>
2023-03-26 18:00 ` Jeff Law
[not found] <90515.123032208295400168@us-mta-397.us.mimecast.lan>
2023-03-22 12:38 ` Jakub Jelinek
2023-03-22 12:29 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA6C91E7-F193-4767-9E89-940203D394B6@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).