From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 708103858C42 for ; Sat, 10 Feb 2024 18:07:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 708103858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 708103858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707588472; cv=none; b=X/drxQcY1hViRdSrx9TnBgRx7sYxxEt7dvLTrFs0S6H84jZb8rM6eHA1EI+H4+n8lufSOF20DvnmsqZSjQfsNOpF0Jq/mw75b0VTY32EC0zTfD9V268d5uwZu88x+jS2sGdcf0GZNx+mQlYgsM0SRjo0sUfv8mzoYOJS0dqlvE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707588472; c=relaxed/simple; bh=w8N8XBBWPQb9TLET1uV72+z8G+3ruzfXY02aqXEfRME=; h=DKIM-Signature:From:Mime-Version:Subject:Message-Id:Date:To; b=L4VP7g+q99uOwI6uAfaCp5OdDzFo3Vv29aKyV4GVPg8ekzdpjmwY236oPULad4lZ8yTo9WTvCqwynTZ1MwLwmaWBya3aSgEWMI8Li2HhwZJxfp1y0OCAk5B1apvyHr0n/riG+8wUoHVWFuhKOGDVKFFaScKrZqC3xNuapsAO/ck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-33b670e4093so316301f8f.0 for ; Sat, 10 Feb 2024 10:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707588469; x=1708193269; darn=gcc.gnu.org; h=to:cc:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=WelNxiMj7O3TUSy2R5W7V5rTmy9kOgbd3jZQpKAhESE=; b=PcpuZW7Hh7a6yaDhCZYHx1lC9egqhls2n2UOz4SZDfjyQgM6E3XBVwL5Lpwctd3819 09JdzAAN1TsNiMbjjlsbm3SO56lrbA3R4PgNR+k5T37mxUs8Zlx/bHy79j5pxP3p6Zm6 7GkDfliS333wOQ5SvfqUX5xixq9BBejsoMHDv81XuCdh+5F++FK+ek+gT5oGyqjgpQQr 11mFy5Mc2Ka4MMD9R2B8Eyxi8CY2+GfKLh19ape2IRmSi6x29km7VXT4X194/FQnTryH xpOSxQZhSw+ZlUYNlrpK2TFOlxvczQMa/sDQFBIEc9mpO0EtIqzfAz0kGMw6PWc2nOU/ MNYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707588469; x=1708193269; h=to:cc:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WelNxiMj7O3TUSy2R5W7V5rTmy9kOgbd3jZQpKAhESE=; b=OPOGAm6srwFQcz25Bx249WGFASB3JZjn6EnbQfRis+rUJjJVwWEQoqA4bdMln0QGBb r9KL7q05ZAkUMVJoT6R/Eg00/5x3hZ6ulGwe3jHWzpJG8EuRBTkQGVfUPRmCkbB+j86i cnBAxWD3yUCWzS6S3FBR37dpJUQ4BRFtlZNpERr10Is4kTzHK8wEMjmEDVIYhQSgcz6b cVfgsIfrD2Erzy/E3SQ2a13k/YG42obYAyfq/3woDJgKEEN4t2j0eDUblMFdZ3NpXABT yDT4eEnJQp90qXKJP/AzbQj/FLwtk97zYcBUWCIK7DZPy5XmlSogGrNReboYVcjMWc+J uVVQ== X-Gm-Message-State: AOJu0YwTWIoV3+zC0UT9U6hMaLd4B/PZaFuWCPaL/CvzRaiHBOGJNqfx UfUdDq/QgB+clOdMtdEQvWWX5QWxMaz7UZIP1v2flLwgNu/GAHlOaOh7rNkm X-Google-Smtp-Source: AGHT+IEci2kfmSMMW6FsC6xVEi6OwYnZVrwvZFODbW63+5N7q0uFQHReKnAh7tuuOUmSn5jq7mgo9g== X-Received: by 2002:a05:600c:3b29:b0:410:6ab1:3793 with SMTP id m41-20020a05600c3b2900b004106ab13793mr2090014wms.4.1707588468918; Sat, 10 Feb 2024 10:07:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV659HavfucjmymTVlZKUHFxvffq7r36hUVXgK1GtDGsmXd+t8VlQtium0NGb8xEQw/qb4hJgXGFXfZZp4eUwTHow== Received: from smtpclient.apple (chp126.enscp.fr. [193.51.253.126]) by smtp.gmail.com with ESMTPSA id a15-20020adffacf000000b0033b39cba5e4sm2385845wrs.116.2024.02.10.10.07.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Feb 2024 10:07:48 -0800 (PST) From: FX Coudert Content-Type: multipart/mixed; boundary="Apple-Mail=_7F398D38-3BF9-47FE-ACCE-55E6EFDF75F2" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\)) Subject: [PATCH] i386, testsuite: adjust asm patterns Message-Id: Date: Sat, 10 Feb 2024 19:07:37 +0100 Cc: Fangrui Song , Iain Sandoe To: GCC Patches X-Mailer: Apple Mail (2.3774.400.31) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_7F398D38-3BF9-47FE-ACCE-55E6EFDF75F2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This = is partly because symbols are prefixed with underscore, and also because = the order of operands in the addition is reversed (but I think it=E2=80=99= s valid still). The code generated is this: _func: LFB0: pushq %rbp LCFI0: movq %rsp, %rbp LCFI1: # 8 = "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" = 1 @ _func # 0 "" 2 # 9 = "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" = 1 @ 4+_var # 0 "" 2 nop popq %rbp LCFI2: ret I=E2=80=99m adjusting the pattern accordingly. OK to push? FX --Apple-Mail=_7F398D38-3BF9-47FE-ACCE-55E6EFDF75F2 Content-Disposition: attachment; filename=0001-i386-testsuite-adjust-asm-patterns.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-i386-testsuite-adjust-asm-patterns.patch" Content-Transfer-Encoding: quoted-printable =46rom=20bfafd28ce6736b033d126284fe30d9fe1ee783f0=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Francois-Xavier=20Coudert=20= =0ADate:=20Sat,=2010=20Feb=202024=2019:03:37=20= +0100=0ASubject:=20[PATCH]=20i386,=20testsuite:=20adjust=20asm=20= patterns=0A=0AOn=20darwin,=20symbols=20are=20prefixed=20with=20= underscore,=20and=0Athe=20order=20of=20operands=20is=20reversed.=0A=0A= gcc/testsuite/ChangeLog:=0A=0A=09*=20gcc.target/i386/asm-raw-symbol.c:=20= Adjust=20asm=20patterns.=0A---=0A=20= gcc/testsuite/gcc.target/i386/asm-raw-symbol.c=20|=204=20++--=0A=201=20= file=20changed,=202=20insertions(+),=202=20deletions(-)=0A=0Adiff=20= --git=20a/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c=20= b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c=0Aindex=20= b7854567dd9..001eb660ad7=20100644=0A---=20= a/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c=0A+++=20= b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c=0A@@=20-9,5=20+9,5=20@@=20= func=20(void)=0A=20=20=20__asm__=20("@=20%p0"=20:=20:=20"Ws"=20(&var=20+=20= 1));=0A=20}=0A=20=0A-/*=20{=20dg-final=20{=20scan-assembler=20"@=20func"=20= }=20}=20*/=0A-/*=20{=20dg-final=20{=20scan-assembler=20"@=20var\\+4"=20}=20= }=20*/=0A+/*=20{=20dg-final=20{=20scan-assembler=20"@=20_?func"=20}=20}=20= */=0A+/*=20{=20dg-final=20{=20scan-assembler=20"@=20= (_?var\\+4|4\\+_?var)"=20}=20}=20*/=0A--=20=0A2.39.3=20(Apple=20Git-145)=0A= =0A= --Apple-Mail=_7F398D38-3BF9-47FE-ACCE-55E6EFDF75F2--