[PATCH] i386, testsuite: adjust asm patterns

[PATCH] i386, testsuite: adjust asm patterns

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is partly because symbols are prefixed with underscore, and also because the order of operands in the addition is reversed (but I think it’s valid still). The code generated is this:

_func:
LFB0:
        pushq   %rbp
LCFI0:
        movq    %rsp, %rbp
LCFI1:
# 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
        @ _func
# 0 "" 2
# 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
        @ 4+_var
# 0 "" 2
        nop
        popq    %rbp
LCFI2:
        ret



I’m adjusting the pattern accordingly.
OK to push?

FX


[-- Attachment #2: 0001-i386-testsuite-adjust-asm-patterns.patch --]
[-- Type: application/octet-stream, Size: 1102 bytes --]

From bfafd28ce6736b033d126284fe30d9fe1ee783f0 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Sat, 10 Feb 2024 19:03:37 +0100
Subject: [PATCH] i386, testsuite: adjust asm patterns

On darwin, symbols are prefixed with underscore, and
the order of operands is reversed.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/asm-raw-symbol.c: Adjust asm patterns.
---
 gcc/testsuite/gcc.target/i386/asm-raw-symbol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c
index b7854567dd9..001eb660ad7 100644
--- a/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c
+++ b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c
@@ -9,5 +9,5 @@ func (void)
   __asm__ ("@ %p0" : : "Ws" (&var + 1));
 }
 
-/* { dg-final { scan-assembler "@ func" } } */
-/* { dg-final { scan-assembler "@ var\\+4" } } */
+/* { dg-final { scan-assembler "@ _?func" } } */
+/* { dg-final { scan-assembler "@ (_?var\\+4|4\\+_?var)" } } */
-- 
2.39.3 (Apple Git-145)

Re: [PATCH] i386, testsuite: adjust asm patterns

[Mike Stump]

On Feb 10, 2024, at 10:07 AM, FX Coudert <fxcoudert@gmail.com> wrote:
> 
> The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is partly because symbols are prefixed with underscore, and also because the order of operands in the addition is reversed (but I think it’s valid still). The code generated is this:
> 
> _func:
> LFB0:
>        pushq   %rbp
> LCFI0:
>        movq    %rsp, %rbp
> LCFI1:
> # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
>        @ _func
> # 0 "" 2
> # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
>        @ 4+_var
> # 0 "" 2
>        nop
>        popq    %rbp
> LCFI2:
>        ret
> 
> 
> 
> I’m adjusting the pattern accordingly.
> OK to push?

Ok.

Re: [PATCH] i386, testsuite: adjust asm patterns

[Fangrui Song]

On Sun, Feb 11, 2024 at 11:12 AM Mike Stump <mikestump@comcast.net> wrote:
>
> On Feb 10, 2024, at 10:07 AM, FX Coudert <fxcoudert@gmail.com> wrote:
> >
> > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is partly because symbols are prefixed with underscore, and also because the order of operands in the addition is reversed (but I think it’s valid still). The code generated is this:
> >
> > _func:
> > LFB0:
> >        pushq   %rbp
> > LCFI0:
> >        movq    %rsp, %rbp
> > LCFI1:
> > # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
> >        @ _func
> > # 0 "" 2
> > # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
> >        @ 4+_var
> > # 0 "" 2
> >        nop
> >        popq    %rbp
> > LCFI2:
> >        ret
> >
> >
> >
> > I’m adjusting the pattern accordingly.
> > OK to push?
>
> Ok.

Thanks for commit bbf05e3753c0fd49f1a3bf23897fa96d052ddae9!



-- 
宋方睿