From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3050 invoked by alias); 4 Apr 2017 13:57:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3038 invoked by uid 89); 4 Apr 2017 13:57:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=PhD, Ph.D, UD:Ph.D, ph.d X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 13:57:09 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v34Dmrxa129300 for ; Tue, 4 Apr 2017 09:57:08 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0b-001b2d01.pphosted.com with ESMTP id 29m24aqgy3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 04 Apr 2017 09:57:08 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Apr 2017 09:57:08 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 4 Apr 2017 09:57:04 -0400 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v34Dv6jo42270760; Tue, 4 Apr 2017 13:57:06 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BF97124035; Tue, 4 Apr 2017 09:56:59 -0400 (EDT) Received: from bigmac.rchland.ibm.com (unknown [9.10.86.201]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTPS id E5CAD12403F; Tue, 4 Apr 2017 09:56:58 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: [PR 79905] ICE with vector_type From: Bill Schmidt In-Reply-To: <7cd553e8-623a-d2d4-0ace-331f3df14701@acm.org> Date: Tue, 04 Apr 2017 13:57:00 -0000 Cc: Richard Biener , GCC Patches Content-Transfer-Encoding: quoted-printable References: <7cd553e8-623a-d2d4-0ace-331f3df14701@acm.org> To: Nathan Sidwell X-TM-AS-GCONF: 00 x-cbid: 17040413-0044-0000-0000-000002F5E86B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006881; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00842976; UDB=6.00415296; IPR=6.00621151; BA=6.00005265; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014907; XFM=3.00000013; UTC=2017-04-04 13:57:06 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040413-0045-0000-0000-00000723E87B Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-04_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704040123 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00155.txt.bz2 I'll try the POC patch in a bit (kind of ugly as we have to replicate this = for a whole bunch of types, I guess). Just FYI, I noticed this similar bug report came in today, not sure about t= he types: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D80309 -- Bill Bill Schmidt, Ph.D. GCC for Linux on Power Linux on Power Toolchain IBM Linux Technology Center wschmidt@linux.vnet.ibm.com > On Apr 4, 2017, at 8:49 AM, Nathan Sidwell wrote: >=20 > On 04/04/2017 09:00 AM, Richard Biener wrote: >=20 >> tree >> add_builtin_type (const char *name, tree type) >> { >> tree id =3D get_identifier (name); >> tree decl =3D build_decl (BUILTINS_LOCATION, TYPE_DECL, id, type); >> return lang_hooks.decls.pushdecl (decl); >> } >>=20 >> this seems to miss setting TYPE_NAME (type) =3D decl - oh, that may be >> what set_underlying_type does via the langhook. >=20 > Correct, via the langhook. I wonder if the smacking of the incoming-type= 's TYPE_NAME is so that the global tree node references the now-named built= in type. If we were to make a clone here, (things like) VS4SI_type_node wo= uld remain an unnamed type. And I guess debug would be unhappy? >=20 >> At this point I'd rather restrict fiddling in this fragile area in >> rs6000.c only ;) >=20 > me too. >=20 >> Does removing the TYPE_NAME setting fix things? >=20 > no, those TYPE_NAME assignments are redundant -- set_underlying_type has= already initialized it. >=20 > The attached PoC fixes 79905 (no idea what ppc test it might break) >=20 > nathan >=20 > --=20 > Nathan Sidwell > <79905-2.diff>