From: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] PR c++/50055: Location information for the throw() specification in a function may be incorrect
Date: Fri, 12 Aug 2011 19:39:00 -0000 [thread overview]
Message-ID: <CAAHN_R2AiK_uCtc-eSv899=EpCK7RtKTN66XtTgUb=Yni3Ut=Q@mail.gmail.com> (raw)
Hi,
When the location for throw() exception specification is not the same
as the function it is written against, it leads gcov to give incorrect
results. See bug 50055 for details of the the same. The following
patch makes sure that the exception specification block (nothrow or
otherwise) is always associated with the function definition line
number.
I have a test case included with the patch. I ran the c++ test suite
and found no regressions due to this patch.
--
Siddhesh
cp/ChangeLog:
PR c++/50055
* except.c (begin_eh_spec_block): Build EH_SPEC block on the
same line as the function.
testsuite/ChangeLog:
PR c++/50055
* g++.dg/gcov/gcov-7.C: New test.
Index: gcc/testsuite/g++.dg/gcov/gcov-7.C
===================================================================
--- gcc/testsuite/g++.dg/gcov/gcov-7.C (revision 0)
+++ gcc/testsuite/g++.dg/gcov/gcov-7.C (revision 0)
@@ -0,0 +1,28 @@
+/* Check that Exception handler specification is not
+ mapped to the curly braces below the function
+ declaration. */
+
+/* { dg-options "-fprofile-arcs -ftest-coverage" } */
+/* { dg-do run { target native } } */
+
+struct foo
+{
+ foo () throw (int)
+ { /* count (-) */
+ throw (1);
+ }
+};
+
+int main ()
+{
+ try
+ {
+ foo f;
+ }
+ catch ( ...)
+ {
+ return 0;
+ }
+}
+
+/* { dg-final { run-gcov gcov-7.C } } */
Index: gcc/cp/except.c
===================================================================
--- gcc/cp/except.c (revision 177613)
+++ gcc/cp/except.c (working copy)
@@ -527,15 +527,17 @@
begin_eh_spec_block (void)
{
tree r;
+ location_t spec_location = DECL_SOURCE_LOCATION (current_function_decl);
+
/* A noexcept specification (or throw() with -fnothrow-opt) is a
MUST_NOT_THROW_EXPR. */
if (TYPE_NOEXCEPT_P (TREE_TYPE (current_function_decl)))
{
- r = build_stmt (input_location, MUST_NOT_THROW_EXPR, NULL_TREE);
+ r = build_stmt (spec_location, MUST_NOT_THROW_EXPR, NULL_TREE);
TREE_SIDE_EFFECTS (r) = 1;
}
else
- r = build_stmt (input_location, EH_SPEC_BLOCK, NULL_TREE, NULL_TREE);
+ r = build_stmt (spec_location, EH_SPEC_BLOCK, NULL_TREE, NULL_TREE);
add_stmt (r);
TREE_OPERAND (r, 0) = push_stmt_list ();
return r;
next reply other threads:[~2011-08-12 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 19:39 Siddhesh Poyarekar [this message]
2011-08-23 15:39 ` Jason Merrill
2011-08-23 15:43 ` Jakub Jelinek
2011-08-23 15:45 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAHN_R2AiK_uCtc-eSv899=EpCK7RtKTN66XtTgUb=Yni3Ut=Q@mail.gmail.com' \
--to=siddhesh.poyarekar@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).