From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id A435D3858D28 for ; Tue, 20 Feb 2024 14:32:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A435D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A435D3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708439572; cv=none; b=YqX0DM6+6jsJ68W0yFcqrDFy+ljxz1Ry4Btc4PKuH/V9dQFbmuLq01KCQWWq/iEn4BDPOiF6OF/fMT6fjloHmT3S2asv67C1vWNdshcDOZuK14sBf68cRAC6RA0x1UcNbwq6URMnGpHV7mrCj7hV4wqz4QZ7WJv8ZN/cppAgqEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708439572; c=relaxed/simple; bh=jUTCnaFtTGShDnqth5NkDOQvIe99Ny2tQwqKlz2YC40=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xhMap52WJ7BRzeZbOLFkArvwvCCrS7gXepnAbjxrzXB3DADoPKSTq7IzJBOk0N5WwloPT5Bm2+HeKC159HTJM0iX+nRUQG0XojLG5g/hkJf0Pb3rDoiwEAOl1DTTkICoLYQOeqKrvvG0an2zha4VDoKxiwuVYqIkvK8/H9OSYLo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-dcbc6a6808fso5748755276.2 for ; Tue, 20 Feb 2024 06:32:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708439561; x=1709044361; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oOceZGpJZGbRVrrOsr/0/2fJvrozIF9GjfpfSiWJf6Y=; b=eNtbcy+zqtyMs3nSsz4tb7M/uIcAT9ChZvkKFF7qPs+kIiSxowYL5b1zvKAHEULqN1 ctJQZMBnTmIQWi+Rb5AyklYfBUQw3lVSnJgJL2wIkkaQCM52wjHUWq3mt6Q/1q9Yr6t+ usuFygNFgJCdrW6bqgMju4g04v9ex/ZMEsFXqaX4sMi0XyUTnUDhAEcv5KMS+RzbqQ+8 Y5MbozPqG3A3+7vIQRDI6EsI9/iIuWEHbKPVgBnYOfIDvN82v/x8XzaX4wkI0zdYQhfp CMZqRp49lEKmjhH6iCwHIGbWkfFAwoe1jxocbzAlEWMPJVswtX5pDnmtw/59yO2nYoJ2 v5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708439561; x=1709044361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oOceZGpJZGbRVrrOsr/0/2fJvrozIF9GjfpfSiWJf6Y=; b=bMljyBzYWijWRVP6wIyHSJf9ord/JINndCEl58L+cz+83kGj9m2p7dDtlTTlhAR3QU tcXGFx/Yf2Y2P2Ba/Fb8aTOBwpoURx/4ybzxg4cKgGOZf7RMJ7q712PwqNQ3pmPfgQSW qYwpfsCA9jqV8YQqGd5+qeTxfbFu+G8soqUXIOOkIfp0Ldq+pzAc+nuNN+a0sMWPOYLr 9ypBtlu2cXSKyCG2Hyp+FP7Py9Qj96sJDAbJw7vYJclb7diZYdLfhWdTioocNJ3X6X4R oqN4ODGnhg700kMU1cDJrlP3+XwjR7JXQ2iwDtEuRKEdwLhoxomTtxkPBOm0IHn0MxXW 5LVg== X-Gm-Message-State: AOJu0YyVB1897FimtPNy6nWmwNl8yercOr8ok9Z1U6yF7Lrx0CmdQJgy lVJ0lAt09L2nYh8a7fDnt9KjrEwHohwS4KcpRr1Bzg42uFKZdPk5JzriM5mrqSQvXI2wlVyKNAV jZ38oVA7tqB+cJMB7LGxhqUP29bo= X-Google-Smtp-Source: AGHT+IGdZpimV437TMJRMvCfHyJFs4Lrv8aWfzzjglIqnqtHhjJrEjCDIRvkC946N0YhcaNqTD+ICVu6dE6HqZb+TiI= X-Received: by 2002:a25:ba83:0:b0:dcc:744d:b485 with SMTP id s3-20020a25ba83000000b00dcc744db485mr11069524ybg.33.1708439559463; Tue, 20 Feb 2024 06:32:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Lewis Hyatt Date: Tue, 20 Feb 2024 09:32:27 -0500 Message-ID: Subject: Re: [PATCH] libcpp: Improve location for macro names [PR66290] To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 19, 2024 at 11:36=E2=80=AFPM Alexandre Oliva wrote: > > This backport for gcc-13 is the first of two required for the > g++.dg/pch/line-map-3.C test to stop hitting a variant of the known > problem mentioned in that testcase: on riscv64-elf and riscv32-elf, > after restoring the PCH, the location of the macros is mentioned as if > they were on line 3 rather than 2, so even the existing xfails fail. I > think this might be too much to backport, and I'm ready to use an xfail > instead, but since this would bring more predictability, I thought I'd > ask whether you'd find this backport acceptable. > > Regstrapped on x86_64-linux-gnu, along with other backports, and tested > manually on riscv64-elf. Ok to install? Sorry that test is causing a problem, I hadn't realized at first that the wrong output was target-dependent. I feel like simply deleting this test g++.dg/pch/line-map-3.C from GCC 13 branch should be fine too, as a safer alternative, if release managers prefer? It doesn't really need to be on the branch, it's only purpose is to remind me to fix the underlying issue for GCC 15... -Lewis