public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Lewis Hyatt <lhyatt@gmail.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
	Jason Merrill <jason@redhat.com>,
	 David Malcolm <dmalcolm@redhat.com>
Subject: ping: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]
Date: Fri, 16 Feb 2024 19:02:25 -0500	[thread overview]
Message-ID: <CAA_5UQ5=989FGeXEfGYxepFhD10Ki3D6HSWu4Q-p2iy+rjHYiQ@mail.gmail.com> (raw)
In-Reply-To: <CAA_5UQ4SUe_N27kxGmU99V3SssPiKhqeDhq8Ko77h3dS0T+H1g@mail.gmail.com>

CCing some global reviewers as well, in case anyone has a minute to
take a look please? Thanks!
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html

On Thu, Jan 25, 2024 at 4:57 PM Lewis Hyatt <lhyatt@gmail.com> wrote:
>
> May I please ask again about this one? It's just a couple lines, and I
> think it fixes an important gap in the logic for #pragma GCC
> diagnostic. The PR was not reported by me so I think at least one
> other person does care about it :). Thanks!
>
> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html
>
> -Lewis
>
> On Mon, Jan 8, 2024 at 6:53 PM Lewis Hyatt <lhyatt@gmail.com> wrote:
> >
> > Can I please ping this one again? It's 3 lines or so to fix the PR. Thanks!
> > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html
> >
> > On Tue, Dec 19, 2023 at 6:20 PM Lewis Hyatt <lhyatt@gmail.com> wrote:
> > >
> > > Hello-
> > >
> > > May I please ping this one? Thanks...
> > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html
> > >
> > > -Lewis
> > >
> > > On Wed, Nov 29, 2023 at 7:05 PM Lewis Hyatt <lhyatt@gmail.com> wrote:
> > > >
> > > > On Thu, Nov 09, 2023 at 04:16:10PM -0500, Lewis Hyatt wrote:
> > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111918
> > > > >
> > > > > This patch fixes the behavior of `#pragma GCC diagnostic pop' for permissive
> > > > > error diagnostics such as -Wnarrowing (in C++11). Those currently do not
> > > > > return to the correct state after the last pop; they become effectively
> > > > > simple warnings instead. Bootstrap + regtest all languages on x86-64, does
> > > > > it look OK please? Thanks!
> > > >
> > > > Hello-
> > > >
> > > > May I please ping this bug fix?
> > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635871.html
> > > >
> > > > Please note, it requires a trivial rebase on top of recent changes to
> > > > the class diagnostic_context public interface. I attached the rebased patch
> > > > here as well. Thanks!
> > > >
> > > > -Lewis

  reply	other threads:[~2024-02-17  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 21:57 Lewis Hyatt
2024-02-17  0:02 ` Lewis Hyatt [this message]
2024-03-19 13:03   ` Lewis Hyatt
2024-03-19 17:55     ` David Malcolm
  -- strict thread matches above, loose matches on Subject: below --
2023-11-09 21:16 Lewis Hyatt
2023-11-30  0:05 ` ping: " Lewis Hyatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA_5UQ5=989FGeXEfGYxepFhD10Ki3D6HSWu4Q-p2iy+rjHYiQ@mail.gmail.com' \
    --to=lhyatt@gmail.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).