From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id D150C3858D32 for ; Tue, 23 Aug 2022 23:47:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D150C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12a.google.com with SMTP id z25so21785779lfr.2 for ; Tue, 23 Aug 2022 16:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=5+okOeB1kQZiVaD0DdPyG6aLwPA+H5R5n6tGH0ty5qo=; b=bzCdkPDhLKd0cKV0MR1lcRBYwLZYhAfLw/K44CyOLks1vl3PgKcMjEB/jBSvtWOpuG ZVy+8sP62xtLwxkeMn2Q5M31J8PE57NobGCV45HSjSN5Eer6hivXm1vu1Hde98kEeeq5 PR+GB3Kx2SjqQ+DSToDZJJ7hN0id0tYYZzm+xZNZ25SVuufwyVFTNr4H4gU0qJ7iaVBx jpyJuoRwUC7pG9p1yRhf/mZdX9Si/Cm+CHfufHLEHvI+Au5/hLtMhBl7MrSACnWK50BR dZs+xPUGG5HoaPsLywWuknjZbBsi49sq4kaChirFGNF+mnmEuX5EEYGtsqzvAGg0Z0b0 74gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5+okOeB1kQZiVaD0DdPyG6aLwPA+H5R5n6tGH0ty5qo=; b=77XDstEd5ONOD6gjdCbuKAD8AJVGLU1nKw2hnCHTs7fC8n+Amw9NYilwTCPr8zoEDD bufniDQQ8dagc7azkrOctFrSFNQcgfX9w6HWAO/dwEj0mPeUxyDQC+9yRKMpxl095Pdm ubwROq/FXDRDYMyGFOMUFMMODSHVqTpS2KS9bWqdlomZRZy2S9JhIiOp4NkOFCRB618A TpSfWD93Oo+un2uY9L/xCvOvnVQBKQqXR/LxE4uceT9oLzzMR83CRENj7IS3NCls+rfr KVX6PUJCLuxv3KoddhZpQ72ZipFTCNQ3H8UKlAqOLwDW2EKFxgpFCC84jdfdwZja9ra3 Ih/A== X-Gm-Message-State: ACgBeo3mdSmZ6sI63k5S9fVBDWnsxRprXLiu1raB4VmOnyEryliJyi1/ xpPbCjmbyqtAFlRZG+knror5lmaCIJb7f4HTcPOGgedu X-Google-Smtp-Source: AA6agR6UXm70hgzpiVxMyQacJ6Ls7xJmPzH5OH8RHfAGko0USCCYjtPA/9F/37dIn7Du6GNRu4qeoEJtDaSp6cMdaNo= X-Received: by 2002:a05:6512:1309:b0:492:e273:d800 with SMTP id x9-20020a056512130900b00492e273d800mr4329064lfu.93.1661298451327; Tue, 23 Aug 2022 16:47:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Lewis Hyatt Date: Tue, 23 Aug 2022 19:47:20 -0400 Message-ID: Subject: Re: Ping^2: 2 libcpp patches To: gcc-patches List Cc: Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Aug 16, 2022 at 9:50 AM Lewis Hyatt wrote: > > On Wed, Jul 20, 2022 at 8:56 PM Lewis Hyatt wrote: > > > > Hello- > > > > May I please ping these two preprocessor patches? > > > > For PR103902: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596704.html > > > > For PR55971: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596820.html > > > > Thanks! > > Hello- > > I would very much appreciate feedback on these two patches please? > > For the first patch, I think it is a worthwhile goal to fix all the > places where libcpp fails to support UTF-8 correctly, and this is one > of two remaining ones that I'm aware of. I can fix the other case > (handling of #pragma push_macro) once this one is in place. > > The second patch is about libcpp not allowing raw strings containing > newlines in preprocessor directives, which is a nearly decade-old > glitch that I think is also worth addressing. > > Thanks! > > -Lewis Hello- I CCed Joseph on this ping last week, but he suggested asking other maintainers to take a look, so I hope it's OK I am doing that now? Jakub, I thought it could make sense to ask you please, since I saw you working on lex.cc recently as well, and also since you commented on PR55971 nine years ago :). With an uptick in development of libcpp to support new C++23 features, I think the chances that my patches will eventually conflict with those are increasing, so it would be great to get them reviewed. As of current master branch, they still apply and regtest fine. Thanks very much. -Lewis