From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 70B8A3857817 for ; Tue, 12 Jul 2022 11:51:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70B8A3857817 Received: by mail-lj1-x236.google.com with SMTP id u14so9569163ljh.2 for ; Tue, 12 Jul 2022 04:51:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VbRrTUhsOUAQLxqAPwU/+aA5B3C/1ihm1kKhqePpxic=; b=CCj7f8EQ0ZqMCEplq4RblKMfaEhbbVSUgR1cZoF8Upz/HSqRPMNnxIIkGLnrS0mTEu ZsBJtTrGh85uBRyCFw6hEQOyZr41CTc8g2c4+r6jHkGqNZGzagMTtBSTfuk4CYLGOQ3j AIjeYNN+pINbLx72tpqyb/wx+AcJrhTZ0zWBtYXJ5N7vgWpopYJQnGdetZbqc4w0BgiT oKOmYA/z94cRrD1RG/Igs/jGbbxSnOR4nmn1ytwg7xpgi5YkQV4gZycpwVxUScyD0tIi MM9AZJcDw/HkvjtENdLP/qVpywo7W7Y+OiWfugAJfLGtHF0rEfwsiLsr3I02DHvaXy17 e0LQ== X-Gm-Message-State: AJIora+IGWD0K7i3Juu0vOhuqP6LMIonBci+hLB/y/zhuoKRbUEtoXn1 lfwBJT2klTBXbgCHgpnDWZbMqKpyktOu+5bT1eE/PTyD X-Google-Smtp-Source: AGRyM1vSqlx1rneWTWsWkCpPW6xruL/upr+aME4uSqxRoENbQ/oH5GG4+sOfAjj16T6H9HRPmw2IIv5EfDahelpddzM= X-Received: by 2002:a2e:9849:0:b0:25d:63f7:ce3b with SMTP id e9-20020a2e9849000000b0025d63f7ce3bmr8195270ljj.427.1657626667763; Tue, 12 Jul 2022 04:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20220709205230.GA4991@ldh-imac.local> <377c7016-633c-f354-8c21-599ff2b56449@gmail.com> <87edys3spb.fsf@euler.schwinge.homeip.net> <87bktu4z7m.fsf@euler.schwinge.homeip.net> In-Reply-To: <87bktu4z7m.fsf@euler.schwinge.homeip.net> From: Lewis Hyatt Date: Tue, 12 Jul 2022 07:50:56 -0400 Message-ID: Subject: Re: XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] (was: Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases) To: Thomas Schwinge Cc: gcc-patches List , Jeff Law Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 11:51:11 -0000 On Tue, Jul 12, 2022 at 2:33 AM Thomas Schwinge wrote: > > Hi! > > On 2022-07-11T11:27:12+0200, I wrote: > > [...], I've just pushed to master branch > > commit 06b2a2abe26554c6f9365676683d67368cbba206 > > "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases" > > > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c > > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c > > @@ -17,7 +17,7 @@ const int n = 100; > > #define check_reduction(gwv_par, gwv_loop) \ > > { \ > > s1 = 2; s2 = 5; \ > > -DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) \ > > +DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) /* { dg-line DO_PRAGMA_loc } */ \ > > DO_PRAGMA (acc loop gwv_loop reduction (+:s1, s2)) \ > > for (i = 0; i < n; i++) \ > > { \ > > @@ -45,8 +45,10 @@ main (void) > > > > /* Nvptx targets require a vector_length or 32 in to allow spinlocks with > > gangs. */ > > - check_reduction (num_workers (nw) vector_length (vl), worker); > > - /* { dg-warning "region is vector partitioned but does not contain vector partitioned code" "test1" { target *-*-* } pragma_loc } */ > > + check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc } > > + /* { dg-warning "22:region is vector partitioned but does not contain vector partitioned code" "" { target *-*-* } pragma_loc } > > + { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* } DO_PRAGMA_loc } > > + { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* } check_reduction_loc } */ > > Oh my, PR101551 "[offloading] Differences in diagnostics etc." > strikes again... The latter two 'note' diagnostics are currently > only emitted in non-offloading configurations. I've now pushed to > master branch commit 3723aedaad20a129741c2f6f3c22b3dd1220a3fc > "XFAIL 'offloading_enabled' diagnostics issue in > 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551]", see attached. > Would you mind please confirming how I need to run configure in order to get this configuration? Then I can look into why the difference in location information there. Thanks.... -Lewis