From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 7B0523857C52 for ; Thu, 22 Feb 2024 14:46:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B0523857C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B0523857C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708613198; cv=none; b=EzYP8qLqYZy1BqatS9S6opf12a2490xZD4nQn/uTu5xBQcUbJwMO/lsBtM6tMXnHYJTavfavKLYj0bt+N3ozv1/iGcDb25W1TRTFC6GRjuDXgSyFMB2laakB13aosXPYhjVN5ZoVmM9V7PwLKm/VIWvPgIyUNx+oDev7yNYZiTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708613198; c=relaxed/simple; bh=9wxAyJcw3FCwAVpi3i7/Zd1Nx9jfb11JAI1Jsobu6e8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=TRQxzrMcWDPRSpnMRdfvnbmB5VLFqbPgsjkfHG2eC9G0lOivzObrAy38GxuETAAOpTI6HZzdcS0eIYweyvf3YzkJQa0pkCmTaw5CSyybj4l6271lkSgcVJex4TNfgV6hwXetICZw+pOcw1mP1vFGBQjUcTRBaHIA4BNv8sqlFTA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-dcbd1d4904dso8751435276.3 for ; Thu, 22 Feb 2024 06:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708613196; x=1709217996; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+ErLJe5wOknhiC5GNZf2idwy3ZVI7pFCnmCxv0TrQIc=; b=FlqTOccTr2QaPIbpqcUkimWXAmada18TxE8KPNp5DhTr5U/YWcVyOImYQbzXyhwcFU K7lf3tOxfg6Hx+t1JNP7W2iJY5XqCGKPEhEQSCQ+7tnfmJfCzPwGnrAjLqk8RUyrb6R8 5Lxiz7pv/ebopRw7tmPiTGuE5rdfRYnJR2C0LIRZk5aVn1SbH0n1Xq72Nta3MAJUVvQK dQjInU759qqbjHGHf39+A1AucvGbJpzqY+WDVW2xfRyJJYSMJ7I/cXaocOkkgQF0No60 qnbsA2UiKkeXvpiwbCCe2lgrBmGw9dkCgSp+bxNvhS8V2ONgIExEPDzkMaCC2ZjyE9bp ISfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708613196; x=1709217996; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ErLJe5wOknhiC5GNZf2idwy3ZVI7pFCnmCxv0TrQIc=; b=sbWk9lcZoGt3SVw6GFWhcXg3yDyWyj7cC29tXtMp+uBuc44zc3JRP3lttBcNGaKO// O/86nw5sh7z/lJy45uWKI0V1fC9XNWTkg6oDRI9rcEHnJScXbKsmUwh3p8kFlwiVBNfB DpAr7+p3ILx1DrCIHpqgChbuyFudGG6zoQiUaTUmxVQJqqbA2kc2C19bf8e4fINI9Ax0 BeMv90WRrwI/E5p69PogQk0DfltrXLvhujDyECSKnUhLlApoiWshIDiZRRATXpO93//G KihGP4PM3XSXFLY/PGQp0ahCMYjaPc3L/TnIXTaJ0fJIgLQt/9Y2uUyQMze6PE7KB4x9 uUiA== X-Forwarded-Encrypted: i=1; AJvYcCXPFPLKvtFz6bK3Q+e0KUN9W/9A3/SueElK78RQw3YxvzFc6K06bX7j+htBmQvOMmdKhRzWCmk9aBUKhVdZYF4DoDyU0SgJsg== X-Gm-Message-State: AOJu0Yx7o3t+Z4HyeRlWqc16lGLok878tn1TP9i2JQ0tKyaB+OFCDIfP fR3W/i0V2q4ZqXuQzgimPMvquLoBQ/jffra1XPBuhXXrTpmF3OTgvtOECcWtmvbBLxrb7l0YJK0 6ORVEKFVRNgdfw3/vSV3ysLvGsu0= X-Google-Smtp-Source: AGHT+IFF3UevAD8FNb5eU6eL9ZLhxxrx+ZcQWooDghKMuo4TcfG7PEztUzH2CYAOGAPFHVu6/r9Wt+d1Oflg8vccOmo= X-Received: by 2002:a25:9783:0:b0:dc6:de64:f74 with SMTP id i3-20020a259783000000b00dc6de640f74mr2667913ybo.9.1708613195775; Thu, 22 Feb 2024 06:46:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Lewis Hyatt Date: Thu, 22 Feb 2024 09:46:24 -0500 Message-ID: Subject: Re: [PATCH] libcpp: Improve location for macro names [PR66290] To: Richard Biener Cc: Alexandre Oliva , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 22, 2024 at 3:56=E2=80=AFAM Richard Biener wrote: > > On Tue, Feb 20, 2024 at 3:33=E2=80=AFPM Lewis Hyatt wr= ote: > > > > On Mon, Feb 19, 2024 at 11:36=E2=80=AFPM Alexandre Oliva wrote: > > > > > > This backport for gcc-13 is the first of two required for the > > > g++.dg/pch/line-map-3.C test to stop hitting a variant of the known > > > problem mentioned in that testcase: on riscv64-elf and riscv32-elf, > > > after restoring the PCH, the location of the macros is mentioned as i= f > > > they were on line 3 rather than 2, so even the existing xfails fail. = I > > > think this might be too much to backport, and I'm ready to use an xfa= il > > > instead, but since this would bring more predictability, I thought I'= d > > > ask whether you'd find this backport acceptable. > > > > > > Regstrapped on x86_64-linux-gnu, along with other backports, and test= ed > > > manually on riscv64-elf. Ok to install? > > > > Sorry that test is causing a problem, I hadn't realized at first that > > the wrong output was target-dependent. I feel like simply deleting > > this test g++.dg/pch/line-map-3.C from GCC 13 branch should be fine > > too, as a safer alternative, if release managers prefer? > > Yes please. > > Richard. Committed that removal as r13-8353. -Lewis