From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 09BD53858D1E; Sat, 6 Jan 2024 16:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09BD53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09BD53858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704560248; cv=none; b=rUnCX6jbBDb2oaOGuojv/l7QbeP/xnTjXECzE7FS1LLea11pdg6eV/QfAiLI0M18mkaIAHNPLRi4yb9SUFFT7FMZPGbJaULSPqns9vlHwer5wWGpsWgOxjtlVfwEQT+t0udKaP6R8cZMPCBeQ5JMy98yRTGiEWnxCqVQQ53D2+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704560248; c=relaxed/simple; bh=TUYNVys7ynKMu9KjWlbf8Pnw1I7NiAgvgCdfFVsUeQQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Lve8JpQwVUxeFpKKEgM6sCJQPyovZRWptgs13sHRtnc8J+yZbcYZNPndityfTrHzZM9dyyktPaeVS/p1PYcwXFo3wLMzP8x87kDdIUugSYqf5QV2Sbh8b8VkJQl5MfZhApvObqp1gofdwzUWcDY0EPgSDbr8ePVAc6/XnXhk/F0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-dbe69afb431so353601276.1; Sat, 06 Jan 2024 08:57:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704560246; x=1705165046; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TUYNVys7ynKMu9KjWlbf8Pnw1I7NiAgvgCdfFVsUeQQ=; b=ThAnHT1946BhcT/ywc6H2hOie3W3KT82fBFHriRtSCbdARTZ2WZhgMTfOAqtyNjDoF WvPBM/AWLvoktVSMZi6f46H1yNOXYqQL+fymTO+m43vgiPtaKOOCOPm1ELXwOvEZjjPW 8sCQZ+8Aae2Mo7iExeyWJC2B5p47L4OsadHKHU+61MkPh7oUaN3Mw6mDRAZQQuwjED3e C2ydqTXrtRoPYz/BVmWLQouRXSdgQQtKu9BVd5xQfEtGh4ojoQURd5iWGrTXMau39+wU NDrtIbIaTlaf9/qQJ9FMlj4WIo2i4IBIgCNNKAhZRvg7RsqgXWD9IwLAKkugjG2OAVOI x1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704560246; x=1705165046; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TUYNVys7ynKMu9KjWlbf8Pnw1I7NiAgvgCdfFVsUeQQ=; b=JwyY5kqqOxpSzpgrCCuUVFpCnNTtNdHvRqBrOuImrw8G/Azce4K8Dh11/MnVZS6A9s OCyXAh4zwTNs/dmEPXGeI55xjwPt4PRof27vmyaeZgswKsEncGTwpa6uWUbxsRbnlTgb DHzVrv714p+s9rI3AP865TT8T8cFL8tDR1qq3pRSXOpp859nq0RSYa2p6cKIM81D43Gn jSez/KUQR7bdWE2zArxbLqnQByD1xnq5iCSdzF8bH6bGEISToxwdJpMCwY+L+n6vg7k0 CD21SeowVYR0/ycg8V4eQBgh0WlouvlTNT3jwRgsNm6gYpyOODYxyS//KCldL5xwsYY8 X7Tg== X-Gm-Message-State: AOJu0YwdgokOOie9eRibZFdoV9Tf5pl9pArzZybF8S5KYFdfgPL9EafJ VDYw/Rr98U/ifflxhPGajOFaqiRdwnDxQX0vKhM= X-Google-Smtp-Source: AGHT+IFGmvybr4MkPv0qvNiphBZgozq3rvxR+F2ozaEUvxdZCnPJ2rX1NnkFmyMfwnThtAqB6IRijLSFFB9oYliLeFA= X-Received: by 2002:a0d:c407:0:b0:5ef:c519:76bd with SMTP id g7-20020a0dc407000000b005efc51976bdmr813638ywd.25.1704560246117; Sat, 06 Jan 2024 08:57:26 -0800 (PST) MIME-Version: 1.0 References: <20240106151802.3356059-1-jwakely@redhat.com> In-Reply-To: <20240106151802.3356059-1-jwakely@redhat.com> From: Lewis Hyatt Date: Sat, 6 Jan 2024 11:57:14 -0500 Message-ID: Subject: Re: [PATCH v2] libstdc++: Add Unicode-aware width estimation for std::format To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jan 6, 2024 at 11:40=E2=80=AFAM Jonathan Wakely wrote: > > Here's a V2 patch which addresses the two things I mentioned: the new > Python script now generates a complete file that can just be included by > , and the full Unicode 15.1.0 grapheme cluster break > rules are supported (I think ... more testing needed for some of the > complex rules). > > -- >8 -- Thanks, by the way, for fixing the typo in gen_wcwidth.py. One thing I wanted to point out, the file contrib/unicode/README contains a list of steps to follow in order to update to a new Unicode version. There are 10 or so steps to generate everything libcpp and diagnostics care about. Do you think it's worth adding something for the new libstdc++ parts there too? I guess it may not be desirable to update them always at the same time though. -Lewis