From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 110033858CDA for ; Thu, 26 Oct 2023 16:18:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 110033858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 110033858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698337135; cv=none; b=Bl+gHkNBOdoLOWYObjzLJeSfTpqeH+QbEYpDRtulahhj+1HWpUESzjEyIe0IsPuRVkt56QFNzqhxGh/vb26bL/CrQHxFOOMJFQ3aGy/TR7owHVH3b3o/T4QoHouuqyzqw7mtzOr7FwheljWP7L6Zee1BDXZaem1yRrIEwY3eBFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698337135; c=relaxed/simple; bh=8UBcHzP3iaTTS/is4gCXDjUbRfzFS9QSSz8wMk6T6Ds=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=CePO4lC71Md76Pw2CXvZ52PSCbOaGUS0tli+5wk5g1oQtvdBCSpRpsOOSBquNroc4nrwpg96qBqa0qdxLBxVmnjrzm7w7KmkPHNbMWxrnQcUk+0TbkMj1JCnGeEnmKLnhpcwhLhiO00Q1Y4Swx7e1I952LlXCXpgexlFh4ZXPUI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b2e22a4004so693590b6e.3 for ; Thu, 26 Oct 2023 09:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698337133; x=1698941933; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8UBcHzP3iaTTS/is4gCXDjUbRfzFS9QSSz8wMk6T6Ds=; b=QAfwCK2H/xv5Rxnfg0ZWBQ2rkmKT+zVrvnkwJmKfjbpYEbyYLh/xeJ4+SC8zQxdWjp XkqU019Ess6Wqx4DuW04LwLQvQFq10BCaanCYkeuPChR2JCebXQBshtQOLcxLsVZrapr 9NItwv93uL1qRwmudCpJVT+7tUtFXdYwPxCH1FRV62tNlrQtOiqW9Bz8p2GHkItbRYpH 6mQ31ZyCHXp0cQeyHfE8RXq8j3DQShlhqIB/cZ8TIAlxUAErBsLkarqVNbfQnmUtyyQN kO+QnqUJDe3Np+68gQbvMr1wtjnpyOnUEaikbEfoJ9dIYpNomtL/vV8UJGsLc50PowY/ tpEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698337133; x=1698941933; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UBcHzP3iaTTS/is4gCXDjUbRfzFS9QSSz8wMk6T6Ds=; b=n6cBu1lhR5+/4Tm7R9jRnLaG2FXI3tf9PhfdPdVAua2frdOsIfGWLYk1s+DaDFQIyh IbXLDlAlKw0OpjIwMnGRrDbZmJCcOQ57ZQOajYzG5QtO8cuxszspPSVTWEydMQ4rLb73 zu1VJQUY83/d44fAoaSWNQHAu53Dj8lE3qbt7MghFaArHqqG5xDmJ5Avqhr+8xsxsGWN 8O7kIhHNuGcvXSwtZCVnChda0ON9iJVm8QyqHCPu8YfDunWSYrSgehn0c9hyUI7NC/MG BAShMVV6iAQIMlFDd6tNOxDqLgM4Wh/Ez0V+lAma2XE19QjSInpGVlFq3lF/iuiDLdUO YKtA== X-Gm-Message-State: AOJu0Yz4jZRBFpKTAkLhGG9mCLTpWunL9ijGQPBnsJ9LrkronaAL+6hM x1FvBgZDiWIfx9JiexldUPulO2oHYaUNGVE+yMs= X-Google-Smtp-Source: AGHT+IFq6VCw1B0PcbGaITarWIQIh97Ga9oFXfL/Bn1KRELaQg7wvfVsBjkDrV7R69xaeL1Xlrh8mLkXyVToE5Y4CHo= X-Received: by 2002:a05:6808:60e:b0:3b2:defb:e562 with SMTP id y14-20020a056808060e00b003b2defbe562mr19875759oih.45.1698337133087; Thu, 26 Oct 2023 09:18:53 -0700 (PDT) MIME-Version: 1.0 References: <20230920041202.4099349-1-lhyatt@gmail.com> In-Reply-To: From: Lewis Hyatt Date: Thu, 26 Oct 2023 12:18:41 -0400 Message-ID: Subject: Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887] To: Christophe Lyon Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3030.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 26, 2023 at 4:49=E2=80=AFAM Christophe Lyon wrote: > We have noticed that the new tests fail on aarch64 with: > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start': > .../sysdeps/aarch64/start.S:110:(.text+0x38): undefined reference to `mai= n' > > Looking at the test, I'd say it lacks a dg-do compile (to avoid > linking), but how does it work on other targets? Thanks for pointing it out. I am definitely under the impression that { dg-do compile } is the default and doesn't need to be specified, I have never seen it not be the case before... Is that just not correct? I tried it out on the cfarm (gcc185) for aarch64-redhat-linux and it works for me there too, I tried the test individually and also as part of the whole check-gcc-c++ target. I do see that there are target-dependent functions in testsuite/lib/*.exp that will change dg-do-what-default under some circumstances... but I also see in dg-pch.exp (which is the one relevant for this test g++.dg/pch/pr36887.C) that dg-do-what-default is set to compile explicitly. Note sure what the best next step is, should I just add { dg-do compile } since it's harmless in any case, or is there something else worth looking into here? I'm not sure why I couldn't reproduce the issue on the compile farm machine either, maybe you wouldn't mind please check if adding this line fixes it for you anyway? Thanks... -Lewis