From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 130463858C56 for ; Sun, 26 Jun 2022 18:16:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 130463858C56 Received: by mail-lf1-x12c.google.com with SMTP id w20so12965071lfa.11 for ; Sun, 26 Jun 2022 11:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gcMgIJIkd9etmOcuoT6Fb4yCA7gPWGxFseeImroEQs=; b=RWYXCDa6cvjIUeg5PRxfXhu+zMimj0ct1aZUCT3A1+CtCRcyt9KOeOPJYz29MNxB8x a5edhCXbLB9XzPQNP3MfB0f9fREmdv6W+rusYVWCWt8zqCj1BJVEf7F/rYWfjVx9UHRw fXhQomal9CtP/Wp+zVoxeB/L69kXlwbhCh/c/VL9s0t3ibU+spjtNQIqyW3aJ8CtnEVK p1RsadMr4TTx3dhQu5wUzCbbQHEdC/Kpk9sWdDqE6g00JzMHoRPgBuGvBvN95IGYc2XD 7tD4hCJgqV+wSkQgUIcttt3zu8LbrtqEf+SWqPiLUS3raqBHMB5/SV4ItNJptMB+sx99 ELfw== X-Gm-Message-State: AJIora/0kg/PEbhS3A5PeOUGpRBX8YyBP7uRt0zP74IrwNRo+Qq7xteC ubz08lZucsEvc309jE45VTPgS6qf/iZ8R/yoVU8= X-Google-Smtp-Source: AGRyM1sZ/hoZy7t/u2xgJtXDfunF4IKR9+x6nd+ECh3z/tjX73UeFs4P7jWiPU7YzAh041c62wk/N15Zbinl8h0Vsc0= X-Received: by 2002:a05:6512:36d3:b0:480:b12d:c7f9 with SMTP id e19-20020a05651236d300b00480b12dc7f9mr6393641lfs.113.1656267407241; Sun, 26 Jun 2022 11:16:47 -0700 (PDT) MIME-Version: 1.0 References: <20220606214957.GA58074@ldh-imac.local> <2bf3f5270abb8c42f035f33615157af8a81d2ca9.camel@redhat.com> In-Reply-To: From: Lewis Hyatt Date: Sun, 26 Jun 2022 14:16:35 -0400 Message-ID: Subject: Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0 To: Joseph Myers Cc: David Malcolm , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2022 18:16:50 -0000 On Fri, Jun 24, 2022 at 3:26 PM Joseph Myers wrote: > > On Fri, 24 Jun 2022, David Malcolm via Gcc-patches wrote: > > > > BTW, is this something simple enough I should just commit it without > > > bugging > > > the list for approval? > > > > The patch seems reasonable to me, but Joseph seems to be the expert on > > i18n-related matters. > > > > Joseph, do we have a policy on this? > > I don't think we have a policy on Unicode updates specifically, but the > general principle for updating files maintained outside GCC and copied > verbatim into the GCC sources doesn't require prior approval. > > (Note that Unicode data is also used to generate ucnid.h - data for > Unicode characters in identifiers - we should probably also include > DerivedNormalizationProps.txt and DerivedCoreProperties.txt in the > checked-in Unicode data for that purpose.) Thank you both for the feedback. I have pushed the change for wcwidth, and then I will follow up with a patch that adds these other two Unicode data files and updates contrib/unicode/README so that the procedure there will update both wcwidth and ucnid.h... and the patch will follow that procedure to update ucnid.h from Unicode 13 to Unicode 14. -Lewis