From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88860 invoked by alias); 13 Apr 2018 14:39:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 88847 invoked by uid 89); 13 Apr 2018 14:39:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:alternative X-HELO: mail-ot0-f176.google.com Received: from mail-ot0-f176.google.com (HELO mail-ot0-f176.google.com) (74.125.82.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Apr 2018 14:39:44 +0000 Received: by mail-ot0-f176.google.com with SMTP id p33-v6so10087174otp.11 for ; Fri, 13 Apr 2018 07:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oARPBaOJH9Za5HYkXjIkiN2l3SKnz/PhMjNG7XqfpZw=; b=YsxG7YUn93gwMme0l3N7KMtRbefEIB0zM6zGQ8M+j5yBuORPw0duOaRiyMesr7wtjG X4T9ZInVQN+qhtymasprmJTM+4TqEBR1e7jEcTZuQZyjmZsYRERn1lUjz6hJVsEqXjNI 4XUDL3qZ2WDeJE85mIvEnXJEFZKKY/ehSXTqQUWroHrvQzG+63/xDO77aQYAYj0eNG/q xw0xBrmfgLIpLArAq69CL3IGF6uvx6qKXS60y0FPn984n4sTiGSINqwXJ6fG/lvJcs8l 0bXX18gZBhN7LGHjVLDW9i4UQtsbY3gdXrg/QSQoXPbQebS37JLzoX6MKcqGyes6LLA/ 1eNA== X-Gm-Message-State: ALQs6tDB3pDdS9eLxA518V0yq1vqfmejioAq0fnL2VLaDmb4RAomkI5M w2v7dcqCxu67vryI13bK9pK/Ew7+d4gRiH2q9A8MLg== X-Google-Smtp-Source: AIpwx49vN19bGm92IdkLt6suoWtWA+xHeoCc/dUIodO51YlrHHBm0CRhE1e86tRJ8Ms3IUeXYQlwl43NUhhJsC3W92I= X-Received: by 2002:a9d:28c6:: with SMTP id s64-v6mr4031866ota.346.1523630383139; Fri, 13 Apr 2018 07:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20180413143421.GA30909@arm.com> In-Reply-To: <20180413143421.GA30909@arm.com> From: Sameera Deshpande Date: Fri, 13 Apr 2018 14:39:00 -0000 Message-ID: Subject: Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics To: James Greenhalgh Cc: Christophe Lyon , gcc-patches , Richard Earnshaw , nd@arm.com, sudi.das@arm.com Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00673.txt.bz2 On Fri 13 Apr, 2018, 8:04 PM James Greenhalgh, wrote: > On Fri, Apr 06, 2018 at 08:55:47PM +0100, Christophe Lyon wrote: > > Hi, > > > > 2018-04-06 12:15 GMT+02:00 Sameera Deshpande < > sameera.deshpande@linaro.org>: > > > Hi Christophe, > > > > > > Please find attached the updated patch with testcases. > > > > > > Ok for trunk? > > > > Thanks for the update. > > > > Since the new intrinsics are only available on aarch64, you want to > > prevent the tests from running on arm. > > Indeed gcc.target/aarch64/advsimd-intrinsics/ is shared between the two > targets. > > There are several examples on how to do that in that directory. > > > > I have also noticed that the tests fail at execution on aarch64_be. > > I think this is important to fix. We don't want the big-endian target to > have > failing implementations of the Neon intrinsics. What is the nature of the > failure? > > From what I can see, nothing in the patch prevents using these intrinsics > on big-endian, so either the intrinsics behaviour is wrong (we have a wrong > code bug), or the testcase expected behaviour is wrong. > > I don't think disabling the test for big-endian is the right fix. We should > either fix the intrinsics, or fix the testcase. > > Thanks, > James > > Hi James, As the tests assume the little endian order of elements while checking the results, the tests are failing for big endian targets. So, the failures are not because of intrinsic implementations, but because of the testcase. - Thanks and regards, Sameera D.