From: Teresa Johnson <tejohnson@google.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>,
Xinliang David Li <davidxl@google.com>
Subject: Re: [PATCH] Disable -fno-reorder-blocks-and-partition if no -fprofile-use to avoid unnecessary overhead
Date: Fri, 25 Sep 2015 17:23:00 -0000 [thread overview]
Message-ID: <CAAe5K+UP9w=P6q5EKRTdJ2zgXmhTZgnxYgJbQfXse7nLDNWuag@mail.gmail.com> (raw)
In-Reply-To: <87twqisaht.fsf@tassilo.jf.intel.com>
Woops, we crossed wires. I just committed this patch. Would you like
me to revert it?
Teresa
On Fri, Sep 25, 2015 at 9:57 AM, Andi Kleen <andi@firstfloor.org> wrote:
> Teresa Johnson <tejohnson@google.com> writes:
>
>> This patch unsets -freorder-blocks-and-partition when -fprofile-use
>> is not specified. Function splitting was not actually being performed
>> in that case, as probably_never_executed_bb_p does not distinguish
>> any basic blocks as being cold vs hot when there is no profile data.
>
> Actually I'm experimenting with a patch to fix that by allowing
> function splitting even without profile feed back. See PR66890
> which has the patch. I would prefer to keep and fix it.
>
> -Andi
>
>
> --
> ak@linux.intel.com -- Speaking for myself only
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
next prev parent reply other threads:[~2015-09-25 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 18:49 Teresa Johnson
2015-09-24 19:02 ` pinskia
2015-09-25 14:14 ` Bernd Schmidt
2015-09-25 14:26 ` Teresa Johnson
2015-09-25 14:34 ` Bernd Schmidt
2015-09-25 14:54 ` Jan Hubicka
2015-09-25 16:58 ` Teresa Johnson
2015-09-25 16:58 ` Andi Kleen
2015-09-25 17:23 ` Teresa Johnson [this message]
2015-09-25 17:36 ` Jeff Law
2015-09-25 19:13 ` Andi Kleen
2015-09-27 0:55 ` Bernhard Reutner-Fischer
2015-09-27 10:24 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAe5K+UP9w=P6q5EKRTdJ2zgXmhTZgnxYgJbQfXse7nLDNWuag@mail.gmail.com' \
--to=tejohnson@google.com \
--cc=andi@firstfloor.org \
--cc=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).