From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7186 invoked by alias); 2 Dec 2015 20:46:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7169 invoked by uid 89); 2 Dec 2015 20:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-io0-f169.google.com Received: from mail-io0-f169.google.com (HELO mail-io0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 02 Dec 2015 20:46:39 +0000 Received: by ioir85 with SMTP id r85so59308359ioi.1 for ; Wed, 02 Dec 2015 12:46:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=aE8viSkAE3Rm8R7okwYsvkwahR+mxHVFh1fUSoDbJkI=; b=bYAG3Cpklgl4kqCk1OhLbnx0DnziGD+xAJErhpmXIrFCBWWumDTtcQuB5f6PZD7eKu qkl7C7t69ve2qFHNt9TEekV0vz334QMTVHbj4WCAmqDAvyP/rFL6vADoI7zGod9WvnTk XwXUoRoRAn3fIChHwJMD6TbFqLApm2IfvfTaAYTiogoL6Z1VADo1Q7KZkEre6Ox1zh3z tELAUWfG0hzkmAGmrQOCLWLXL78eIduoM7vSXZ0GvYwIK8eB+ZkviU5B8Y0vpAXMxeVc wIgFBr+wNNsOSrqpO5ESVPoIMH+RvLQ4HjIzgRnZt8f9LxX1UohcYSJXAYFFY2uIR5tk zZ/g== X-Gm-Message-State: ALoCoQk5Hy+4WvSjbILtRojYGC4Jmv7On4A8Ry1e1zWVnY8QHvEFoyqtBAsrojHHI61VzMwUgw5O MIME-Version: 1.0 X-Received: by 10.107.138.147 with SMTP id c19mr6586689ioj.82.1449089197530; Wed, 02 Dec 2015 12:46:37 -0800 (PST) Received: by 10.107.5.69 with HTTP; Wed, 2 Dec 2015 12:46:37 -0800 (PST) Date: Wed, 02 Dec 2015 20:46:00 -0000 Message-ID: Subject: [GOOGLE] Remove overly-aggressive LIPO assert From: Teresa Johnson To: "gcc-patches@gcc.gnu.org" , Xinliang David Li Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00366.txt.bz2 Remove an assert that was overly-strict and already partially redundant with an immediately prior assert. In this case we had a hidden visibility function clone that was created after the LIPO link due to indirect call promotion. It is a cgraph_is_aux_decl_external node. Fixes failures and passes regression tests. Ok for Google branch? 2015-12-02 Teresa Johnson Google ref b/25925223. * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict assert. Index: l-ipo.c =================================================================== --- l-ipo.c (revision 231131) +++ l-ipo.c (working copy) @@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d gcc_assert (DECL_EXTERNAL (decl) || cgraph_is_aux_decl_external (n) || DECL_VIRTUAL_P (decl)); - gcc_assert (/* This is the case for explicit extern instantiation, - when cgraph node is not created before link. */ - DECL_EXTERNAL (decl)); cgraph_link_node (n); return n; } -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413