From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3463 invoked by alias); 6 Nov 2014 17:59:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3430 invoked by uid 89); 6 Nov 2014 17:59:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f172.google.com Received: from mail-qc0-f172.google.com (HELO mail-qc0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 06 Nov 2014 17:59:32 +0000 Received: by mail-qc0-f172.google.com with SMTP id i17so1216774qcy.31 for ; Thu, 06 Nov 2014 09:59:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4MJ1nN12MzoZZ9BASmhr0aBk5/NFsmF4stwj6XXbTso=; b=cx7St08snB+JuoS9RDpWZLDQMFmNfxwjTr08JGcQ2AjId0M+Cc3SO0Q39EeDv7jWLd 8EQLeRbUa6ieX9lot+SdxjZn+inZCxEuN1DOtBKo3wYUDxuzNWoYBPb8Rkfhq2zBBbpH gc+YmJflAbSVl03g5lZxLZ3FtKwO5Mb9hlV9nbhh1Z5ShZMOV6TxA/vyiDef8mT9qIbs f94CkbdYYR1C2p90m++pcMCoxPbG/WA5yh2KAszoF7OupCRJ8BicgJwzB+PqXqyJMo3N zjQLdd80cCCWV4nU7pUGdFmTI3jXckF/klexW3H3YubaoPZxQZPDY9gtXYvIk+mFKXif E6dw== X-Gm-Message-State: ALoCoQn2eNqJJIUYo1IRCu3oqBAILyWkOg0mmsrHjmvtyusdE+hpTExbTE/UgckZsC/AIq7G/0Xq MIME-Version: 1.0 X-Received: by 10.224.25.208 with SMTP id a16mr8817571qac.41.1415296770499; Thu, 06 Nov 2014 09:59:30 -0800 (PST) Received: by 10.229.40.72 with HTTP; Thu, 6 Nov 2014 09:59:30 -0800 (PST) In-Reply-To: <545BB5B5.90008@arm.com> References: <5450B2C0.6040807@arm.com> <54579F5B.9070700@arm.com> <54594C46.6080704@redhat.com> <545B8F35.9070603@arm.com> <545BB5B5.90008@arm.com> Date: Thu, 06 Nov 2014 17:59:00 -0000 Message-ID: Subject: Re: [PATCH]Partially fix PR61529, bound basic block frequency From: Teresa Johnson To: Renlin Li Cc: Jeff Law , Dehao Chen , "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , "su@cs.ucdavis.edu" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00530.txt.bz2 Thanks for fixing the test case. Can you also add the comment I suggested to the source change? > Please add a comment that this is needed due to insane incoming frequencies. Thanks, Teresa On Thu, Nov 6, 2014 at 9:53 AM, Renlin Li wrote: > Hi Teresa, > > Thank you for the suggestion, updated! > >> Please add a comment that this is needed due to insane incoming >> frequencies. >> >> The 'b' variable is uninitialized. Also, 'd' and 'a' may end up >> uninitialized depending on the initial value of 'b'. Please initialize >> these. >> > > Test case has been added. With the patch, both x86_64-unknown-linux-gnu and > aarch64-none-elf compile the test case successfully. > > x86_64-unknown-linux-gnu bootstrap and regression test have been done, no > new issue. > aarch64-none-elf toolchain has been test on the model. No new regression. > > gcc/ChangeLog: > > 2014-11-06 Renlin Li > PR middle-end/61529 > * tree-ssa-threadupdate.c (compute_path_counts): Bound path_in_freq. > This is needed due to insane incoming frequencies. > > gcc/testsuite/ChangeLog: > > 2014-11-06 Renlin Li > PR middle-end/61529 > * gcc.dg/pr61529.c: New. -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413