From: Teresa Johnson <tejohnson@google.com>
To: Jeff Law <law@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>, David Li <davidxl@google.com>
Subject: Re: [PATCH] Redesign jump threading profile updates
Date: Tue, 27 May 2014 14:11:00 -0000 [thread overview]
Message-ID: <CAAe5K+WU5iutzdZxvt9Rq8mv1wse=7mKMXW8N2+BMN+ouDSJqw@mail.gmail.com> (raw)
In-Reply-To: <CAAe5K+UrMtD=6tQYxNYhJ1k2owMbBRFKf87d75bFgoNo9kowGQ@mail.gmail.com>
On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson <tejohnson@google.com> wrote:
> On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law <law@redhat.com> wrote:
>> On 03/26/14 17:44, Teresa Johnson wrote:
>>>
>>> Recently I discovered that the profile updates being performed by jump
>>> threading were incorrect in many cases, particularly in the case where
>>> the threading path contains a joiner. Some of the duplicated
>>> blocks/edges were not getting any counts, leading to incorrect
>>> function splitting and other downstream optimizations, and there were
>>> other insanities as well. After making a few attempts to fix the
>>> handling I ended up completely redesigning the profile update code,
>>> removing a few places throughout the code where it was attempting to
>>> do some updates.
>>
>> The profile updates in that code is a mess. It's never really been looked
>> at in any systematic way, what's there is ad-hoc and usually in response to
>> someone mentioning the profile data was incorrectly updated. As we rely
>> more and more on that data the ad-hoc updating is going to cause us more and
>> more pain.
>>
>> So any work in this space is going to be greatly appreciated.
>>
>> I'll have to look at this in some detail. But I wanted you to know I was
>> aware of the work and it's in my queue.
>
> Great, thanks for the update! I realize that it is not a trivial
> change so it would take some time to get through. Hopefully it should
> address the ongoing profile fixup issues.
> Teresa
Ping.
Thanks,
Teresa
>
>>
>> Thanks!
>>
>> jeff
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
next prev parent reply other threads:[~2014-05-27 14:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 23:57 Teresa Johnson
2014-04-17 5:58 ` Jeff Law
2014-04-17 13:46 ` Teresa Johnson
2014-05-27 14:11 ` Teresa Johnson [this message]
2014-07-07 21:22 ` Teresa Johnson
2014-07-07 21:24 ` Jeff Law
2014-07-23 13:47 ` Jeff Law
2014-07-23 21:52 ` Teresa Johnson
2014-08-02 5:10 ` Teresa Johnson
2014-08-02 5:16 ` Andrew Pinski
2014-09-29 14:20 ` Teresa Johnson
2014-09-30 4:33 ` Jeff Law
2014-09-30 18:20 ` Teresa Johnson
2014-10-01 7:03 ` Christophe Lyon
2014-10-01 13:21 ` Teresa Johnson
2014-10-01 14:05 ` Teresa Johnson
2014-10-01 15:23 ` Sebastian Pop
2014-10-01 15:25 ` Christophe Lyon
2014-10-01 15:29 ` Teresa Johnson
2014-10-01 16:20 ` H.J. Lu
2014-10-01 16:23 ` Teresa Johnson
2014-10-01 20:05 ` Teresa Johnson
2014-10-01 22:46 ` Steve Ellcey
2014-10-02 5:02 ` Teresa Johnson
2014-10-02 15:44 ` Teresa Johnson
2014-10-02 15:45 ` Steve Ellcey
2014-10-02 16:01 ` Teresa Johnson
2014-10-01 23:09 ` Jan Hubicka
2014-10-02 5:07 ` Teresa Johnson
2014-10-02 18:34 ` Jeff Law
2014-10-28 16:01 ` Renlin Li
2014-10-01 15:36 ` Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAe5K+WU5iutzdZxvt9Rq8mv1wse=7mKMXW8N2+BMN+ouDSJqw@mail.gmail.com' \
--to=tejohnson@google.com \
--cc=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).