* [GOOGLE] Remove overly-aggressive LIPO assert
@ 2015-12-02 20:46 Teresa Johnson
2015-12-04 19:29 ` Teresa Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Teresa Johnson @ 2015-12-02 20:46 UTC (permalink / raw)
To: gcc-patches, Xinliang David Li
Remove an assert that was overly-strict and already partially redundant
with an immediately prior assert. In this case we had a hidden visibility
function clone that was created after the LIPO link due to indirect call
promotion. It is a cgraph_is_aux_decl_external node.
Fixes failures and passes regression tests. Ok for Google branch?
2015-12-02 Teresa Johnson <tejohnson@google.com>
Google ref b/25925223.
* l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict
assert.
Index: l-ipo.c
===================================================================
--- l-ipo.c (revision 231131)
+++ l-ipo.c (working copy)
@@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d
gcc_assert (DECL_EXTERNAL (decl)
|| cgraph_is_aux_decl_external (n)
|| DECL_VIRTUAL_P (decl));
- gcc_assert (/* This is the case for explicit extern
instantiation,
- when cgraph node is not created before link. */
- DECL_EXTERNAL (decl));
cgraph_link_node (n);
return n;
}
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GOOGLE] Remove overly-aggressive LIPO assert
2015-12-02 20:46 [GOOGLE] Remove overly-aggressive LIPO assert Teresa Johnson
@ 2015-12-04 19:29 ` Teresa Johnson
2015-12-08 19:45 ` Xinliang David Li
0 siblings, 1 reply; 3+ messages in thread
From: Teresa Johnson @ 2015-12-04 19:29 UTC (permalink / raw)
To: gcc-patches, Xinliang David Li
Ping.
Thanks, Teresa
On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson <tejohnson@google.com> wrote:
> Remove an assert that was overly-strict and already partially redundant
> with an immediately prior assert. In this case we had a hidden visibility
> function clone that was created after the LIPO link due to indirect call
> promotion. It is a cgraph_is_aux_decl_external node.
>
> Fixes failures and passes regression tests. Ok for Google branch?
>
> 2015-12-02 Teresa Johnson <tejohnson@google.com>
>
> Google ref b/25925223.
> * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict
> assert.
>
> Index: l-ipo.c
> ===================================================================
> --- l-ipo.c (revision 231131)
> +++ l-ipo.c (working copy)
> @@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d
> gcc_assert (DECL_EXTERNAL (decl)
> || cgraph_is_aux_decl_external (n)
> || DECL_VIRTUAL_P (decl));
> - gcc_assert (/* This is the case for explicit extern
> instantiation,
> - when cgraph node is not created before link. */
> - DECL_EXTERNAL (decl));
> cgraph_link_node (n);
> return n;
> }
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GOOGLE] Remove overly-aggressive LIPO assert
2015-12-04 19:29 ` Teresa Johnson
@ 2015-12-08 19:45 ` Xinliang David Li
0 siblings, 0 replies; 3+ messages in thread
From: Xinliang David Li @ 2015-12-08 19:45 UTC (permalink / raw)
To: Teresa Johnson; +Cc: gcc-patches
ok.
David
On Fri, Dec 4, 2015 at 11:29 AM, Teresa Johnson <tejohnson@google.com> wrote:
> Ping.
> Thanks, Teresa
>
> On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson <tejohnson@google.com> wrote:
>> Remove an assert that was overly-strict and already partially redundant
>> with an immediately prior assert. In this case we had a hidden visibility
>> function clone that was created after the LIPO link due to indirect call
>> promotion. It is a cgraph_is_aux_decl_external node.
>>
>> Fixes failures and passes regression tests. Ok for Google branch?
>>
>> 2015-12-02 Teresa Johnson <tejohnson@google.com>
>>
>> Google ref b/25925223.
>> * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict
>> assert.
>>
>> Index: l-ipo.c
>> ===================================================================
>> --- l-ipo.c (revision 231131)
>> +++ l-ipo.c (working copy)
>> @@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d
>> gcc_assert (DECL_EXTERNAL (decl)
>> || cgraph_is_aux_decl_external (n)
>> || DECL_VIRTUAL_P (decl));
>> - gcc_assert (/* This is the case for explicit extern
>> instantiation,
>> - when cgraph node is not created before link. */
>> - DECL_EXTERNAL (decl));
>> cgraph_link_node (n);
>> return n;
>> }
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-08 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-02 20:46 [GOOGLE] Remove overly-aggressive LIPO assert Teresa Johnson
2015-12-04 19:29 ` Teresa Johnson
2015-12-08 19:45 ` Xinliang David Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).