From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5125 invoked by alias); 7 Jul 2014 21:22:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5056 invoked by uid 89); 7 Jul 2014 21:22:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f50.google.com Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 21:22:36 +0000 Received: by mail-qg0-f50.google.com with SMTP id j5so4246473qga.23 for ; Mon, 07 Jul 2014 14:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=TaGhvJmPbxP+jGw+4chdIY2ZEtB4/UxuCCxgqXUj9vg=; b=fHmwMHsmopNo8zCW+MYt7nnyGAuG35Dpt0QForW3uA0oN7I5WXTTTW7M1HiaQ3Ja1+ e50n+szr4EhX9bZXH0GMOAqp3iB3N4WioGA69DUsrceK0tVAD9wExZAKhwWhYaON0P7V Ec1FXV32YUEdQV66W3gGE5v/0i+M0+KGiK5lcYgJc8HTjC1mkz9VMxErvYE9xmRHL/2/ FlcpRxjIIj5EgczsxKALTI0NkluaafJAboJ7FGi19euXh+IQw5UbqLfwaaKH8UnbTKhd YA2yTtuavaRQDDYaWk0WQbK4N8XN9qx/V9vnV4dX/qHkcoJMU2uM/gfqV0w5WK7IYjAW Kq+A== X-Gm-Message-State: ALoCoQmqdfZsFUgR9B0rCePN6YAyEntGVeg/9538eMWXgzuiYyxOLbk5X71ayqsc7iRZ/oZzWkgU MIME-Version: 1.0 X-Received: by 10.224.98.145 with SMTP id q17mr51737766qan.97.1404768154281; Mon, 07 Jul 2014 14:22:34 -0700 (PDT) Received: by 10.229.156.5 with HTTP; Mon, 7 Jul 2014 14:22:34 -0700 (PDT) In-Reply-To: References: <534F6901.7090700@redhat.com> Date: Mon, 07 Jul 2014 21:22:00 -0000 Message-ID: Subject: Re: [PATCH] Redesign jump threading profile updates From: Teresa Johnson To: Jeff Law Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka , David Li Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00503.txt.bz2 Ping. Jeff, any update on when you can look at this? Thanks, Teresa On Tue, May 27, 2014 at 7:10 AM, Teresa Johnson wrote: > On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson wrote: >> On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote: >>> On 03/26/14 17:44, Teresa Johnson wrote: >>>> >>>> Recently I discovered that the profile updates being performed by jump >>>> threading were incorrect in many cases, particularly in the case where >>>> the threading path contains a joiner. Some of the duplicated >>>> blocks/edges were not getting any counts, leading to incorrect >>>> function splitting and other downstream optimizations, and there were >>>> other insanities as well. After making a few attempts to fix the >>>> handling I ended up completely redesigning the profile update code, >>>> removing a few places throughout the code where it was attempting to >>>> do some updates. >>> >>> The profile updates in that code is a mess. It's never really been looked >>> at in any systematic way, what's there is ad-hoc and usually in response to >>> someone mentioning the profile data was incorrectly updated. As we rely >>> more and more on that data the ad-hoc updating is going to cause us more and >>> more pain. >>> >>> So any work in this space is going to be greatly appreciated. >>> >>> I'll have to look at this in some detail. But I wanted you to know I was >>> aware of the work and it's in my queue. >> >> Great, thanks for the update! I realize that it is not a trivial >> change so it would take some time to get through. Hopefully it should >> address the ongoing profile fixup issues. >> Teresa > > Ping. > Thanks, > Teresa > >> >>> >>> Thanks! >>> >>> jeff >> >> >> >> -- >> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413 > > > > -- > Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413 -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413