public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Add missing -fdump-* options
@ 2014-05-09 15:54 Teresa Johnson
  2014-05-13  8:39 ` Richard Biener
  0 siblings, 1 reply; 7+ messages in thread
From: Teresa Johnson @ 2014-05-09 15:54 UTC (permalink / raw)
  To: gcc-patches; +Cc: David Li

I discovered that the support for the documented -fdump-* options
"optimized", "missed", "note" and "optall" was missing. Added that and
fixed a minor typo in the documentation.

Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?

Thanks,
Teresa

2014-05-09  Teresa Johnson  <tejohnson@google.com>

        * doc/invoke.texi: Fix typo.
        * dumpfile.c: Add support for documented -fdump-* options
        optimized/missed/note/optall.

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi     (revision 210157)
+++ doc/invoke.texi     (working copy)
@@ -6278,7 +6278,7 @@ passes).
 @item missed
 Enable showing missed optimization information (only available in certain
 passes).
-@item notes
+@item note
 Enable other detailed optimization information (only available in
 certain passes).
 @item =@var{filename}
Index: dumpfile.c
===================================================================
--- dumpfile.c  (revision 210157)
+++ dumpfile.c  (working copy)
@@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
   {"nouid", TDF_NOUID},
   {"enumerate_locals", TDF_ENUMERATE_LOCALS},
   {"scev", TDF_SCEV},
+  {"optimized", MSG_OPTIMIZED_LOCATIONS},
+  {"missed", MSG_MISSED_OPTIMIZATION},
+  {"note", MSG_NOTE},
+  {"optall", MSG_ALL},
   {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
            | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
            | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},


-- 
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-05-09 15:54 [PATCH] Add missing -fdump-* options Teresa Johnson
@ 2014-05-13  8:39 ` Richard Biener
  2014-05-13 13:18   ` Teresa Johnson
  2014-05-13 15:19   ` Xinliang David Li
  0 siblings, 2 replies; 7+ messages in thread
From: Richard Biener @ 2014-05-13  8:39 UTC (permalink / raw)
  To: Teresa Johnson; +Cc: gcc-patches, David Li

On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
> I discovered that the support for the documented -fdump-* options
> "optimized", "missed", "note" and "optall" was missing. Added that and
> fixed a minor typo in the documentation.
>
> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?

I'm not sure they were intented for user-consumption.  ISTR they
are just an implementation detail exposed by -fopt-info-X (which is
where they are documented).

The typo fix is ok, also adding a comment before the dump flags
definition to the above fact.

David, do I remember correctly?

Thanks,
Richard.

> Thanks,
> Teresa
>
> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>
>         * doc/invoke.texi: Fix typo.
>         * dumpfile.c: Add support for documented -fdump-* options
>         optimized/missed/note/optall.
>
> Index: doc/invoke.texi
> ===================================================================
> --- doc/invoke.texi     (revision 210157)
> +++ doc/invoke.texi     (working copy)
> @@ -6278,7 +6278,7 @@ passes).
>  @item missed
>  Enable showing missed optimization information (only available in certain
>  passes).
> -@item notes
> +@item note
>  Enable other detailed optimization information (only available in
>  certain passes).
>  @item =@var{filename}
> Index: dumpfile.c
> ===================================================================
> --- dumpfile.c  (revision 210157)
> +++ dumpfile.c  (working copy)
> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>    {"nouid", TDF_NOUID},
>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>    {"scev", TDF_SCEV},
> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
> +  {"missed", MSG_MISSED_OPTIMIZATION},
> +  {"note", MSG_NOTE},
> +  {"optall", MSG_ALL},
>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-05-13  8:39 ` Richard Biener
@ 2014-05-13 13:18   ` Teresa Johnson
  2014-05-13 15:19   ` Xinliang David Li
  1 sibling, 0 replies; 7+ messages in thread
From: Teresa Johnson @ 2014-05-13 13:18 UTC (permalink / raw)
  To: Richard Biener; +Cc: gcc-patches, David Li

On Tue, May 13, 2014 at 1:39 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
>> I discovered that the support for the documented -fdump-* options
>> "optimized", "missed", "note" and "optall" was missing. Added that and
>> fixed a minor typo in the documentation.
>>
>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>
> I'm not sure they were intented for user-consumption.  ISTR they
> are just an implementation detail exposed by -fopt-info-X (which is
> where they are documented).

I'm not sure what was intended originally, but they are documented as
sub options both for -fopt-info-X and for -fdump-tree-X. The typo that
I fixed was in the -fdump-tree-X option description in fact. Since
they were documented, which I noticed when I was doing something where
I wanted to be able to get these in the dump, I added the
implementation.

Note that because of the way the -fdump-tree-all flag is setup (by
taking the NOT of a few flags that are not wanted in the 'all' dump),
you already get these MSG_* flags enabled in dumps when you specify
-fdump-tree-all, and it seems like it therefore makes sense to be able
to specify getting just those by adding the documented support.

Teresa

>
> The typo fix is ok, also adding a comment before the dump flags
> definition to the above fact.
>
> David, do I remember correctly?
>
> Thanks,
> Richard.
>
>> Thanks,
>> Teresa
>>
>> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>>
>>         * doc/invoke.texi: Fix typo.
>>         * dumpfile.c: Add support for documented -fdump-* options
>>         optimized/missed/note/optall.
>>
>> Index: doc/invoke.texi
>> ===================================================================
>> --- doc/invoke.texi     (revision 210157)
>> +++ doc/invoke.texi     (working copy)
>> @@ -6278,7 +6278,7 @@ passes).
>>  @item missed
>>  Enable showing missed optimization information (only available in certain
>>  passes).
>> -@item notes
>> +@item note
>>  Enable other detailed optimization information (only available in
>>  certain passes).
>>  @item =@var{filename}
>> Index: dumpfile.c
>> ===================================================================
>> --- dumpfile.c  (revision 210157)
>> +++ dumpfile.c  (working copy)
>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>    {"nouid", TDF_NOUID},
>>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>    {"scev", TDF_SCEV},
>> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
>> +  {"missed", MSG_MISSED_OPTIMIZATION},
>> +  {"note", MSG_NOTE},
>> +  {"optall", MSG_ALL},
>>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413



-- 
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-05-13  8:39 ` Richard Biener
  2014-05-13 13:18   ` Teresa Johnson
@ 2014-05-13 15:19   ` Xinliang David Li
  2014-06-25 14:22     ` Teresa Johnson
  1 sibling, 1 reply; 7+ messages in thread
From: Xinliang David Li @ 2014-05-13 15:19 UTC (permalink / raw)
  To: Richard Biener; +Cc: Teresa Johnson, gcc-patches

On Tue, May 13, 2014 at 1:39 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
>> I discovered that the support for the documented -fdump-* options
>> "optimized", "missed", "note" and "optall" was missing. Added that and
>> fixed a minor typo in the documentation.
>>
>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>
> I'm not sure they were intented for user-consumption.  ISTR they
> are just an implementation detail exposed by -fopt-info-X (which is
> where they are documented).
>
> The typo fix is ok, also adding a comment before the dump flags
> definition to the above fact.
>
> David, do I remember correctly?

I remember we talked about content filtering dump flags. Things like

-fdump-xxx-ir  <-- dump IR only
-fdump-xxx-transformation <-- optimization note
-fdump-xxx-debug <-- other debug traces

Other than that, now I think 'details' and 'all' seem redundant.
'verbose' flag/modifier can achieve the same effect depending on the
context.

-fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as
vops, lineno, etc
-fdump-xxx-transforamtion-verbose <-- dump transformations + missed
optimizations + notes
-fdump-xxx-debug-verbose <-- turn on detailed trace.

thanks,

David


>
> Thanks,
> Richard.
>
>> Thanks,
>> Teresa
>>
>> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>>
>>         * doc/invoke.texi: Fix typo.
>>         * dumpfile.c: Add support for documented -fdump-* options
>>         optimized/missed/note/optall.
>>
>> Index: doc/invoke.texi
>> ===================================================================
>> --- doc/invoke.texi     (revision 210157)
>> +++ doc/invoke.texi     (working copy)
>> @@ -6278,7 +6278,7 @@ passes).
>>  @item missed
>>  Enable showing missed optimization information (only available in certain
>>  passes).
>> -@item notes
>> +@item note
>>  Enable other detailed optimization information (only available in
>>  certain passes).
>>  @item =@var{filename}
>> Index: dumpfile.c
>> ===================================================================
>> --- dumpfile.c  (revision 210157)
>> +++ dumpfile.c  (working copy)
>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>    {"nouid", TDF_NOUID},
>>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>    {"scev", TDF_SCEV},
>> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
>> +  {"missed", MSG_MISSED_OPTIMIZATION},
>> +  {"note", MSG_NOTE},
>> +  {"optall", MSG_ALL},
>>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-05-13 15:19   ` Xinliang David Li
@ 2014-06-25 14:22     ` Teresa Johnson
  2014-06-26  7:40       ` Richard Biener
  0 siblings, 1 reply; 7+ messages in thread
From: Teresa Johnson @ 2014-06-25 14:22 UTC (permalink / raw)
  To: Xinliang David Li; +Cc: Richard Biener, gcc-patches

On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li <davidxl@google.com> wrote:
> On Tue, May 13, 2014 at 1:39 AM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
>>> I discovered that the support for the documented -fdump-* options
>>> "optimized", "missed", "note" and "optall" was missing. Added that and
>>> fixed a minor typo in the documentation.
>>>
>>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>>
>> I'm not sure they were intented for user-consumption.  ISTR they
>> are just an implementation detail exposed by -fopt-info-X (which is
>> where they are documented).
>>
>> The typo fix is ok, also adding a comment before the dump flags
>> definition to the above fact.
>>
>> David, do I remember correctly?
>
> I remember we talked about content filtering dump flags. Things like
>
> -fdump-xxx-ir  <-- dump IR only
> -fdump-xxx-transformation <-- optimization note
> -fdump-xxx-debug <-- other debug traces
>
> Other than that, now I think 'details' and 'all' seem redundant.
> 'verbose' flag/modifier can achieve the same effect depending on the
> context.
>
> -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as
> vops, lineno, etc
> -fdump-xxx-transforamtion-verbose <-- dump transformations + missed
> optimizations + notes
> -fdump-xxx-debug-verbose <-- turn on detailed trace.

The above proposal seems fine to me as a longer-term direction, but
also seems somewhat orthogonal to the issue my patch is trying to
solve in the short term, namely inconsistent documentation and
behavior:

1) "optimized", "missed", "note" and "optall" are documented as being
sub-options for -fdump-tree-* in doc/invoke.texi, but not implemented.
2) "optimized", "missed", "note" and "optall" are however enabled via
-fdump-tree-all

Could we at least fix these issues in the short term, as it doesn't
affect the documented behavior (but rather adds the documented
behavior)?

Thanks,
Teresa

>
> thanks,
>
> David
>
>
>>
>> Thanks,
>> Richard.
>>
>>> Thanks,
>>> Teresa
>>>
>>> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>>>
>>>         * doc/invoke.texi: Fix typo.
>>>         * dumpfile.c: Add support for documented -fdump-* options
>>>         optimized/missed/note/optall.
>>>
>>> Index: doc/invoke.texi
>>> ===================================================================
>>> --- doc/invoke.texi     (revision 210157)
>>> +++ doc/invoke.texi     (working copy)
>>> @@ -6278,7 +6278,7 @@ passes).
>>>  @item missed
>>>  Enable showing missed optimization information (only available in certain
>>>  passes).
>>> -@item notes
>>> +@item note
>>>  Enable other detailed optimization information (only available in
>>>  certain passes).
>>>  @item =@var{filename}
>>> Index: dumpfile.c
>>> ===================================================================
>>> --- dumpfile.c  (revision 210157)
>>> +++ dumpfile.c  (working copy)
>>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>>    {"nouid", TDF_NOUID},
>>>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>>    {"scev", TDF_SCEV},
>>> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
>>> +  {"missed", MSG_MISSED_OPTIMIZATION},
>>> +  {"note", MSG_NOTE},
>>> +  {"optall", MSG_ALL},
>>>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>>>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>>>
>>>
>>> --
>>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413



-- 
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-06-25 14:22     ` Teresa Johnson
@ 2014-06-26  7:40       ` Richard Biener
  2014-06-26 17:46         ` Teresa Johnson
  0 siblings, 1 reply; 7+ messages in thread
From: Richard Biener @ 2014-06-26  7:40 UTC (permalink / raw)
  To: Teresa Johnson; +Cc: Xinliang David Li, gcc-patches

On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson <tejohnson@google.com> wrote:
> On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li <davidxl@google.com> wrote:
>> On Tue, May 13, 2014 at 1:39 AM, Richard Biener
>> <richard.guenther@gmail.com> wrote:
>>> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
>>>> I discovered that the support for the documented -fdump-* options
>>>> "optimized", "missed", "note" and "optall" was missing. Added that and
>>>> fixed a minor typo in the documentation.
>>>>
>>>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>>>
>>> I'm not sure they were intented for user-consumption.  ISTR they
>>> are just an implementation detail exposed by -fopt-info-X (which is
>>> where they are documented).
>>>
>>> The typo fix is ok, also adding a comment before the dump flags
>>> definition to the above fact.
>>>
>>> David, do I remember correctly?
>>
>> I remember we talked about content filtering dump flags. Things like
>>
>> -fdump-xxx-ir  <-- dump IR only
>> -fdump-xxx-transformation <-- optimization note
>> -fdump-xxx-debug <-- other debug traces
>>
>> Other than that, now I think 'details' and 'all' seem redundant.
>> 'verbose' flag/modifier can achieve the same effect depending on the
>> context.
>>
>> -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as
>> vops, lineno, etc
>> -fdump-xxx-transforamtion-verbose <-- dump transformations + missed
>> optimizations + notes
>> -fdump-xxx-debug-verbose <-- turn on detailed trace.
>
> The above proposal seems fine to me as a longer-term direction, but
> also seems somewhat orthogonal to the issue my patch is trying to
> solve in the short term, namely inconsistent documentation and
> behavior:
>
> 1) "optimized", "missed", "note" and "optall" are documented as being
> sub-options for -fdump-tree-* in doc/invoke.texi, but not implemented.
> 2) "optimized", "missed", "note" and "optall" are however enabled via
> -fdump-tree-all
>
> Could we at least fix these issues in the short term, as it doesn't
> affect the documented behavior (but rather adds the documented
> behavior)?

Sure.

Richard.

> Thanks,
> Teresa
>
>>
>> thanks,
>>
>> David
>>
>>
>>>
>>> Thanks,
>>> Richard.
>>>
>>>> Thanks,
>>>> Teresa
>>>>
>>>> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>>>>
>>>>         * doc/invoke.texi: Fix typo.
>>>>         * dumpfile.c: Add support for documented -fdump-* options
>>>>         optimized/missed/note/optall.
>>>>
>>>> Index: doc/invoke.texi
>>>> ===================================================================
>>>> --- doc/invoke.texi     (revision 210157)
>>>> +++ doc/invoke.texi     (working copy)
>>>> @@ -6278,7 +6278,7 @@ passes).
>>>>  @item missed
>>>>  Enable showing missed optimization information (only available in certain
>>>>  passes).
>>>> -@item notes
>>>> +@item note
>>>>  Enable other detailed optimization information (only available in
>>>>  certain passes).
>>>>  @item =@var{filename}
>>>> Index: dumpfile.c
>>>> ===================================================================
>>>> --- dumpfile.c  (revision 210157)
>>>> +++ dumpfile.c  (working copy)
>>>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>>>    {"nouid", TDF_NOUID},
>>>>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>>>    {"scev", TDF_SCEV},
>>>> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
>>>> +  {"missed", MSG_MISSED_OPTIMIZATION},
>>>> +  {"note", MSG_NOTE},
>>>> +  {"optall", MSG_ALL},
>>>>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>>>>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>>>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>>>>
>>>>
>>>> --
>>>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add missing -fdump-* options
  2014-06-26  7:40       ` Richard Biener
@ 2014-06-26 17:46         ` Teresa Johnson
  0 siblings, 0 replies; 7+ messages in thread
From: Teresa Johnson @ 2014-06-26 17:46 UTC (permalink / raw)
  To: Richard Biener; +Cc: Xinliang David Li, gcc-patches

On Thu, Jun 26, 2014 at 12:40 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson <tejohnson@google.com> wrote:
>> On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li <davidxl@google.com> wrote:
>>> On Tue, May 13, 2014 at 1:39 AM, Richard Biener
>>> <richard.guenther@gmail.com> wrote:
>>>> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohnson@google.com> wrote:
>>>>> I discovered that the support for the documented -fdump-* options
>>>>> "optimized", "missed", "note" and "optall" was missing. Added that and
>>>>> fixed a minor typo in the documentation.
>>>>>
>>>>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>>>>
>>>> I'm not sure they were intented for user-consumption.  ISTR they
>>>> are just an implementation detail exposed by -fopt-info-X (which is
>>>> where they are documented).
>>>>
>>>> The typo fix is ok, also adding a comment before the dump flags
>>>> definition to the above fact.
>>>>
>>>> David, do I remember correctly?
>>>
>>> I remember we talked about content filtering dump flags. Things like
>>>
>>> -fdump-xxx-ir  <-- dump IR only
>>> -fdump-xxx-transformation <-- optimization note
>>> -fdump-xxx-debug <-- other debug traces
>>>
>>> Other than that, now I think 'details' and 'all' seem redundant.
>>> 'verbose' flag/modifier can achieve the same effect depending on the
>>> context.
>>>
>>> -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as
>>> vops, lineno, etc
>>> -fdump-xxx-transforamtion-verbose <-- dump transformations + missed
>>> optimizations + notes
>>> -fdump-xxx-debug-verbose <-- turn on detailed trace.
>>
>> The above proposal seems fine to me as a longer-term direction, but
>> also seems somewhat orthogonal to the issue my patch is trying to
>> solve in the short term, namely inconsistent documentation and
>> behavior:
>>
>> 1) "optimized", "missed", "note" and "optall" are documented as being
>> sub-options for -fdump-tree-* in doc/invoke.texi, but not implemented.
>> 2) "optimized", "missed", "note" and "optall" are however enabled via
>> -fdump-tree-all
>>
>> Could we at least fix these issues in the short term, as it doesn't
>> affect the documented behavior (but rather adds the documented
>> behavior)?
>
> Sure.
>
> Richard.

Thanks, retested and committed as r212040.
Teresa

>
>> Thanks,
>> Teresa
>>
>>>
>>> thanks,
>>>
>>> David
>>>
>>>
>>>>
>>>> Thanks,
>>>> Richard.
>>>>
>>>>> Thanks,
>>>>> Teresa
>>>>>
>>>>> 2014-05-09  Teresa Johnson  <tejohnson@google.com>
>>>>>
>>>>>         * doc/invoke.texi: Fix typo.
>>>>>         * dumpfile.c: Add support for documented -fdump-* options
>>>>>         optimized/missed/note/optall.
>>>>>
>>>>> Index: doc/invoke.texi
>>>>> ===================================================================
>>>>> --- doc/invoke.texi     (revision 210157)
>>>>> +++ doc/invoke.texi     (working copy)
>>>>> @@ -6278,7 +6278,7 @@ passes).
>>>>>  @item missed
>>>>>  Enable showing missed optimization information (only available in certain
>>>>>  passes).
>>>>> -@item notes
>>>>> +@item note
>>>>>  Enable other detailed optimization information (only available in
>>>>>  certain passes).
>>>>>  @item =@var{filename}
>>>>> Index: dumpfile.c
>>>>> ===================================================================
>>>>> --- dumpfile.c  (revision 210157)
>>>>> +++ dumpfile.c  (working copy)
>>>>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>>>>    {"nouid", TDF_NOUID},
>>>>>    {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>>>>    {"scev", TDF_SCEV},
>>>>> +  {"optimized", MSG_OPTIMIZED_LOCATIONS},
>>>>> +  {"missed", MSG_MISSED_OPTIMIZATION},
>>>>> +  {"note", MSG_NOTE},
>>>>> +  {"optall", MSG_ALL},
>>>>>    {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
>>>>>             | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>>>>             | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)},
>>>>>
>>>>>
>>>>> --
>>>>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>>
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413



-- 
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-06-26 17:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-09 15:54 [PATCH] Add missing -fdump-* options Teresa Johnson
2014-05-13  8:39 ` Richard Biener
2014-05-13 13:18   ` Teresa Johnson
2014-05-13 15:19   ` Xinliang David Li
2014-06-25 14:22     ` Teresa Johnson
2014-06-26  7:40       ` Richard Biener
2014-06-26 17:46         ` Teresa Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).