From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 9D6073AA8C0A for ; Thu, 17 Nov 2022 15:37:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D6073AA8C0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lj1-x22a.google.com with SMTP id b9so3202439ljr.5 for ; Thu, 17 Nov 2022 07:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8IIRs/0oYnUJoXmrMSaxgvXbbHU+x4nyFe8MnQKC0A0=; b=sPfCnFH10cJxfnUYU6dCRoHfMkZfbd/rsKrzk45ic1jK0zwXQDfOlsFWREHr4YnGrk 8DH6mur2uENCfkcDEgEd3kefILP29EC/2je/ytDGJDJUQg5ReuqdzH6e0no2Llu8/QVf Sltit6ymDrjFL1bWJLCrRtZyLMNWqrKiC6j4UoeQOmfllkA2SMAoeo+jm24K5vxg20mq pTvoFx8cA8+eK3Y7klv2fcaY1jYr4P8vAfuiyAR9yZVzEC8pSUEKQ/OhhtLvdoDbqs7v dhbbYz9wzp4FJnR7/sU3CwDRS3kj/ZfDI790VrrirZL3wQahjZ9HFtowiDA40D5/APcV zZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8IIRs/0oYnUJoXmrMSaxgvXbbHU+x4nyFe8MnQKC0A0=; b=m8uzMDv/FhJuBUfwjOBe5DmfA5GpTqQCjzycwf1TU8SJ8i10kRgTwPu12m4KaenL7Y 2XyGShV+rZUC7J9tmIzEUXjSBvM1AVOJh8cKpCuQpcz8OzQPZsoSQkcNBHDbirPBctrX ELS8xljZu+grhBTG9TWqH2EU2Xm3kGUECfgSR+GikgHS/RuueAP1tjd5dCrcGvtLfiBR 86QQCyFvD86kIqYFFUDaTPv0iy2LzQAomGkcu4kX982vYuWFmOciyH4xh+EBJLt5x/gW WIqvxE4RO3gKfgF/9XbVVeLqbLLp4gKCxUEbRc24RfbK22aPVyfOzLQCAC86Y5tF6a5w G5gA== X-Gm-Message-State: ANoB5pnOB6y7n4q7z1vFUw0R8785a/R/ZKZjs+/WBC/aSLxMYN/Lm+pk zRtCwxOZ2Ce9GjQpRFL05NZ+gxaeF8OylO8FrM2pQQ== X-Google-Smtp-Source: AA0mqf6ZSgpKgWEuNbKZpy9LKDB20d3MkcNG2PKDLbdVRtjsjyv8EFPE6udOk3VevlCpMkcfiFNy+u0EaS6rNQd9PkY= X-Received: by 2002:a2e:b6c2:0:b0:276:ffd1:d7c8 with SMTP id m2-20020a2eb6c2000000b00276ffd1d7c8mr1151209ljo.176.1668699443137; Thu, 17 Nov 2022 07:37:23 -0800 (PST) MIME-Version: 1.0 References: <20221110213617.3592572-1-philipp.tomsich@vrull.eu> <1d164b26-57b6-8c17-18cd-79e8dc77d29d@gmail.com> In-Reply-To: <1d164b26-57b6-8c17-18cd-79e8dc77d29d@gmail.com> From: Philipp Tomsich Date: Thu, 17 Nov 2022 16:37:11 +0100 Message-ID: Subject: Re: [PATCH] RISC-V: Optimize masking with two clear bits not a SMALL_OPERAND To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Jeff Law , Palmer Dabbelt , Christoph Muellner , Kito Cheng , Vineet Gupta Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied to master. Thanks! Philipp. On Thu, 17 Nov 2022 at 15:30, Jeff Law wrote: > > > On 11/10/22 14:36, Philipp Tomsich wrote: > > Add a split for cases where we can use two bclri (or one bclri and an > > andi) to clear two bits. > > > > gcc/ChangeLog: > > > > * config/riscv/bitmanip.md (*bclri_nottwobits): New pattern. > > (*bclridisi_nottwobits): New pattern, handling the sign-bit. > > * config/riscv/predicates.md (const_nottwobits_operand): > > New predicate. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/zbs-bclri.c: New test. > > Don't we only have to worry about (subreg:DI (reg:SI )) to preserve the > extension constraints? Not that I think there's any value in allowing > HI/QI, mostly wanting to double check my understanding of the extension > constraints. > > > OK > > jeff >