From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 667D03858D33 for ; Wed, 9 Nov 2022 09:27:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 667D03858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lf1-x12a.google.com with SMTP id c1so23125618lfi.7 for ; Wed, 09 Nov 2022 01:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gW6AHgsMmTqOGZ11bxCLujOYYN0uiIRV4YFSV71F+uA=; b=Jq/BIDxQg+/pVWNJYERm269BVZdoQtPgoRYcxLT8TBhBXSmrTHRUPr511+/8DTQ/OW k+XWIiMd4ciSXuK1c8+q5iVkmM4V2RF60tsnOadBQJVxnDJXa1cSbVCSwdCASlGR9TNB /JHX2K6KThea7kqpfnPyhCww2WarsB+lGJFm0JNmewRoaAbSa76rUdDDPdCyrnF9SV1P jukCV+yZIsekkSrU86rcN6ltD41SyUXSQdnAn7X/QUixHVlFBPwJJ+mznj1Wfv6a8R4y ztiA3a2UB6er4B3/UhBeFOOlf8fP7KQlxxw9KQoFwZewNuyVEhU/x3Ho4YR94N+kI/9T qKnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gW6AHgsMmTqOGZ11bxCLujOYYN0uiIRV4YFSV71F+uA=; b=OiIVpGJTgmnIHuuxqWUa2zDyXLBPDKQl2FUPLDzumHiEBzaiN7zhBttU8jzQZlWGgL PXYKJFOS3l1Gg7TOB1Xs0VhS3yUVfKm8+PnnhKXmXpx/0iCIHe/tfGzjsBbqqXHSusEx uKm67Uc1uykfuhKDIHbKv/37BgsfJf2aTHNpDB3FiF73qJ72cB1lBgtUXhgY7XiklARx sP8QQziNLGMHSJm8vPhKPwGNmuN2MQb3qWl32WloHuCf878/NxTMiwvztk6P0xJWRC5L JbpE2cu8QYjYmmPUsy2iCMwXyRM4YPGmNQJw6D4R3Tbn6mp7KckZGqn1g+zSY2KReABa aFOw== X-Gm-Message-State: ACrzQf24Ki3C+y/iIMfGQzfzGRZjSgbBSavmwcsMYjU/R5WNGqBMCkUR in4FQhRuwgl8YHuIpMDfbPOW9EWGG5v2vLZaPGPBIA== X-Google-Smtp-Source: AMsMyM6JcoEO7vrycibOTE4b675Fx3X2lsYI4H0BOfUpg+Jx3wfTsAawyFdg6Nsx4stJ7eAqzVf4Wci4rCoOr8mBRfU= X-Received: by 2002:a05:6512:25d:b0:4a2:6e28:5d43 with SMTP id b29-20020a056512025d00b004a26e285d43mr19537917lfo.10.1667986046954; Wed, 09 Nov 2022 01:27:26 -0800 (PST) MIME-Version: 1.0 References: <84c1e229-dcfe-380a-ba6e-d4621aba0589@gmail.com> In-Reply-To: From: Philipp Tomsich Date: Wed, 9 Nov 2022 10:27:15 +0100 Message-ID: Subject: Re: [PATCH] RISC-V: costs: handle BSWAP To: Andrew Pinski Cc: Palmer Dabbelt , jeffreyalaw@gmail.com, gcc-patches@gcc.gnu.org, Kito Cheng , christoph.muellner@vrull.eu, Vineet Gupta , jlaw@ventanamicro.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 9 Nov 2022 at 05:43, Andrew Pinski wrote: > > On Tue, Nov 8, 2022 at 7:16 PM Palmer Dabbelt wrote: > > > > On Tue, 08 Nov 2022 18:57:26 PST (-0800), jeffreyalaw@gmail.com wrote: > > > > > > On 11/8/22 12:54, Philipp Tomsich wrote: > > >> The BSWAP operation is not handled in rtx_costs. Add it. > > >> > > >> With Zbb, BSWAP for XLEN is a single instruction; for smaller modes, > > >> it will expand into two. > > >> > > >> gcc/ChangeLog: > > >> > > >> * config/riscv/riscv.c (rtx_costs): Add BSWAP. > > > > > > OK. > > > > It's riscv_rtx_costs. > > > > (I don't usually read ChangeLog entries that closely, just happened to > > stumble on it when poking around.) > > Using contrib/git-commit-mklog.py can help here to make sure you > always get the correct format for the changelog and it does a decent > job of figuring out function names too. > You can also use contrib/gcc-git-customization.sh to install it such > that you can use it when doing git commits. > After invoking that inside the GCC git; you can just do "git > gcc-commit-mklog ...." Where .... would be what you normally put for > "git commit" (but as if in the toplevel directory). We always pass them through contrib/mklog,py (or git-commit-mklog.py, which invokes it) anyway, but (as the ".c" in the filename indicates) this one hasn't been refreshed in over a year's time. Don't worry, this will need to get adjusted again once I merge it (as the commit hooks won't let it pass). Philipp.