From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id A61353858D38 for ; Thu, 10 Nov 2022 13:58:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A61353858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lj1-x232.google.com with SMTP id d20so1190181ljc.12 for ; Thu, 10 Nov 2022 05:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QxF4mbF3P4UBp1QPw5ejdqlTm9SRjzh+29JU+iVV8Go=; b=PHog/4/luqq3872Z8tBD7vb3H5aEL+0N1Yzv50TEjpcJGf7i00Bvq8fcQJFGp3W9Mc hmHZRE7LgZxPcGNApIl2bWp821OKnglb/nCJ0oTInxWUENwhnROgAx0BVTZpUNLUbjWr +3Lw1pm+PsRT/oau7zygoiaNX98h1RqrSFXhLd3F34T7SVQxpTklBFDPVZtYVNdLAI27 /Ktw6nWa/c7OW2V4WJzYJqCIheldOmIsxKz6zwCLt2vcHnSzy679BN49cNSIM+6BjmYF aM8b9VB6YE5MlT1NGTHaBd6z1/LZIpNrfLkgFkXUOt6hZws1BY77wHcIRS5Pmo+Y6Vgd GgEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QxF4mbF3P4UBp1QPw5ejdqlTm9SRjzh+29JU+iVV8Go=; b=a7jbLo0svc6PB7sb2MFprxfr5oOLE0NXzZnGu635Oi3iTGUayp3G3OanQ8E/ER2Btp dIfhgHYyqhI4/DKuroMspl2sRZx7NRs8Y7fMCT9WPbwIQ8z8hnXgV+xx+BAYkpgMatL1 AwFdWaQenwz1oRdrIP8WRw83DvDmxBxhG7Zaipf/+gGpBZs96HRSN8bkvqkp5RJ6h3xm bo/WxQmJAcCA2fI3Vq1hnVsuwdNBAz32e60YYfA1Ag0Pc+VXG/+PW9t6nXkWBoH4uCAF yubbe3GbNXND4WzP7g/kvJD8LVVTZEsPZYjdWDjjsaEulnceBwwX5Sa6dWrmXEcX8d3Y LrOw== X-Gm-Message-State: ACrzQf19+ie7HZqFl//RHhNl2exuYBdG2S7snBf4DtcgOYac16Zq5W08 wKrmRGXRzcylKimM0wOL92AxRYiKLyvdTCKHMyaQbw== X-Google-Smtp-Source: AMsMyM6KEpzhXEonhdHuj8Mc6KinLzxeK4peadCDLPaMe3Tb87f2Oo1qeLLrLwUuptDmKX756qrZHfcCqNYpFq9/n8o= X-Received: by 2002:a2e:bc29:0:b0:277:1273:f3b8 with SMTP id b41-20020a2ebc29000000b002771273f3b8mr8551198ljf.178.1668088708068; Thu, 10 Nov 2022 05:58:28 -0800 (PST) MIME-Version: 1.0 References: <20221109234948.3279391-1-philipp.tomsich@vrull.eu> In-Reply-To: From: Philipp Tomsich Date: Thu, 10 Nov 2022 14:58:16 +0100 Message-ID: Subject: Re: [PATCH] RISC-V: Fix selection of pipeline model for sifive-7-series To: Kito Cheng Cc: gcc-patches@gcc.gnu.org, Palmer Dabbelt , Christoph Muellner , Jeff Law Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied to master, thank you! On Thu, 10 Nov 2022 at 02:03, Kito Cheng wrote: > > LGTM, thank you for catching that!! > > On Wed, Nov 9, 2022 at 3:50 PM Philipp Tomsich wrote: > > > > A few of the gcc.target/riscv/mcpu-*.c tests have been failing for a > > while now, due to the pipeline model for sifive-7-series not being > > selected despite -mtune=sifive-7-series. The root cause is that the > > respective RISCV_TUNE entry points to generic instead. Fix this. > > > > Fixes 97d1ed67fc6 ("RISC-V: Support --target-help for -mcpu/-mtune") > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-cores.def (RISCV_TUNE): Update > > sifive-7-series to point to the sifive_7 pipeline > > description. > > > > Signed-off-by: Philipp Tomsich > > --- > > > > gcc/config/riscv/riscv-cores.def | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gcc/config/riscv/riscv-cores.def b/gcc/config/riscv/riscv-cores.def > > index b84ad999ac1..31ad34682c5 100644 > > --- a/gcc/config/riscv/riscv-cores.def > > +++ b/gcc/config/riscv/riscv-cores.def > > @@ -36,7 +36,7 @@ > > RISCV_TUNE("rocket", generic, rocket_tune_info) > > RISCV_TUNE("sifive-3-series", generic, rocket_tune_info) > > RISCV_TUNE("sifive-5-series", generic, rocket_tune_info) > > -RISCV_TUNE("sifive-7-series", generic, sifive_7_tune_info) > > +RISCV_TUNE("sifive-7-series", sifive_7, sifive_7_tune_info) > > RISCV_TUNE("thead-c906", generic, thead_c906_tune_info) > > RISCV_TUNE("size", generic, optimize_size_tune_info) > > > > -- > > 2.34.1 > >