From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 9499E3858D28 for ; Tue, 1 Aug 2023 22:07:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9499E3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-522c9d388d2so3384955a12.3 for ; Tue, 01 Aug 2023 15:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1690927633; x=1691532433; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sED7usGXEENqj1Bp+1IHMbBm4RAvCJcGS/9/TerESyQ=; b=QgWxOraAn9q/dPNdTQQeS8erf9LJRjHxzB42/ZA4DtybdmyqTDE4NH5bPg6L8D9Jo7 ctOw77FvDESrr52Elzkq/pdT5rtb60djg0iVKMKxeqStt33+gcY0rfMQWCt0o1FweVE6 wBDx+r2L7C8W6lzqCkEIvUFjWrUGBBlW6YFgccQcOP0abJfDpF03KOt4G6Cj+Sm6mwym bext8jGr1JXxX8Bk6sb0PVrjUDZoyQ16QQyRQdihem39VppyDzc5ed/RIWGjqrnBQ8r6 KYuCBFeaa9UKsD9egl9qCW9D7YPRrEcU1HDIHDrUxSrxeMa9dpcL2+gSvchGO1LqPiXA qvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690927633; x=1691532433; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sED7usGXEENqj1Bp+1IHMbBm4RAvCJcGS/9/TerESyQ=; b=LKxr1GkpHt6WcrcvLEdCkFuueci6hmv3d3t5yuGd72d3ryPb0u6/i6c662GIWO0+YW 8y9r4fjEZe58u49ODIf9Kg8eDyWnQs2TVDzg3waHuxvamtSWZYy7rM8Uo0GJeugHr9cg h8pHWGJFzeGaBAnNKByqzUZPX0PzYmWtU5B3fYpVlh8DmQscJEIE/UULyBfWAzI2TNTJ GdOrR3wDp665P1PWIkBtGhdEBgKH1Jbmba/M9ScwXcr8kyNVCTWEKVMKoMbh8iZ59VBa DfmL8PESa8uHnsihqT5h36irhd7lvY6Cqb4dE9WREKQMXBq8tb4fe4okpB/BWXRkRmbM f0dQ== X-Gm-Message-State: ABy/qLZTFhnFSV+i1fBe1VSJxpKMFoIucv3VbhQdmO1zE0TpcY/FDuSZ iwEJkaGhLVOFEbpHjOk+E1i2cfBwblACK/qLrJq07g== X-Google-Smtp-Source: APBJJlEhSkSyMtJcBqiFYTxqaviE7rG5wroDLP+Fo6FCA7ZyBtz+Cpz56jWrE1kQ3A0TkxyRHNKaNc73XNvtPNccX2E= X-Received: by 2002:aa7:d80b:0:b0:522:2111:105d with SMTP id v11-20020aa7d80b000000b005222111105dmr3405699edq.20.1690927633233; Tue, 01 Aug 2023 15:07:13 -0700 (PDT) MIME-Version: 1.0 References: <3c1f0f8a-34ed-abb2-8a49-3083a2cc55d2@gmail.com> <61c9b9c2-f52e-2b4e-6d02-62c991603c39@gmail.com> <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> In-Reply-To: <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> From: Philipp Tomsich Date: Wed, 2 Aug 2023 00:07:02 +0200 Message-ID: Subject: Re: RISC-V: Folding memory for FP + constant case To: Jeff Law , Manolis Tsamis Cc: Vineet Gupta , Jivan Hakobyan , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: +Manolis Tsamis On Tue, 1 Aug 2023 at 23:56, Jeff Law via Gcc-patches wrote: > > > > On 8/1/23 13:14, Vineet Gupta wrote: > > > > > I have some numbers for f-m-o v3 vs this. Attached here (vs. inline to > > avoid the Thunderbird mangling the test formatting) > Thanks. Of particular importance is the leela change. My recollection > was that the f-m-o work also picked up that case. But if my memory is > faulty (always a possibility), then that shows a clear case where > Jivan's work picks up a case not handled by Manolis's work. f-m-o originally targeted (and benefited) the leela-case. I wonder if other optimizations/changes over the last year interfere with this and what needs to be changed to accomodate this... looks like we need to revisit against trunk. Philipp. > And on the other direction we can see that deepsjeng isn't helped by > Jivan's work, but is helped by Manolis's new pass. > > I'd always hoped/expected we'd have cases where one patch clearly helped > over the other. While the .25% to .37% improvements for the three most > impacted benchmarks doesn't move the needle much across the whole suite > they do add up over time. > > Jeff