From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Manolis Tsamis <manolis.tsamis@vrull.eu>,
gcc-patches@gcc.gnu.org, Vineet Gupta <vineetg@rivosinc.com>,
Jivan Hakobyan <jivanhakobyan9@gmail.com>,
Jeff Law <law@gcc.gnu.org>
Subject: Re: [PATCH] cprop_hardreg: Allow more propagation of the stack pointer.
Date: Mon, 7 Aug 2023 19:32:47 +0200 [thread overview]
Message-ID: <CAAeLtUAXrOKRdB-HsKx-LpZiRsvUomBNauL-poDt0uruRx_QdQ@mail.gmail.com> (raw)
In-Reply-To: <50a88a57-c02a-1c77-83be-7d522619622b@gmail.com>
Applied to master, thanks!
--Philipp.
On Mon, 7 Aug 2023 at 19:20, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 8/7/23 05:31, Manolis Tsamis wrote:
> > The stack pointer propagation fix 736f8fd3 turned out to be more restrictive
> > than needed by rejecting propagation of the stack pointer when REG_POINTER
> > didn't match.
> >
> > This commit removes this check:
> > When the stack pointer is propagated it is fine for this to result in
> > REG_POINTER becoming true from false, which is what the original code checked.
> >
> > This simplification makes the previously introduced function
> > maybe_copy_reg_attrs obsolete and the logic can be inlined at the call sites,
> > as it was before 736f8fd3.
> >
> > gcc/ChangeLog:
> >
> > * regcprop.cc (maybe_copy_reg_attrs): Remove unnecessary function.
> > (find_oldest_value_reg): Inline stack_pointer_rtx check.
> > (copyprop_hardreg_forward_1): Inline stack_pointer_rtx check.
> OK
> jeff
prev parent reply other threads:[~2023-08-07 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:31 Manolis Tsamis
2023-08-07 17:20 ` Jeff Law
2023-08-07 17:32 ` Philipp Tomsich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeLtUAXrOKRdB-HsKx-LpZiRsvUomBNauL-poDt0uruRx_QdQ@mail.gmail.com \
--to=philipp.tomsich@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jivanhakobyan9@gmail.com \
--cc=law@gcc.gnu.org \
--cc=manolis.tsamis@vrull.eu \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).