public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Lin Sinan <mynameisxiaou@gmail.com>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
	palmer@dabbelt.com,  andrew@sifive.com,
	Lin Sinan <sinan.lin@linux.alibaba.com>
Subject: Re: [PATCH] RISC-V: Fix wrong partial subreg check for bsetidisi
Date: Tue, 28 Feb 2023 10:32:02 +0100	[thread overview]
Message-ID: <CAAeLtUAi9H_0BGP4kSgniSf4xB45bxTSRWN1OwHDf87Mna9zvQ@mail.gmail.com> (raw)
In-Reply-To: <20230228050036.30601-1-mynameisxiaou@gmail.com>

On Tue, 28 Feb 2023 at 06:00, Lin Sinan <mynameisxiaou@gmail.com> wrote:
>
> From: Lin Sinan <sinan.lin@linux.alibaba.com>
>
> The partial subreg check should be for subreg operand(operand 1) instead of
> the immediate operand(operand 2). This change also fix pr68648.c in zbs.

Good catch.
Reviewed-by: <philipp.tomsich@vrull.eu>

  parent reply	other threads:[~2023-02-28  9:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28  5:00 Lin Sinan
2023-02-28  5:12 ` Sinan Lin
2023-02-28  9:32 ` Philipp Tomsich [this message]
2023-03-05  9:27   ` Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAeLtUAi9H_0BGP4kSgniSf4xB45bxTSRWN1OwHDf87Mna9zvQ@mail.gmail.com \
    --to=philipp.tomsich@vrull.eu \
    --cc=andrew@sifive.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kito.cheng@gmail.com \
    --cc=mynameisxiaou@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=sinan.lin@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).