From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <philipp.tomsich@vrull.eu>
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235])
	by sourceware.org (Postfix) with ESMTPS id 4EDF1393BA53
	for <gcc-patches@gcc.gnu.org>; Tue, 15 Nov 2022 21:14:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EDF1393BA53
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu
Received: by mail-lj1-x235.google.com with SMTP id b9so19280853ljr.5
        for <gcc-patches@gcc.gnu.org>; Tue, 15 Nov 2022 13:14:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=vrull.eu; s=google;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=FaLhu2lbT1VjZSjxNHbLao9iSxLAxIjG0zx8lPo4IMo=;
        b=QciMWOmx6/zU1pB2bI1whSW+mV++RRnWCaBCH+TmBbEUVSdRZxENQ4tkMI+gQGnbwd
         +TPu/blZEAzLu4Jc+0c/oEAqUQkZRGwO9l0ACA/DkVBdE0Cwb+/CWENqmIXyy4tWGf9i
         Ovc61RwQBXeF5Dzi47MGrEaWrtpI012hLH2Du1SF1KKMmcICfIyxh8pGP28l7tb4RrbU
         2BIyEH5t8FUCslkmo48Uh/C+sxEzqDDF18Tqn9209PXJapnQa2c85Ckpgd6WVlvD86Xh
         SF8WIw4uupOZ6RrMvdeV/Aw5Qtd8CLA0tJZDdI2l7BK5q7bse4fC3Q8+LpxgLGTR09TR
         EgeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=FaLhu2lbT1VjZSjxNHbLao9iSxLAxIjG0zx8lPo4IMo=;
        b=mXPW+nodXcOXOTcnIRrW7sNjICvrUv9nwcvRqie5FIrGQn9w3WX4aXXlAkyU0YBO0y
         BoAP7kT+m5emTVYIxYNj4i7RLXYrpkkDihPIEtSgUIKIEHwfvrsRhgo8LpzlS7OtMbrT
         OYQUKwHp2IJqoGAISmtE2s8/yPq8CvdJ1IzUz1YP1EnXRCzCm995o/m/yvywGxBjmDOW
         mtL8IJS6f5gkTjSZjzzP/IhObLotGpMjlpHJZS1r6+y3US7hSsFb09ed7zvPm4oH488D
         SEXH8+cCBf7H+3jBkqwMCwxFEbPyFsGi3sGmvwvDbLS0AH2+AoROibkIujxXYah0iZDs
         /OQw==
X-Gm-Message-State: ANoB5pk/bmtGjWR+AdGiCzqL3WLXoyjr2vg0RFDyBrXvSETTTSL6oVBD
	QDlVdQ4wEpZ5l9uFob/FoR8ELcpTfzzB7D+0/hpkng==
X-Google-Smtp-Source: AA0mqf4DvRSYFUywarongnxARSldlj1LbWtUuYAQMQX3ZPj8V+x+OH5udXKqAVoc3Cutyr99M6Cij0ePawTlM+o4HAc=
X-Received: by 2002:a05:651c:11cb:b0:26e:6fb:4845 with SMTP id
 z11-20020a05651c11cb00b0026e06fb4845mr6342689ljo.120.1668546881763; Tue, 15
 Nov 2022 13:14:41 -0800 (PST)
MIME-Version: 1.0
References: <20221113204119.4061447-1-philipp.tomsich@vrull.eu> <d00234c0-9065-1926-ed35-7dbd7e18791a@gmail.com>
In-Reply-To: <d00234c0-9065-1926-ed35-7dbd7e18791a@gmail.com>
From: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue, 15 Nov 2022 22:14:30 +0100
Message-ID: <CAAeLtUAoY0=emr0FCs=kitz1pa+2PJdEbBTQeUYyFn7q93Y+Dg@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Use .p2align for code-alignment
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Christoph Muellner <christoph.muellner@vrull.eu>, 
	Palmer Dabbelt <palmer@rivosinc.com>, Vineet Gupta <vineetg@rivosinc.com>, 
	Kito Cheng <kito.cheng@gmail.com>, Jeff Law <jlaw@ventanamicro.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Jeff,

On Tue, 15 Nov 2022 at 17:37, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 11/13/22 13:41, Philipp Tomsich wrote:
>
> RISC-V's .p2align (currently) ignores the max-skip argument.  As we
> have experimental patches underway to address this in a
> backwards-compatible manner, let's prepare GCC for the day when
> binutils gets updated.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.h (ASM_OUTPUT_MAX_SKIP_ALIGN): Implement.
>
>
> What are the implications if we start using p2align immediately when the =
current (broken?) state of the assembler?  I'm pretty sure configure is alr=
eady turning on HAVE_GAS_SKIP_P2ALIGN.  From a native risc-v build:
>
>
> auto-host.h:#define HAVE_GAS_MAX_SKIP_P2ALIGN 1

This is your tree, which has the (partial fix =E2=80=94 i.e., the best we c=
an
do without breaking backward compatibility) for .p2align.
When building against upstream binutils, this should not be defined.

Philipp.