From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 530A23853D4D for ; Fri, 18 Nov 2022 20:24:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 530A23853D4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lf1-x133.google.com with SMTP id c1so10005510lfi.7 for ; Fri, 18 Nov 2022 12:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/JlZLIabfnNaKUJMe80Zuvk+EOs2Gy6PtbId6x2v0c8=; b=ovvIpew9Ad2gyYEzhJKz3eTDGf8mT+IM/GF+SWU1O+eqeedGA8qhgpp6uZinoLs0sL DxCh0p8XW8MhaUhk/GLhMmhEFvoBt9GEeplowmn/F+hFobKWX3ahCqHf+ZtgsAXGP3D6 E9c5sqqzE/GgB3cvaDQ6gbZtk/H+klL9+so65gEjznhK+Yilp7siS94kSF9rdy/UPcim hVOu/gH5imxUzZSDzwxKNzfBxIealaJPZ112PCpqD/ya1UZ1rs19JkxxvPEOGb8YGVBg 2FFEQKwGdsOTGBPH/4rRGMShEkaPFseL83kcFToahqbU/en4qEaQnWAejk1SWp4ldbe8 Ip1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/JlZLIabfnNaKUJMe80Zuvk+EOs2Gy6PtbId6x2v0c8=; b=I9al30J8lAshZDKanWyGIU5+4oaIxp7AbtHy0etkNPyDiZkYIOVdXQA6w2XMvE1GMk y2DylmSf6f4VH+hcsu6peaI3SY/bRPHYt03s7x+P2a+sPq//EQ7gsJ5YO7mdGcJ3fM3E 1xVjUCnYyVyMh/uIXPFtkNdtEXILKP0YveO/+VJE6XS4icywgx+jHF1lPqvEkK919kVj AiYUA5YktkO0i4tzEGNjWqNIg3b/jZJlob8FCI3HuFW2Oh96OI/yhkNYXJb4Op9lFXbY ZEIpUEYjbZd9Dt1upYCbceH0nEEdciV8Gexi9fTN2XEV1Q6rZn7lFHsccPrPtlLIpZxm dvpw== X-Gm-Message-State: ANoB5pl+a+/OWM7QcGWZ8esMaQeeffyaFC8ZWmcBrJyU7+bR23VMTQVc mYE+276hwJ/zRicMnNVTsSjW2yD8GzUhJ2hFrQQGIg== X-Google-Smtp-Source: AA0mqf56BJTbjFYcb5b/I82ZPmH6xfhDBsdYtrHQ/rwf0kP+h4vJv1Cn04TWT3H5CnWn/M4XarLZKbXrg/xBwgpMtBc= X-Received: by 2002:ac2:47e3:0:b0:4b4:1324:6ed3 with SMTP id b3-20020ac247e3000000b004b413246ed3mr2864775lfp.19.1668803051792; Fri, 18 Nov 2022 12:24:11 -0800 (PST) MIME-Version: 1.0 References: <20221109000631.2814859-1-philipp.tomsich@vrull.eu> <44c463f0-5ef7-abc7-bc9b-e2c195394086@gmail.com> In-Reply-To: <44c463f0-5ef7-abc7-bc9b-e2c195394086@gmail.com> From: Philipp Tomsich Date: Fri, 18 Nov 2022 21:24:00 +0100 Message-ID: Subject: Re: [PATCH v2] RISC-V: No extensions for SImode min/max against safe constant To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jeff Law , Christoph Muellner , Palmer Dabbelt , Vineet Gupta Content-Type: multipart/alternative; boundary="0000000000001a37bc05edc47d21" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001a37bc05edc47d21 Content-Type: text/plain; charset="UTF-8" Applied to master. Thanks! --Philipp. On Fri, 18 Nov 2022 at 21:11, Jeff Law wrote: > > On 11/8/22 17:06, Philipp Tomsich wrote: > > Optimize the common case of a SImode min/max against a constant > > that is safe both for sign- and zero-extension. > > E.g., consider the case > > int f(unsigned int* a) > > { > > const int C = 1000; > > return *a * 3 > C ? C : *a * 3; > > } > > where the constant C will yield the same result in DImode whether > > sign- or zero-extended. > > > > This should eventually go away once the lowering to RTL smartens up > > and considers the precision/signedness and the value-ranges of the > > operands to MIN_EXPR nad MAX_EXPR. > > > > gcc/ChangeLog: > > > > * config/riscv/bitmanip.md (*minmax): Additional pattern for > > min/max against constants that are extension-invariant. > > * config/riscv/iterators.md (minmax_optab): Add an iterator > > that has only min and max rtl. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/zbb-min-max-02.c: New test. > > Ok > > jeff > > > --0000000000001a37bc05edc47d21--