From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id EDEDD3858C50 for ; Mon, 17 Apr 2023 10:20:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDEDD3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-ej1-x635.google.com with SMTP id fw30so9920041ejc.5 for ; Mon, 17 Apr 2023 03:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1681726826; x=1684318826; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wtQVOHqs5hdih2Gb1WKVM/OFo72xBMvnNM5l0+iY0d8=; b=ViHXOcP4Mq9XplbwVha8BJpf6IpA4dqodqBLxlKjVKzue9JRpsgAqKPuXBW4MM7A+z ZlYkerP1kqqjd6L6HgN8T5WC+uFzME3fDVpdz4Ybe0jwJdBfFJUWQMaToXpGd5e8LIoZ c33zUUTUg5m0lBINN0DtKHrQjJmCU2jKkt4FSXULQ7qE+vDHI6C1j0D3eUp+4Jo04AAv JkjUgQ9gFh0EuKzhUzMNPd+7THYbJX705JdvHHRhN/841dYopCfhgiS4vBl+3I8RFILb 6jstGlRyQYA94XVe068IGE2OQ+vhUbvBQW3opEw87rdjfer2dSJ7E1RWBoA/JNsgfj1o YA+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681726826; x=1684318826; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wtQVOHqs5hdih2Gb1WKVM/OFo72xBMvnNM5l0+iY0d8=; b=Zo6IpuPLSdiPGOwVjJuOJxp0ykC32j9y6Bxp+VuVfexmw/F1G1R+U1/vvqLJl6ZACG eUMJ+8flEAwvnZBHzNZ0YrynhZGDJOdTOYRyvj0tEHfuvTRAFS67wnO+k4fjJzDFxgq4 wcAp3QrJHx5OuAgY5WQacXIrLydi7aI0t3g4Q15EZnLNDLldOAjdDbKhbr6njQfiKAEs 9MqQZbAxkarAMXn5Yv+/DXWFg+ddgYUpKMro+Tn+8US2QNMBFz0wfSx1mjXsRA3RM205 nQ6o10mAB0FoPtXBFDIunreEyJfL3Xf6CU52fm70hU6puNqF6U2v25LjkCS+F4pxFKbf tIWg== X-Gm-Message-State: AAQBX9eav7ky0ltzrWOKNmkZy6ogwSqmbKNGVeKsRIfe3X/pcnGwF5W4 MCXUXAptID3szxw9SeIaz05SrsJvcxv6uzSIjKyYhGFXo5jTHVTV X-Google-Smtp-Source: AKy350b/6RuwrvPv+VkV35b2U5KJCjqdapht3NvmiUzjS6DHkcVh0IpjcZWvL7abTuyJNz6FSLod+KJJvchsjUIvnGQ= X-Received: by 2002:a17:906:5610:b0:94e:ff23:992a with SMTP id f16-20020a170906561000b0094eff23992amr7934460ejq.59.1681726826371; Mon, 17 Apr 2023 03:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20230414180543.1497603-1-philipp.tomsich@vrull.eu> In-Reply-To: From: Philipp Tomsich Date: Mon, 17 Apr 2023 12:20:15 +0200 Message-ID: Subject: Re: [PATCH v2] aarch64: disable LDP via tuning structure for -mcpu=ampere1/1a To: Kyrylo Tkachov Cc: "gcc-patches@gcc.gnu.org" , Di Zhao Content-Type: multipart/alternative; boundary="0000000000001873dd05f9858adc" X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001873dd05f9858adc Content-Type: text/plain; charset="UTF-8" Applied to master, thanks! Philipp. On Mon, 17 Apr 2023 at 11:56, Kyrylo Tkachov wrote: > > > > -----Original Message----- > > From: Philipp Tomsich > > Sent: Friday, April 14, 2023 7:06 PM > > To: gcc-patches@gcc.gnu.org > > Cc: Kyrylo Tkachov ; Philipp Tomsich > > ; Di Zhao > > Subject: [PATCH v2] aarch64: disable LDP via tuning structure for - > > mcpu=ampere1/1a > > > > AmpereOne (-mcpu=ampere1) breaks LDP instructions into two uops. > > Given the chance that this causes instructions to slip into the next > > decoding cycle and the additional overheads when handling > > cacheline-crossing LDP instructions, we disable the generation of LDP > > isntructions through the tuning structure from instruction combining > > (such as in peephole2). > > > > Given the code-density benefits in builtins and prologue/epilogue > > expansion, we allow LDPs there. > > > > This commit: > > * adds a new tuning option AARCH64_EXTRA_TUNE_NO_LDP_COMBINE > > * allows -moverride=tune=... to override this > > > > These changes are benchmark-driven, yielding the following changes > > (with a net-overall improvement): > > 503.bwaves_r. -0.88% > > 507.cactuBSSN_r 0.35% > > 508.namd_r 3.09% > > 510.parest_r -2.99% > > 511.povray_r 5.54% > > 519.lbm_r 15.83% > > 521.wrf_r 0.56% > > 526.blender_r 2.47% > > 527.cam4_r 0.70% > > 538.imagick_r 0.00% > > 544.nab_r -0.33% > > 549.fotonik3d_r. -0.42% > > 554.roms_r 0.00% > > ------------------------- > > = total 1.79% > > > > Signed-off-by: Philipp Tomsich > > Co-Authored-By: Di Zhao > > Ok. > Thanks, > Kyrill > > > > > gcc/ChangeLog: > > > > * config/aarch64/aarch64-tuning-flags.def > > (AARCH64_EXTRA_TUNING_OPTION): > > Add AARCH64_EXTRA_TUNE_NO_LDP_COMBINE. > > * config/aarch64/aarch64.cc (aarch64_operands_ok_for_ldpstp): > > Check for the above tuning option when processing loads. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/aarch64/ampere1-no_ldp_combine.c: New test. > > > > --- > > > > Changes in v2: > > - apply both to -mcpu=ampere1 and -mcpu=ampere1a > > - add TODO: tag, per discussions on the mailing list > > - add testcase > > > > gcc/config/aarch64/aarch64-tuning-flags.def | 3 +++ > > gcc/config/aarch64/aarch64.cc | 18 ++++++++++++++++-- > > .../aarch64/ampere1-no_ldp_combine.c | 11 +++++++++++ > > 3 files changed, 30 insertions(+), 2 deletions(-) > > create mode 100644 gcc/testsuite/gcc.target/aarch64/ampere1- > > no_ldp_combine.c > > > > diff --git a/gcc/config/aarch64/aarch64-tuning-flags.def > > b/gcc/config/aarch64/aarch64-tuning-flags.def > > index 712895a5263..52112ba7c48 100644 > > --- a/gcc/config/aarch64/aarch64-tuning-flags.def > > +++ b/gcc/config/aarch64/aarch64-tuning-flags.def > > @@ -44,6 +44,9 @@ AARCH64_EXTRA_TUNING_OPTION > > ("cheap_shift_extend", CHEAP_SHIFT_EXTEND) > > /* Disallow load/store pair instructions on Q-registers. */ > > AARCH64_EXTRA_TUNING_OPTION ("no_ldp_stp_qregs", > > NO_LDP_STP_QREGS) > > > > +/* Disallow load-pair instructions to be formed in combine/peephole. */ > > +AARCH64_EXTRA_TUNING_OPTION ("no_ldp_combine", > > NO_LDP_COMBINE) > > + > > AARCH64_EXTRA_TUNING_OPTION ("rename_load_regs", > > RENAME_LOAD_REGS) > > > > AARCH64_EXTRA_TUNING_OPTION ("cse_sve_vl_constants", > > CSE_SVE_VL_CONSTANTS) > > diff --git a/gcc/config/aarch64/aarch64.cc > b/gcc/config/aarch64/aarch64.cc > > index f4ef22ce02f..0f04ab9fba0 100644 > > --- a/gcc/config/aarch64/aarch64.cc > > +++ b/gcc/config/aarch64/aarch64.cc > > @@ -1933,7 +1933,7 @@ static const struct tune_params ampere1_tunings = > > 2, /* min_div_recip_mul_df. */ > > 0, /* max_case_values. */ > > tune_params::AUTOPREFETCHER_WEAK, /* autoprefetcher_model. */ > > - (AARCH64_EXTRA_TUNE_NONE), /* tune_flags. */ > > + (AARCH64_EXTRA_TUNE_NO_LDP_COMBINE), /* tune_flags. */ > > &ere1_prefetch_tune > > }; > > > > @@ -1971,7 +1971,7 @@ static const struct tune_params ampere1a_tunings > > = > > 2, /* min_div_recip_mul_df. */ > > 0, /* max_case_values. */ > > tune_params::AUTOPREFETCHER_WEAK, /* autoprefetcher_model. */ > > - (AARCH64_EXTRA_TUNE_NONE), /* tune_flags. */ > > + (AARCH64_EXTRA_TUNE_NO_LDP_COMBINE), /* tune_flags. */ > > &ere1_prefetch_tune > > }; > > > > @@ -26053,6 +26053,20 @@ aarch64_operands_ok_for_ldpstp (rtx > > *operands, bool load, > > enum reg_class rclass_1, rclass_2; > > rtx mem_1, mem_2, reg_1, reg_2; > > > > + /* Allow the tuning structure to disable LDP instruction formation > > + from combining instructions (e.g., in peephole2). > > + TODO: Implement fine-grained tuning control for LDP and STP: > > + 1. control policies for load and store separately; > > + 2. support the following policies: > > + - default (use what is in the tuning structure) > > + - always > > + - never > > + - aligned (only if the compiler can prove that the > > + load will be aligned to 2 * element_size) */ > > + if (load && (aarch64_tune_params.extra_tuning_flags > > + & AARCH64_EXTRA_TUNE_NO_LDP_COMBINE)) > > + return false; > > + > > if (load) > > { > > mem_1 = operands[1]; > > diff --git a/gcc/testsuite/gcc.target/aarch64/ampere1-no_ldp_combine.c > > b/gcc/testsuite/gcc.target/aarch64/ampere1-no_ldp_combine.c > > new file mode 100644 > > index 00000000000..bc871f4481d > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/aarch64/ampere1-no_ldp_combine.c > > @@ -0,0 +1,11 @@ > > +/* { dg-options "-O3 -mtune=ampere1" } */ > > + > > +long > > +foo (long a[]) > > +{ > > + return a[0] + a[1]; > > +} > > + > > +/* We should see two ldrs instead of one ldp. */ > > +/* { dg-final { scan-assembler {\tldr\t} } } */ > > +/* { dg-final { scan-assembler-not {\tldp\t} } } */ > > -- > > 2.34.1 > > --0000000000001873dd05f9858adc--