From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id F0D6D3854579 for ; Fri, 18 Nov 2022 19:58:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0D6D3854579 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lf1-x12f.google.com with SMTP id p8so9882069lfu.11 for ; Fri, 18 Nov 2022 11:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UU27G7ExQc8a0q1EGEzfLaxnLTiO4SHxJZ4/X6BNoDI=; b=FhndzQiUJqFzG6ulFB6it7wV60026pti657xeQZadBMFi7gpKOT3wUcKy1Pji4gBa1 IDXQT3APyfmZbJ9XT1ZPFSElC784bP+xdXH4mP/vdouIAhJ2lBUe7KoSw2gOMXTONNaq VkzMvwg5lgdz/jfO/xMqMLoZ+gDsp2SHMigUEFuZVPsSnh0zvbYAj+tVlT6TZStqCFsU 7HExmD3uqy8zL26s6z5yF8s+Rznf5+tgbl7c7ozfkHkev8TXL+56ORcghOX9pSPPVtPG 3Y1c7jJ4PISVgq03iizp7u240Saq7dTDFOtvQxHUVYLN7xJ+5jHQuAuT8rF9/L32s8oZ ReNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UU27G7ExQc8a0q1EGEzfLaxnLTiO4SHxJZ4/X6BNoDI=; b=yoPh/af++YntYjV4vCSHKAoYWiZ7ZatXDwgyi9SpZBqgPAS4azgVNO6NKk9fjS2NUv MKWSWngBpX9ZyAKrz/Y43Mx7L0au3uZ9OfYm2pupKDkBg+QRfKTKm2T3YZLeEaJjUFIO RxNiq9QKapQDcGTSYzdK2eISa+SRxYiLjfj1pKmsDZ1MPBoqunV9NPKIVllF0TOfpbLQ lJE0kS6xlqAzs+AcTLAFPyzz/AXZq0DsGIEtuZE8Lwbfx8BEcEd4L0WOqpWBALIHJpfb 5cLMFOKJCSDLM83zNs+kfJkqdnXD8lGPP0z1iqWGqOzLBhq2FU2FgGWw14F6ASDBK5iT ftow== X-Gm-Message-State: ANoB5pmUa3FswvjIdCFcEkSEMKF6OE+0J3bfIuLXUY+Xq7YX69KVI48F UJvWGWxrPuBX7lnR5va99Rj/gQQz2Bn/IDcUztASug== X-Google-Smtp-Source: AA0mqf7pXd4HxZNTp2xuhvWpH0fSyxE3Oc7zukYJjrgNEwAnqbOGq62ikIVHFX6nbYDUmaHhTAYxrTSYwy2MjWP6m6Y= X-Received: by 2002:ac2:47e3:0:b0:4b4:1324:6ed3 with SMTP id b3-20020ac247e3000000b004b413246ed3mr2843471lfp.19.1668801490416; Fri, 18 Nov 2022 11:58:10 -0800 (PST) MIME-Version: 1.0 References: <20221108195730.2701496-1-philipp.tomsich@vrull.eu> <0ba55dec-3d59-a63e-5e5d-c99cf89f64ca@gmail.com> In-Reply-To: <0ba55dec-3d59-a63e-5e5d-c99cf89f64ca@gmail.com> From: Philipp Tomsich Date: Fri, 18 Nov 2022 20:57:59 +0100 Message-ID: Subject: Re: [PATCH] RISC-V: Optimize slli(.uw)? + addw + zext.w into sh[123]add + zext.w To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Christoph Muellner , Palmer Dabbelt , Kito Cheng , Vineet Gupta , Jeff Law Content-Type: multipart/alternative; boundary="00000000000009911405edc420b2" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000009911405edc420b2 Content-Type: text/plain; charset="UTF-8" Applied to master. Thanks. --Philipp. On Fri, 18 Nov 2022 at 20:52, Jeff Law wrote: > > On 11/8/22 12:57, Philipp Tomsich wrote: > > gcc/ChangeLog: > > > > * config/riscv/bitmanip.md: Handle corner-cases for combine > > when chaining slli(.uw)? + addw > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/zba-shNadd-04.c: New test. > > OK. > > Something to consider. We're gaining a lot of > > (subreg:SI (reg:DI) 0) kinds of operands. > > > Would it make sense to make an operand predicate that accepted > > (reg:SI) or (subreg:SI (reg:DI) 0)? > > > It will reduce my compaints about subregs :-) But the real reason I'm > suggesting we consider adding such a predicate is, AFIACT, it it gives > combine a chance to eliminate the subreg. I haven't actually tested > this, but it seems like it might be worth a quick experiment independent > of these patches (and probably targeted towards gcc-14 rather than gcc-13). > > > > jeff > > --00000000000009911405edc420b2--