From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 33CAC3858408 for ; Thu, 22 Jun 2023 14:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33CAC3858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f9b258f3a2so48414315e9.0 for ; Thu, 22 Jun 2023 07:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1687443830; x=1690035830; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=9SXqeeQihYeow8+2JTqTmXIVolI7V0sudtkx83mVs5c=; b=Jrw1CsWFoK95GVRVXhdOeK2xYlkN79InbhdyiaQRTaTlfmYU8wwaN2XwO+cgv5Dacl 8cPsoL37PWa49GN7vyDnX3kHE1TduQfuONEAtzWBmtD8MTgnZFwkxdTxxspHTBODbNI0 vOFwflj60V8xpgFOxdev7ElGluvUmFsCXG9KN9qcBHuNscNNOhSaJqnXl/5o7w5W1HRo i881jbYm1qUfxl4e9Zx88Sgs2iIUSGOZfLS2924eufjUEtToaDln/iLJQuALkxKhbkD1 RiUiJ2EEX0vfSjGKVX5v5qZnpLejiqXflbK2iPjg+OTFYfsN3QKEVDx2LBVApS4GhSnT yusw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687443830; x=1690035830; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9SXqeeQihYeow8+2JTqTmXIVolI7V0sudtkx83mVs5c=; b=X5dFe+j3MxtQ04C9m2yYcflY4v3ppdFwtG+V2lUasrs+u8BvYhZWF2hej4FeKTLwII jTeppt/uSCeCWkKNck43oVgKxCFqsUUF6475JBSUEjd8XAA+3CBnwmA5+gbOYJMzqN9f WTcJbcJlRTawcEDEwJQqmZFmYFxqo/mnRqxOQ8YgIMKnqoAoIkK1nRxDBd1Hx+giqkZ3 8H7uU0PRR/CunSbkAEmBkAMHyJawXezstAKnNO2aQRMmp8n3RMhTTm+XnENqv+ykKchW pZY+yoFsZq21ABMwKHbPm8bjhg8ZGLxIXcER8C5rmTB/qucI4YHy7kTT6bEsObSl3HLt YcOg== X-Gm-Message-State: AC+VfDzKfWjlaY6kZtVPu2MazRdUsiSAgl1OAv4zitddk5m5hAV9psR6 RK1o4XOn0DxOizJFzLKISzYmAsdaPZoYi+pELIl8J40EshHImA3sqt0= X-Google-Smtp-Source: ACHHUZ5hEjxTOnii55mr/MXvrGYM7ObhcVw/xD7WwmNgAtSAsxJmlF993qACabIlQc7/70cyBK/gHi1F3BqdPZ8Bqvs= X-Received: by 2002:a7b:ca57:0:b0:3f9:b4a0:6062 with SMTP id m23-20020a7bca57000000b003f9b4a06062mr7473919wml.24.1687443829699; Thu, 22 Jun 2023 07:23:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Tomsich Date: Thu, 22 Jun 2023 16:23:38 +0200 Message-ID: Subject: Re: [PATCH] Change fma_reassoc_width tuning for ampere1 To: Richard Sandiford , Di Zhao OS via Gcc-patches , Di Zhao OS Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard, OK for backport to GCC-13? Thanks, Philipp. On Thu, 22 Jun 2023 at 16:18, Richard Sandiford via Gcc-patches wrote: > > Di Zhao OS via Gcc-patches writes: > > This patch enables reassociation of floating-point additions on ampere1. > > This brings about 1% overall benefit on spec2017 fprate cases. (There > > are minor regressions in 510.parest_r and 508.namd_r, analyzed here: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110279 .) > > > > Bootstrapped and tested on aarch64-unknown-linux-gnu. Is this OK for trunk? > > > > Thanks, > > Di Zhao > > > > gcc/ChangeLog: > > > > * config/aarch64/aarch64.cc: Change fma_reassoc_width for ampere1 > > Thanks, pushed to trunk. > > Richard > > > --- > > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > > index d16565b5581..301c9f6c0cd 100644 > > --- a/gcc/config/aarch64/aarch64.cc > > +++ b/gcc/config/aarch64/aarch64.cc > > @@ -1927,7 +1927,7 @@ static const struct tune_params ampere1_tunings = > > "32:12", /* loop_align. */ > > 2, /* int_reassoc_width. */ > > 4, /* fp_reassoc_width. */ > > - 1, /* fma_reassoc_width. */ > > + 4, /* fma_reassoc_width. */ > > 2, /* vec_reassoc_width. */ > > 2, /* min_div_recip_mul_sf. */ > > 2, /* min_div_recip_mul_df. */